From: kbusch@kernel.org (Keith Busch)
Subject: [PATCH v2 0/2] Adding per-controller timeout support to nvme
Date: Wed, 24 Apr 2019 14:44:17 -0600 [thread overview]
Message-ID: <20190424204417.GC15412@localhost.localdomain> (raw)
In-Reply-To: <983e5d039dce9de1d32c71d28fd59bbc01c3fee5.camel@infradead.org>
On Wed, Apr 24, 2019@10:30:08PM +0200, David Woodhouse wrote:
> It isn't that the media is slow; the max timeout is based on the SLA
> for certain classes of "fabric" outages. Linux copes *really* badly
> with I/O errors, and if we can make the timeout last long enough to
> cover the switch restart worst case, then users are a lot happier.
Gotchya. So the default timeout is sufficient under normal operation,
but temporary intermittent outages may exceed it. It'd be a real
dissappointment if the command times out with an error anyway after
waiting for the extended time, but we ought to cover the worst case
time for a successful completion.
WARNING: multiple messages have this Message-ID (diff)
From: Keith Busch <kbusch@kernel.org>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Sagi Grimberg <sagi@grimberg.me>, Jens Axboe <axboe@fb.com>,
James Smart <james.smart@broadcom.com>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
Keith Busch <keith.busch@intel.com>,
Maximilian Heyne <mheyne@amazon.de>, Amit Shah <aams@amazon.de>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v2 0/2] Adding per-controller timeout support to nvme
Date: Wed, 24 Apr 2019 14:44:17 -0600 [thread overview]
Message-ID: <20190424204417.GC15412@localhost.localdomain> (raw)
In-Reply-To: <983e5d039dce9de1d32c71d28fd59bbc01c3fee5.camel@infradead.org>
On Wed, Apr 24, 2019 at 10:30:08PM +0200, David Woodhouse wrote:
> It isn't that the media is slow; the max timeout is based on the SLA
> for certain classes of "fabric" outages. Linux copes *really* badly
> with I/O errors, and if we can make the timeout last long enough to
> cover the switch restart worst case, then users are a lot happier.
Gotchya. So the default timeout is sufficient under normal operation,
but temporary intermittent outages may exceed it. It'd be a real
dissappointment if the command times out with an error anyway after
waiting for the extended time, but we ought to cover the worst case
time for a successful completion.
next prev parent reply other threads:[~2019-04-24 20:44 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-03 12:35 [PATCH v2 0/2] Adding per-controller timeout support to nvme Maximilian Heyne
2019-04-03 12:35 ` Maximilian Heyne
2019-04-03 12:35 ` [PATCH v2 1/2] nvme: add per-controller io and admin timeouts Maximilian Heyne
2019-04-03 12:35 ` Maximilian Heyne
2019-04-03 12:35 ` [PATCH v2 2/2] nvme: add sysfs controls for " Maximilian Heyne
2019-04-03 12:35 ` Maximilian Heyne
2019-04-09 10:23 ` Christoph Hellwig
2019-04-09 10:23 ` Christoph Hellwig
2019-04-24 16:55 ` [PATCH v2 0/2] Adding per-controller timeout support to nvme Sagi Grimberg
2019-04-24 16:55 ` Sagi Grimberg
2019-04-24 20:07 ` Keith Busch
2019-04-24 20:07 ` Keith Busch
2019-04-24 20:30 ` David Woodhouse
2019-04-24 20:30 ` David Woodhouse
2019-04-24 20:44 ` Keith Busch [this message]
2019-04-24 20:44 ` Keith Busch
2019-04-24 20:58 ` Sagi Grimberg
2019-04-24 20:58 ` Sagi Grimberg
2019-04-25 5:45 ` David Woodhouse
2019-04-25 5:45 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190424204417.GC15412@localhost.localdomain \
--to=kbusch@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.