From: Christoph Hellwig <hch@infradead.org>
To: Anup Patel <Anup.Patel@wdc.com>
Cc: Albert Ou <aou@eecs.berkeley.edu>,
Palmer Dabbelt <palmer@sifive.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Christoph Hellwig <hch@infradead.org>,
Atish Patra <Atish.Patra@wdc.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
"linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>
Subject: Re: [PATCH v4 2/3] RISC-V: Add interrupt related SCAUSE defines in asm/csr.h
Date: Wed, 24 Apr 2019 22:57:57 -0700 [thread overview]
Message-ID: <20190425055757.GA30545@infradead.org> (raw)
In-Reply-To: <20190425055015.45487-3-anup.patel@wdc.com>
> +#ifdef CONFIG_64BIT
> +#define SCAUSE_IRQ_FLAG _AC(0x8000000000000000, UL)
> +#else
> +#define SCAUSE_IRQ_FLAG _AC(0x80000000, UL)
> +#endif
Please keep the existing defintion that doesn't need an ifdef..
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Anup Patel <Anup.Patel@wdc.com>
Cc: Palmer Dabbelt <palmer@sifive.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Atish Patra <Atish.Patra@wdc.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Christoph Hellwig <hch@infradead.org>,
"linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 2/3] RISC-V: Add interrupt related SCAUSE defines in asm/csr.h
Date: Wed, 24 Apr 2019 22:57:57 -0700 [thread overview]
Message-ID: <20190425055757.GA30545@infradead.org> (raw)
In-Reply-To: <20190425055015.45487-3-anup.patel@wdc.com>
> +#ifdef CONFIG_64BIT
> +#define SCAUSE_IRQ_FLAG _AC(0x8000000000000000, UL)
> +#else
> +#define SCAUSE_IRQ_FLAG _AC(0x80000000, UL)
> +#endif
Please keep the existing defintion that doesn't need an ifdef..
next prev parent reply other threads:[~2019-04-25 5:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-25 5:50 [PATCH v4 0/3] Allow accessing CSR using CSR number Anup Patel
2019-04-25 5:50 ` Anup Patel
2019-04-25 5:50 ` [PATCH v4 1/3] RISC-V: Use tabs to align macro values in asm/csr.h Anup Patel
2019-04-25 5:50 ` Anup Patel
2019-04-25 5:50 ` [PATCH v4 2/3] RISC-V: Add interrupt related SCAUSE defines " Anup Patel
2019-04-25 5:50 ` Anup Patel
2019-04-25 5:57 ` Christoph Hellwig [this message]
2019-04-25 5:57 ` Christoph Hellwig
2019-04-25 7:16 ` Anup Patel
2019-04-25 7:16 ` Anup Patel
2019-04-25 8:01 ` Christoph Hellwig
2019-04-25 8:01 ` Christoph Hellwig
2019-04-25 8:17 ` Anup Patel
2019-04-25 8:17 ` Anup Patel
2019-04-25 5:50 ` [PATCH v4 3/3] RISC-V: Access CSRs using CSR numbers Anup Patel
2019-04-25 5:50 ` Anup Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190425055757.GA30545@infradead.org \
--to=hch@infradead.org \
--cc=Anup.Patel@wdc.com \
--cc=Atish.Patra@wdc.com \
--cc=aou@eecs.berkeley.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@sifive.com \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.