All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: Claudiu.Beznea@microchip.com
Cc: robh+dt@kernel.org, mark.rutland@arm.com,
	Nicolas.Ferre@microchip.com, alexandre.belloni@bootlin.com,
	Ludovic.Desroches@microchip.com, bbrezillon@kernel.org,
	airlied@linux.ie, daniel@ffwll.ch, thierry.reding@gmail.com,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-pwm@vger.kernel.org
Subject: Re: [PATCH v2 5/7] pwm: atmel-hlcdc: add compatible for SAM9X60 HLCDC's PWM
Date: Thu, 25 Apr 2019 09:31:32 +0100	[thread overview]
Message-ID: <20190425083132.GD14758@dell> (raw)
In-Reply-To: <1551780434-4580-6-git-send-email-claudiu.beznea@microchip.com>

On Tue, 05 Mar 2019, Claudiu.Beznea@microchip.com wrote:

> From: Claudiu Beznea <claudiu.beznea@microchip.com>
> 
> Add compatible string for SAM9X60 HLCDC's PWM.
> 
> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
> Acked-by: Thierry Reding <thierry.reding@gmail.com>
> ---
>  drivers/pwm/pwm-atmel-hlcdc.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/pwm/pwm-atmel-hlcdc.c b/drivers/pwm/pwm-atmel-hlcdc.c
> index 54c6633d9b5d..331ca0233d9e 100644
> --- a/drivers/pwm/pwm-atmel-hlcdc.c
> +++ b/drivers/pwm/pwm-atmel-hlcdc.c
> @@ -246,6 +246,9 @@ static const struct of_device_id atmel_hlcdc_dt_ids[] = {
>  		.compatible = "atmel,sama5d4-hlcdc",
>  		.data = &atmel_hlcdc_pwm_sama5d3_errata,
>  	},
> +	{
> +		.compatible = "microchip,sam9x60-hlcdc",
> +	},

Please make this a single line entry, like the one below.

>  	{ /* sentinel */ },
>  };
>  MODULE_DEVICE_TABLE(of, atmel_hlcdc_dt_ids);

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Claudiu.Beznea@microchip.com
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
	alexandre.belloni@bootlin.com, bbrezillon@kernel.org,
	airlied@linux.ie, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org, Ludovic.Desroches@microchip.com,
	robh+dt@kernel.org, thierry.reding@gmail.com, daniel@ffwll.ch,
	linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 5/7] pwm: atmel-hlcdc: add compatible for SAM9X60 HLCDC's PWM
Date: Thu, 25 Apr 2019 09:31:32 +0100	[thread overview]
Message-ID: <20190425083132.GD14758@dell> (raw)
In-Reply-To: <1551780434-4580-6-git-send-email-claudiu.beznea@microchip.com>

On Tue, 05 Mar 2019, Claudiu.Beznea@microchip.com wrote:

> From: Claudiu Beznea <claudiu.beznea@microchip.com>
> 
> Add compatible string for SAM9X60 HLCDC's PWM.
> 
> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
> Acked-by: Thierry Reding <thierry.reding@gmail.com>
> ---
>  drivers/pwm/pwm-atmel-hlcdc.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/pwm/pwm-atmel-hlcdc.c b/drivers/pwm/pwm-atmel-hlcdc.c
> index 54c6633d9b5d..331ca0233d9e 100644
> --- a/drivers/pwm/pwm-atmel-hlcdc.c
> +++ b/drivers/pwm/pwm-atmel-hlcdc.c
> @@ -246,6 +246,9 @@ static const struct of_device_id atmel_hlcdc_dt_ids[] = {
>  		.compatible = "atmel,sama5d4-hlcdc",
>  		.data = &atmel_hlcdc_pwm_sama5d3_errata,
>  	},
> +	{
> +		.compatible = "microchip,sam9x60-hlcdc",
> +	},

Please make this a single line entry, like the one below.

>  	{ /* sentinel */ },
>  };
>  MODULE_DEVICE_TABLE(of, atmel_hlcdc_dt_ids);

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2019-04-25  8:31 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-05 10:07 [PATCH v2 0/7] add LCD support for SAM9X60 Claudiu.Beznea
2019-03-05 10:07 ` Claudiu.Beznea
2019-03-05 10:07 ` Claudiu.Beznea
2019-03-05 10:07 ` [PATCH v2 1/7] drm: atmel-hlcdc: add config option for clock selection Claudiu.Beznea
2019-03-05 10:07   ` Claudiu.Beznea
2019-03-05 10:07   ` Claudiu.Beznea
2019-03-05 10:07 ` [PATCH v2 2/7] drm: atmel-hlcdc: avoid initializing cfg with zero Claudiu.Beznea
2019-03-05 10:07   ` Claudiu.Beznea
2019-03-05 10:07   ` Claudiu.Beznea
2019-03-05 10:07 ` [PATCH v2 3/7] dt-bindings: mfd: add bindings for SAM9X60 HLCD controller Claudiu.Beznea
2019-03-05 10:07   ` Claudiu.Beznea
2019-03-05 10:07   ` Claudiu.Beznea
2019-03-12 18:44   ` Rob Herring
2019-03-12 18:44     ` Rob Herring
2019-03-12 18:44     ` Rob Herring
2019-04-02  4:17   ` Lee Jones
2019-04-02  4:17     ` Lee Jones
2019-03-05 10:07 ` [PATCH v2 4/7] mfd: atmel-hlcdc: add compatible " Claudiu.Beznea
2019-03-05 10:07   ` Claudiu.Beznea
2019-03-05 10:07   ` Claudiu.Beznea
2019-04-02  4:17   ` Lee Jones
2019-04-02  4:17     ` Lee Jones
2019-03-05 10:07 ` [PATCH v2 5/7] pwm: atmel-hlcdc: add compatible for SAM9X60 HLCDC's PWM Claudiu.Beznea
2019-03-05 10:07   ` Claudiu.Beznea
2019-03-05 10:07   ` Claudiu.Beznea
2019-04-24  8:12   ` Claudiu.Beznea
2019-04-24  8:12     ` Claudiu.Beznea
2019-04-24  8:12     ` Claudiu.Beznea
2019-04-25  8:31   ` Lee Jones [this message]
2019-04-25  8:31     ` Lee Jones
2019-03-05 10:08 ` [PATCH v2 6/7] drm: atmel-hlcdc: enable sys_clk during initalization Claudiu.Beznea
2019-03-05 10:08   ` Claudiu.Beznea
2019-03-05 10:08   ` Claudiu.Beznea
2019-03-05 10:08 ` [PATCH v2 7/7] drm: atmel-hlcdc: add sam9x60 LCD controller Claudiu.Beznea
2019-03-05 10:08   ` Claudiu.Beznea
2019-03-05 10:08   ` Claudiu.Beznea

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190425083132.GD14758@dell \
    --to=lee.jones@linaro.org \
    --cc=Claudiu.Beznea@microchip.com \
    --cc=Ludovic.Desroches@microchip.com \
    --cc=Nicolas.Ferre@microchip.com \
    --cc=airlied@linux.ie \
    --cc=alexandre.belloni@bootlin.com \
    --cc=bbrezillon@kernel.org \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.