From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: andriy.shevchenko@linux.intel.com, linus.walleij@linaro.org,
hotwater438@tutanota.com, hdegoede@redhat.com,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pinctrl: intel: Clear interrupt status in unmask callback
Date: Thu, 25 Apr 2019 12:11:40 +0300 [thread overview]
Message-ID: <20190425091140.GS2654@lahna.fi.intel.com> (raw)
In-Reply-To: <20190422044539.16085-1-kai.heng.feng@canonical.com>
On Mon, Apr 22, 2019 at 12:45:39PM +0800, Kai-Heng Feng wrote:
> Commit a939bb57cd47 ("pinctrl: intel: implement gpio_irq_enable") was
> added because clearing interrupt status bit is required to avoid
> unexpected behavior.
>
> Turns out the unmask callback also needs the fix, which can solve weird
> IRQ triggering issues on I2C touchpad ELAN1200.
>
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
next prev parent reply other threads:[~2019-04-25 9:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-22 4:45 [PATCH] pinctrl: intel: Clear interrupt status in unmask callback Kai-Heng Feng
[not found] ` <Ld5HCy5--3-1@tutanota.com>
2019-04-23 4:57 ` Kai-Heng Feng
[not found] ` <Ld8QGex--3-1@tutanota.com>
2019-04-23 9:08 ` Mika Westerberg
[not found] ` <Ld8ZLG1--3-1@tutanota.com>
2019-04-23 9:47 ` Kai-Heng Feng
[not found] ` <Ld9SLAo--3-1@tutanota.com>
2019-04-25 5:16 ` Kai Heng Feng
2019-04-25 9:11 ` Mika Westerberg [this message]
2019-04-26 21:47 ` Andy Shevchenko
2019-04-29 9:16 ` Kai-Heng Feng
2019-04-29 13:13 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190425091140.GS2654@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=hotwater438@tutanota.com \
--cc=kai.heng.feng@canonical.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.