[U-Boot] [RESEND PATCH 1/2] net: rtl8169: Implement ->hwaddr_write() callback

[U-Boot] [RESEND PATCH 1/2] net: rtl8169: Implement ->hwaddr_write() callback

[Thierry Reding]

From: Thierry Reding <treding@nvidia.com>

Implement this callback that allows the MAC address to be set for the
Ethernet card. This is necessary in order for the device to be able to
receive packets for the MAC address that U-Boot advertises.

Signed-off-by: Thierry Reding <treding@nvidia.com>
---
 drivers/net/rtl8169.c | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/drivers/net/rtl8169.c b/drivers/net/rtl8169.c
index a78f3d233f1a..27e27b34176b 100644
--- a/drivers/net/rtl8169.c
+++ b/drivers/net/rtl8169.c
@@ -941,6 +941,23 @@ static void rtl_halt(struct eth_device *dev)
 }
 #endif
 
+#ifdef CONFIG_DM_ETH
+static int rtl8169_write_hwaddr(struct udevice *dev)
+{
+	struct eth_pdata *plat = dev_get_platdata(dev);
+	unsigned int i;
+
+	RTL_W8(Cfg9346, Cfg9346_Unlock);
+
+	for (i = 0; i < MAC_ADDR_LEN; i++)
+		RTL_W8(MAC0 + i, plat->enetaddr[i]);
+
+	RTL_W8(Cfg9346, Cfg9346_Lock);
+
+	return 0;
+}
+#endif
+
 /**************************************************************************
 INIT - Look for an adapter, this routine's visible to the outside
 ***************************************************************************/
@@ -1195,6 +1212,7 @@ static const struct eth_ops rtl8169_eth_ops = {
 	.send	= rtl8169_eth_send,
 	.recv	= rtl8169_eth_recv,
 	.stop	= rtl8169_eth_stop,
+	.write_hwaddr = rtl8169_write_hwaddr,
 };
 
 static const struct udevice_id rtl8169_eth_ids[] = {
-- 
2.21.0

[U-Boot] [RESEND PATCH 2/2] net: rtl8169: Support RTL-8168h/8111h

[Thierry Reding]

From: Thierry Reding <treding@nvidia.com>

This version of the RTL-8168 is present on some development boards and
is compatible with this driver. Add support for identifying this version
of the chip so that U-Boot won't complain about it being unknown.

Signed-off-by: Thierry Reding <treding@nvidia.com>
---
 drivers/net/rtl8169.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/rtl8169.c b/drivers/net/rtl8169.c
index 27e27b34176b..bc052e72564b 100644
--- a/drivers/net/rtl8169.c
+++ b/drivers/net/rtl8169.c
@@ -257,6 +257,7 @@ static struct {
 	{"RTL-8168/8111g",	0x4c, 0xff7e1880,},
 	{"RTL-8101e",		0x34, 0xff7e1880,},
 	{"RTL-8100e",		0x32, 0xff7e1880,},
+	{"RTL-8168h/8111h",	0x54, 0xff7e1880,},
 };
 
 enum _DescStatusBit {
-- 
2.21.0

[U-Boot] [RESEND PATCH 2/2] net: rtl8169: Support RTL-8168h/8111h

[Joe Hershberger]

On Tue, Apr 16, 2019 at 11:21 AM Thierry Reding
<thierry.reding@gmail.com> wrote:
>
> From: Thierry Reding <treding@nvidia.com>
>
> This version of the RTL-8168 is present on some development boards and
> is compatible with this driver. Add support for identifying this version
> of the chip so that U-Boot won't complain about it being unknown.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>

Acked-by: Joe Hershberger <joe.hershberger@ni.com>

[U-Boot] net: rtl8169: Support RTL-8168h/8111h

[Joe Hershberger]

Hi Thierry,

https://patchwork.ozlabs.org/patch/1086412/ was applied to http://git.denx.de/?p=u-boot/u-boot-net.git

Thanks!
-Joe

[U-Boot] [RESEND PATCH 1/2] net: rtl8169: Implement ->hwaddr_write() callback

[Joe Hershberger]

On Tue, Apr 16, 2019 at 11:21 AM Thierry Reding
<thierry.reding@gmail.com> wrote:
>
> From: Thierry Reding <treding@nvidia.com>
>
> Implement this callback that allows the MAC address to be set for the
> Ethernet card. This is necessary in order for the device to be able to
> receive packets for the MAC address that U-Boot advertises.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>

Acked-by: Joe Hershberger <joe.hershberger@ni.com>

[U-Boot] [RESEND PATCH 1/2] net: rtl8169: Implement ->hwaddr_write() callback

[Thierry Reding]

On Tue, Apr 16, 2019 at 04:36:16PM +0000, Joe Hershberger wrote:
> On Tue, Apr 16, 2019 at 11:21 AM Thierry Reding
> <thierry.reding@gmail.com> wrote:
> >
> > From: Thierry Reding <treding@nvidia.com>
> >
> > Implement this callback that allows the MAC address to be set for the
> > Ethernet card. This is necessary in order for the device to be able to
> > receive packets for the MAC address that U-Boot advertises.
> >
> > Signed-off-by: Thierry Reding <treding@nvidia.com>
> 
> Acked-by: Joe Hershberger <joe.hershberger@ni.com>

Hi Joe,

it's not clear to me who you expect to pick this (and patch 2/2) up. I
didn't Cc anyone, so nobody else may consider themselves responsible for
these.

Did you mean to pick these up yourself or should they go via Simon's DT
tree along with the two eth-uclass patches that I sent? Or perhaps TomR
handles these patches directly? MAINTAINERS clearly identifies you as a
maintainer for the u-boot-net tree, so I was expecting you to pick them
up. Let me know if I should resend these to someone else with your
Acked-by.

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190425/cd565e00/attachment.sig>

[U-Boot] [RESEND PATCH 1/2] net: rtl8169: Implement ->hwaddr_write() callback

[Joe Hershberger]

Hi Thierry,

On Thu, Apr 25, 2019 at 8:32 AM Thierry Reding <thierry.reding@gmail.com> wrote:
>
> On Tue, Apr 16, 2019 at 04:36:16PM +0000, Joe Hershberger wrote:
> > On Tue, Apr 16, 2019 at 11:21 AM Thierry Reding
> > <thierry.reding@gmail.com> wrote:
> > >
> > > From: Thierry Reding <treding@nvidia.com>
> > >
> > > Implement this callback that allows the MAC address to be set for the
> > > Ethernet card. This is necessary in order for the device to be able to
> > > receive packets for the MAC address that U-Boot advertises.
> > >
> > > Signed-off-by: Thierry Reding <treding@nvidia.com>
> >
> > Acked-by: Joe Hershberger <joe.hershberger@ni.com>
>
> Hi Joe,
>
> it's not clear to me who you expect to pick this (and patch 2/2) up. I
> didn't Cc anyone, so nobody else may consider themselves responsible for
> these.
>
> Did you mean to pick these up yourself or should they go via Simon's DT
> tree along with the two eth-uclass patches that I sent? Or perhaps TomR
> handles these patches directly? MAINTAINERS clearly identifies you as a
> maintainer for the u-boot-net tree, so I was expecting you to pick them
> up. Let me know if I should resend these to someone else with your
> Acked-by.

Yes, I expect to pick these through my tree, but there are two
circumstances slowing that. One is that the last series I pulled into
my tree included a breaking change, and Tom asked me to identify that
patch and reject it. That means I need to reproduce it. That leads to
the next problem... I've been travelling most of this month and
haven't reproduced the issue yet. When I get my tree unclogged, I'll
be pulling these patches as well as all others Acked and delegated to
me in patchwork.

Cheers,
-Joe

[U-Boot] [RESEND PATCH 1/2] net: rtl8169: Implement ->hwaddr_write() callback

[Joe Hershberger]

Hi Thierry,

On Thu, Apr 25, 2019 at 8:32 AM Thierry Reding <thierry.reding@gmail.com> wrote:
>
> On Tue, Apr 16, 2019 at 04:36:16PM +0000, Joe Hershberger wrote:
> > On Tue, Apr 16, 2019 at 11:21 AM Thierry Reding
> > <thierry.reding@gmail.com> wrote:
> > >
> > > From: Thierry Reding <treding@nvidia.com>
> > >
> > > Implement this callback that allows the MAC address to be set for the
> > > Ethernet card. This is necessary in order for the device to be able to
> > > receive packets for the MAC address that U-Boot advertises.
> > >
> > > Signed-off-by: Thierry Reding <treding@nvidia.com>
> >
> > Acked-by: Joe Hershberger <joe.hershberger@ni.com>
>
> Hi Joe,
>
> it's not clear to me who you expect to pick this (and patch 2/2) up. I
> didn't Cc anyone, so nobody else may consider themselves responsible for
> these.
>
> Did you mean to pick these up yourself or should they go via Simon's DT
> tree along with the two eth-uclass patches that I sent? Or perhaps TomR
> handles these patches directly? MAINTAINERS clearly identifies you as a
> maintainer for the u-boot-net tree, so I was expecting you to pick them
> up. Let me know if I should resend these to someone else with your
> Acked-by.

I just sent a new PR [1] that Tom should accept soon. I'll be pulling
in your patches as well as other remaining Acked patches tomorrow to
start build testing.

Sorry for the inconvenience. It was a bear to track down.

-Joe

[1] - https://patchwork.ozlabs.org/patch/1097270/

[U-Boot] net: rtl8169: Implement ->hwaddr_write() callback

[Joe Hershberger]

Hi Thierry,

https://patchwork.ozlabs.org/patch/1086411/ was applied to http://git.denx.de/?p=u-boot/u-boot-net.git

Thanks!
-Joe