All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@gmail.com>
To: Felipe Balbi <balbi@kernel.org>
Cc: Nagarjuna Kristam <nkristam@nvidia.com>,
	gregkh@linuxfoundation.org, jonathanh@nvidia.com,
	linux-tegra@vger.kernel.org, linux-usb@vger.kernel.org
Subject: [V2,7/8] usb: gadget: Add UDC driver for tegra XUSB device mode controller
Date: Thu, 25 Apr 2019 15:55:01 +0200	[thread overview]
Message-ID: <20190425135501.GA24213@ulmo> (raw)

On Thu, Apr 25, 2019 at 04:00:05PM +0300, Felipe Balbi wrote:
> Nagarjuna Kristam <nkristam@nvidia.com> writes:
> 
> > This patch adds UDC driver for tegra XUSB 3.0 device mode controller.
> > XUSB device mode controller support SS, HS and FS modes
> >
> > Based on work by:
> >   Mark Kuo <mkuo@nvidia.com>
> >   Andrew Bresticker <abrestic@chromium.org>
> >
> > Signed-off-by: Nagarjuna Kristam <nkristam@nvidia.com>
> > ---
> >  drivers/usb/gadget/udc/Kconfig      |   10 +
> >  drivers/usb/gadget/udc/Makefile     |    1 +
> >  drivers/usb/gadget/udc/tegra_xudc.c | 3702 +++++++++++++++++++++++++++++++++++
> >  3 files changed, 3713 insertions(+)
> >  create mode 100644 drivers/usb/gadget/udc/tegra_xudc.c
> >
> > diff --git a/drivers/usb/gadget/udc/Kconfig b/drivers/usb/gadget/udc/Kconfig
> > index 0a16cbd..f6f469c 100644
> > --- a/drivers/usb/gadget/udc/Kconfig
> > +++ b/drivers/usb/gadget/udc/Kconfig
> > @@ -439,6 +439,16 @@ config USB_GADGET_XILINX
> >  	  dynamically linked module called "udc-xilinx" and force all
> >  	  gadget drivers to also be dynamically linked.
> >  
> > +config USB_TEGRA_XUDC
> > +	tristate "NVIDIA Superspeed USB 3.0 Device Controller"
> > +	depends on ARCH_TEGRA
> 
> no compile_test?

That's not possible right now. The driver depends on functions that
don't have dummy implementations to support COMPILE_TEST. I suppose
that's something that we could change, but does it need to be part
of this initial submission?

On that note:

Nagarjuna, I think we have PHY_TEGRA_XUSB as at least one other
dependency. Without that the driver could be enabled but fail to link
because of the missing implementations that that driver would've
provided.

Thierry

WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@gmail.com>
To: Felipe Balbi <balbi@kernel.org>
Cc: Nagarjuna Kristam <nkristam@nvidia.com>,
	gregkh@linuxfoundation.org, jonathanh@nvidia.com,
	linux-tegra@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH V2 7/8] usb: gadget: Add UDC driver for tegra XUSB device mode controller
Date: Thu, 25 Apr 2019 15:55:01 +0200	[thread overview]
Message-ID: <20190425135501.GA24213@ulmo> (raw)
Message-ID: <20190425135501.CrHpfthIx57IgV4uHvuXBNIwrLw6Nd7Gk6S8Xdo2B8g@z> (raw)
In-Reply-To: <87bm0us0iy.fsf@linux.intel.com>

[-- Attachment #1: Type: text/plain, Size: 1740 bytes --]

On Thu, Apr 25, 2019 at 04:00:05PM +0300, Felipe Balbi wrote:
> Nagarjuna Kristam <nkristam@nvidia.com> writes:
> 
> > This patch adds UDC driver for tegra XUSB 3.0 device mode controller.
> > XUSB device mode controller support SS, HS and FS modes
> >
> > Based on work by:
> >   Mark Kuo <mkuo@nvidia.com>
> >   Andrew Bresticker <abrestic@chromium.org>
> >
> > Signed-off-by: Nagarjuna Kristam <nkristam@nvidia.com>
> > ---
> >  drivers/usb/gadget/udc/Kconfig      |   10 +
> >  drivers/usb/gadget/udc/Makefile     |    1 +
> >  drivers/usb/gadget/udc/tegra_xudc.c | 3702 +++++++++++++++++++++++++++++++++++
> >  3 files changed, 3713 insertions(+)
> >  create mode 100644 drivers/usb/gadget/udc/tegra_xudc.c
> >
> > diff --git a/drivers/usb/gadget/udc/Kconfig b/drivers/usb/gadget/udc/Kconfig
> > index 0a16cbd..f6f469c 100644
> > --- a/drivers/usb/gadget/udc/Kconfig
> > +++ b/drivers/usb/gadget/udc/Kconfig
> > @@ -439,6 +439,16 @@ config USB_GADGET_XILINX
> >  	  dynamically linked module called "udc-xilinx" and force all
> >  	  gadget drivers to also be dynamically linked.
> >  
> > +config USB_TEGRA_XUDC
> > +	tristate "NVIDIA Superspeed USB 3.0 Device Controller"
> > +	depends on ARCH_TEGRA
> 
> no compile_test?

That's not possible right now. The driver depends on functions that
don't have dummy implementations to support COMPILE_TEST. I suppose
that's something that we could change, but does it need to be part
of this initial submission?

On that note:

Nagarjuna, I think we have PHY_TEGRA_XUSB as at least one other
dependency. Without that the driver could be enabled but fail to link
because of the missing implementations that that driver would've
provided.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

         reply	other threads:[~2019-04-25 13:55 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1552302716-18554-1-git-send-email-nkristam@nvidia.com>
2019-03-11 11:11 ` [V2,2/8] phy: tegra: xusb: t210: add usb3 port fake support Nagarjuna Kristam
2019-04-25 14:55   ` Thierry Reding
2019-04-25 14:55     ` [PATCH V2 2/8] " Thierry Reding
2019-05-08  9:35     ` Nagarjuna Kristam
2019-03-11 11:11 ` [V2,3/8] phy: tegra: xusb: t210: add vbus override support Nagarjuna Kristam
2019-04-25 15:04   ` Thierry Reding
2019-04-25 15:04     ` [PATCH V2 3/8] " Thierry Reding
2019-05-08 10:21     ` Nagarjuna Kristam
2019-03-11 11:11 ` [V2,4/8] dt-bindings: usb: Add NVIDIA Tegra XUSB device mode controller binding Nagarjuna Kristam
2019-04-25 15:14   ` Thierry Reding
2019-04-25 15:14     ` [PATCH V2 4/8] " Thierry Reding
2019-05-03 14:30     ` [V2,4/8] " Thierry Reding
2019-05-03 14:30       ` [PATCH V2 4/8] " Thierry Reding
2019-05-08 10:51       ` Nagarjuna Kristam
2019-03-11 11:11 ` [V2,7/8] usb: gadget: Add UDC driver for tegra XUSB device mode controller Nagarjuna Kristam
2019-04-25 13:00   ` Felipe Balbi
2019-04-25 13:00     ` [PATCH V2 7/8] " Felipe Balbi
2019-04-25 13:55     ` Thierry Reding [this message]
2019-04-25 13:55       ` Thierry Reding
2019-05-07 10:09       ` Nagarjuna Kristam
2019-05-03 14:22 [V2,7/8] " Thierry Reding
2019-05-03 14:22 ` [PATCH V2 7/8] " Thierry Reding
  -- strict thread matches above, loose matches on Subject: below --
2019-04-25 14:13 [V2,1/8] phy: tegra: xusb: t210: add XUSB dual mode support Thierry Reding
2019-04-25 14:13 ` [PATCH V2 1/8] " Thierry Reding
2019-04-25 13:57 [V2,4/8] dt-bindings: usb: Add NVIDIA Tegra XUSB device mode controller binding Thierry Reding
2019-04-25 13:57 ` [PATCH V2 4/8] " Thierry Reding
2019-03-11 11:11 [V2,1/8] phy: tegra: xusb: t210: add XUSB dual mode support Nagarjuna Kristam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190425135501.GA24213@ulmo \
    --to=thierry.reding@gmail.com \
    --cc=balbi@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jonathanh@nvidia.com \
    --cc=linux-tegra@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=nkristam@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.