From: Kalle Valo <kvalo@codeaurora.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Amitkumar Karwar <amitkarwar@gmail.com>,
Xinming Hu <huxm@marvell.com>,
Nishant Sarmukadam <nishants@marvell.com>,
Ganapathi Bhat <gbhat@marvell.com>,
linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] mwifiex: prevent an array overflow
Date: Thu, 25 Apr 2019 16:50:46 +0000 [thread overview]
Message-ID: <20190425165046.EBF8160388@smtp.codeaurora.org> (raw)
In-Reply-To: <20190404084423.GB20193@kadam>
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> The "rate_index" is only used as an index into the phist_data->rx_rate[]
> array in the mwifiex_hist_data_set() function. That array has
> MWIFIEX_MAX_AC_RX_RATES (74) elements and it's used to generate some
> debugfs information. The "rate_index" variable comes from the network
> skb->data[] and it is a u8 so it's in the 0-255 range. We need to cap
> it to prevent an array overflow.
>
> Fixes: cbf6e05527a7 ("mwifiex: add rx histogram statistics support")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Patch applied to wireless-drivers-next.git, thanks.
b4c35c17227f mwifiex: prevent an array overflow
--
https://patchwork.kernel.org/patch/10885297/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Amitkumar Karwar <amitkarwar@gmail.com>,
Xinming Hu <huxm@marvell.com>,
Nishant Sarmukadam <nishants@marvell.com>,
Ganapathi Bhat <gbhat@marvell.com>,
linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] mwifiex: prevent an array overflow
Date: Thu, 25 Apr 2019 16:50:46 +0000 (UTC) [thread overview]
Message-ID: <20190425165046.EBF8160388@smtp.codeaurora.org> (raw)
In-Reply-To: <20190404084423.GB20193@kadam>
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> The "rate_index" is only used as an index into the phist_data->rx_rate[]
> array in the mwifiex_hist_data_set() function. That array has
> MWIFIEX_MAX_AC_RX_RATES (74) elements and it's used to generate some
> debugfs information. The "rate_index" variable comes from the network
> skb->data[] and it is a u8 so it's in the 0-255 range. We need to cap
> it to prevent an array overflow.
>
> Fixes: cbf6e05527a7 ("mwifiex: add rx histogram statistics support")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Patch applied to wireless-drivers-next.git, thanks.
b4c35c17227f mwifiex: prevent an array overflow
--
https://patchwork.kernel.org/patch/10885297/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2019-04-25 16:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-04 8:44 [PATCH] mwifiex: prevent an array overflow Dan Carpenter
2019-04-04 8:44 ` Dan Carpenter
2019-04-25 16:50 ` Kalle Valo [this message]
2019-04-25 16:50 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190425165046.EBF8160388@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=amitkarwar@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=gbhat@marvell.com \
--cc=huxm@marvell.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=nishants@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.