From: Joerg Roedel <joro@8bytes.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: "Benjamin Herrenschmidt" <benh@kernel.crashing.org>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Oded Gabbay" <oded.gabbay@gmail.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"David (ChunMing) Zhou" <David1.Zhou@amd.com>,
"David Airlie" <airlied@linux.ie>,
"Daniel Vetter" <daniel@ffwll.ch>,
"David Woodhouse" <dwmw2@infradead.org>,
"Realtek linux nic maintainers" <nic_swsd@realtek.com>,
"David S. Miller" <davem@davemloft.net>,
"Giuseppe Cavallaro" <peppe.cavallaro@st.com>,
"Alexandre Torgue" <alexandre.torgue@st.com>,
"Jose Abreu" <joabreu@synopsys.com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Benson Leung" <bleung@chromium.org>
Subject: Re: [PATCH v2 6/9] iommu/amd: use helper pci_dev_id
Date: Fri, 26 Apr 2019 15:47:10 +0200 [thread overview]
Message-ID: <20190426134710.GD24576@8bytes.org> (raw)
In-Reply-To: <f673e8ac-cc9a-75a6-09b8-35b94bfc868b@gmail.com>
On Wed, Apr 24, 2019 at 09:15:25PM +0200, Heiner Kallweit wrote:
> Use new helper pci_dev_id() to simplify the code.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Joerg Roedel <jroedel@suse.de>
> ---
> drivers/iommu/amd_iommu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c
> index f467cc4b4..5cb201422 100644
> --- a/drivers/iommu/amd_iommu.c
> +++ b/drivers/iommu/amd_iommu.c
> @@ -165,7 +165,7 @@ static inline u16 get_pci_device_id(struct device *dev)
> {
> struct pci_dev *pdev = to_pci_dev(dev);
>
> - return PCI_DEVID(pdev->bus->number, pdev->devfn);
> + return pci_dev_id(pdev);
> }
>
> static inline int get_acpihid_device_id(struct device *dev,
> --
> 2.21.0
>
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: "David Airlie" <airlied@linux.ie>,
"Benjamin Herrenschmidt" <benh@kernel.crashing.org>,
"open list:AMD KFD" <dri-devel@lists.freedesktop.org>,
"Paul Mackerras" <paulus@samba.org>,
"moderated list:ARM/STM32 ARCHITECTURE"
<linux-stm32@st-md-mailman.stormreply.com>,
"David (ChunMing) Zhou" <David1.Zhou@amd.com>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"open list:RADEON and AMDGPU DRM DRIVERS"
<amd-gfx@lists.freedesktop.org>,
"Jose Abreu" <joabreu@synopsys.com>,
"open list:PCI SUBSYSTEM" <linux-pci@vger.kernel.org>,
"Realtek linux nic maintainers" <nic_swsd@realtek.com>,
"Alexandre Torgue" <alexandre.torgue@st.com>,
"Stephen Rothwell" <sfr@canb.auug.org.au>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Giuseppe Cavallaro" <peppe.cavallaro@st.com>,
"Benson Leung" <bleung@chromium.org>,
"moderated list:ARM/STM32 ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"open list:8169 10/100/1000 GIGABIT ETHERNET DRIVER"
<netdev@vger.kernel.org>,
"open list" <linux-kernel@vger.kernel.org>,
"Christian König" <christian.koenig@amd.com>,
"open list:AMD IOMMU (AMD-VI)" <iommu@lists.linux-foundation.org>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Enric Balletbo i Serra" <enric.balletbo@collabora.com>,
"David Woodhouse" <dwmw2@infradead.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH v2 6/9] iommu/amd: use helper pci_dev_id
Date: Fri, 26 Apr 2019 15:47:10 +0200 [thread overview]
Message-ID: <20190426134710.GD24576@8bytes.org> (raw)
Message-ID: <20190426134710.9HxKT61YHN7lxwCISmq9AgBWTBO9CnKVtRipcbbnd-4@z> (raw)
In-Reply-To: <f673e8ac-cc9a-75a6-09b8-35b94bfc868b@gmail.com>
On Wed, Apr 24, 2019 at 09:15:25PM +0200, Heiner Kallweit wrote:
> Use new helper pci_dev_id() to simplify the code.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Joerg Roedel <jroedel@suse.de>
> ---
> drivers/iommu/amd_iommu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c
> index f467cc4b4..5cb201422 100644
> --- a/drivers/iommu/amd_iommu.c
> +++ b/drivers/iommu/amd_iommu.c
> @@ -165,7 +165,7 @@ static inline u16 get_pci_device_id(struct device *dev)
> {
> struct pci_dev *pdev = to_pci_dev(dev);
>
> - return PCI_DEVID(pdev->bus->number, pdev->devfn);
> + return pci_dev_id(pdev);
> }
>
> static inline int get_acpihid_device_id(struct device *dev,
> --
> 2.21.0
>
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: "Benjamin Herrenschmidt" <benh@kernel.crashing.org>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Oded Gabbay" <oded.gabbay@gmail.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"David (ChunMing) Zhou" <David1.Zhou@amd.com>,
"David Airlie" <airlied@linux.ie>,
"Daniel Vetter" <daniel@ffwll.ch>,
"David Woodhouse" <dwmw2@infradead.org>,
"Realtek linux nic maintainers" <nic_swsd@realtek.com>,
"David S. Miller" <davem@davemloft.net>,
"Giuseppe Cavallaro" <peppe.cavallaro@st.com>,
"Alexandre Torgue" <alexandre.torgue@st.com>,
"Jose Abreu" <joabreu@synopsys.com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Benson Leung" <bleung@chromium.org>,
"Enric Balletbo i Serra" <enric.balletbo@collabora.com>,
"Stephen Rothwell" <sfr@canb.auug.org.au>,
"Paul Mackerras" <paulus@samba.org>,
"open list" <linux-kernel@vger.kernel.org>,
"open list:AMD KFD" <dri-devel@lists.freedesktop.org>,
"open list:RADEON and AMDGPU DRM DRIVERS"
<amd-gfx@lists.freedesktop.org>,
"open list:AMD IOMMU (AMD-VI)" <iommu@lists.linux-foundation.org>,
"open list:8169 10/100/1000 GIGABIT ETHERNET DRIVER"
<netdev@vger.kernel.org>,
"moderated list:ARM/STM32 ARCHITECTURE"
<linux-stm32@st-md-mailman.stormreply.com>,
"moderated list:ARM/STM32 ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
"open list:PCI SUBSYSTEM" <linux-pci@vger.kernel.org>
Subject: Re: [PATCH v2 6/9] iommu/amd: use helper pci_dev_id
Date: Fri, 26 Apr 2019 15:47:10 +0200 [thread overview]
Message-ID: <20190426134710.GD24576@8bytes.org> (raw)
In-Reply-To: <f673e8ac-cc9a-75a6-09b8-35b94bfc868b@gmail.com>
On Wed, Apr 24, 2019 at 09:15:25PM +0200, Heiner Kallweit wrote:
> Use new helper pci_dev_id() to simplify the code.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Joerg Roedel <jroedel@suse.de>
> ---
> drivers/iommu/amd_iommu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c
> index f467cc4b4..5cb201422 100644
> --- a/drivers/iommu/amd_iommu.c
> +++ b/drivers/iommu/amd_iommu.c
> @@ -165,7 +165,7 @@ static inline u16 get_pci_device_id(struct device *dev)
> {
> struct pci_dev *pdev = to_pci_dev(dev);
>
> - return PCI_DEVID(pdev->bus->number, pdev->devfn);
> + return pci_dev_id(pdev);
> }
>
> static inline int get_acpihid_device_id(struct device *dev,
> --
> 2.21.0
>
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: "David Airlie" <airlied@linux.ie>,
"Benjamin Herrenschmidt" <benh@kernel.crashing.org>,
"open list:AMD KFD" <dri-devel@lists.freedesktop.org>,
"Paul Mackerras" <paulus@samba.org>,
"moderated list:ARM/STM32 ARCHITECTURE"
<linux-stm32@st-md-mailman.stormreply.com>,
"David (ChunMing) Zhou" <David1.Zhou@amd.com>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"open list:RADEON and AMDGPU DRM DRIVERS"
<amd-gfx@lists.freedesktop.org>,
"Jose Abreu" <joabreu@synopsys.com>,
"open list:PCI SUBSYSTEM" <linux-pci@vger.kernel.org>,
"Realtek linux nic maintainers" <nic_swsd@realtek.com>,
"Alexandre Torgue" <alexandre.torgue@st.com>,
"Stephen Rothwell" <sfr@canb.auug.org.au>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Giuseppe Cavallaro" <peppe.cavallaro@st.com>,
"Benson Leung" <bleung@chromium.org>,
"moderated list:ARM/STM32 ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
"Oded Gabbay" <oded.gabbay@gmail.com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"open list:8169 10/100/1000 GIGABIT ETHERNET DRIVER"
<netdev@vger.kernel.org>,
"open list" <linux-kernel@vger.kernel.org>,
"Christian König" <christian.koenig@amd.com>,
"open list:AMD IOMMU (AMD-VI)" <iommu@lists.linux-foundation.org>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Enric Balletbo i Serra" <enric.balletbo@collabora.com>,
"David Woodhouse" <dwmw2@infradead.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH v2 6/9] iommu/amd: use helper pci_dev_id
Date: Fri, 26 Apr 2019 15:47:10 +0200 [thread overview]
Message-ID: <20190426134710.GD24576@8bytes.org> (raw)
In-Reply-To: <f673e8ac-cc9a-75a6-09b8-35b94bfc868b@gmail.com>
On Wed, Apr 24, 2019 at 09:15:25PM +0200, Heiner Kallweit wrote:
> Use new helper pci_dev_id() to simplify the code.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Joerg Roedel <jroedel@suse.de>
> ---
> drivers/iommu/amd_iommu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c
> index f467cc4b4..5cb201422 100644
> --- a/drivers/iommu/amd_iommu.c
> +++ b/drivers/iommu/amd_iommu.c
> @@ -165,7 +165,7 @@ static inline u16 get_pci_device_id(struct device *dev)
> {
> struct pci_dev *pdev = to_pci_dev(dev);
>
> - return PCI_DEVID(pdev->bus->number, pdev->devfn);
> + return pci_dev_id(pdev);
> }
>
> static inline int get_acpihid_device_id(struct device *dev,
> --
> 2.21.0
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-04-26 13:47 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-24 19:10 [PATCH v2 0/9] PCI: add help pci_dev_id Heiner Kallweit
2019-04-24 19:10 ` Heiner Kallweit
2019-04-24 19:10 ` Heiner Kallweit
2019-04-24 19:10 ` Heiner Kallweit
2019-04-24 19:11 ` [PATCH v2 1/9] PCI: add helper pci_dev_id Heiner Kallweit
2019-04-24 19:11 ` Heiner Kallweit
2019-04-24 19:11 ` Heiner Kallweit
2019-04-24 19:11 ` Heiner Kallweit
2019-04-24 19:12 ` [PATCH v2 2/9] PCI: use " Heiner Kallweit
2019-04-24 19:12 ` Heiner Kallweit
2019-04-24 19:12 ` Heiner Kallweit
2019-04-24 19:12 ` Heiner Kallweit
2019-04-24 19:13 ` [PATCH v2 3/9] r8169: use new " Heiner Kallweit
2019-04-24 19:13 ` Heiner Kallweit
2019-04-24 19:13 ` Heiner Kallweit
2019-04-24 19:13 ` Heiner Kallweit
2019-04-24 19:14 ` [PATCH v2 4/9] powerpc/powernv/npu: use " Heiner Kallweit
2019-04-24 19:14 ` Heiner Kallweit
2019-04-24 19:14 ` Heiner Kallweit
2019-04-24 19:14 ` Heiner Kallweit
2019-04-26 3:44 ` Alexey Kardashevskiy
2019-04-26 3:44 ` Alexey Kardashevskiy
2019-04-26 3:44 ` Alexey Kardashevskiy
2019-04-26 3:44 ` Alexey Kardashevskiy
2019-04-24 19:14 ` [PATCH v2 5/9] drm/amdkfd: " Heiner Kallweit
2019-04-24 19:14 ` Heiner Kallweit
2019-04-24 19:14 ` Heiner Kallweit
2019-04-24 19:14 ` Heiner Kallweit
[not found] ` <50613002-d5a2-2522-b183-4ab156686fce-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-04-25 6:57 ` Koenig, Christian
2019-04-25 6:57 ` Koenig, Christian
2019-04-25 6:57 ` Koenig, Christian
2019-04-25 6:57 ` Koenig, Christian
2019-04-24 19:15 ` [PATCH v2 6/9] iommu/amd: " Heiner Kallweit
2019-04-24 19:15 ` Heiner Kallweit
2019-04-24 19:15 ` Heiner Kallweit
2019-04-24 19:15 ` Heiner Kallweit
2019-04-26 13:47 ` Joerg Roedel [this message]
2019-04-26 13:47 ` Joerg Roedel
2019-04-26 13:47 ` Joerg Roedel
2019-04-26 13:47 ` Joerg Roedel
2019-04-24 19:16 ` [PATCH v2 7/9] iommu/vt-d: " Heiner Kallweit
2019-04-24 19:16 ` Heiner Kallweit
2019-04-24 19:16 ` Heiner Kallweit
2019-04-24 19:16 ` Heiner Kallweit
2019-04-26 13:47 ` Joerg Roedel
2019-04-26 13:47 ` Joerg Roedel
2019-04-26 13:47 ` Joerg Roedel
2019-04-26 13:47 ` Joerg Roedel
2019-04-24 19:16 ` [PATCH v2 8/9] stmmac: pci: " Heiner Kallweit
2019-04-24 19:16 ` Heiner Kallweit
2019-04-24 19:16 ` Heiner Kallweit
2019-04-24 19:16 ` Heiner Kallweit
2019-04-24 19:17 ` [PATCH v2 9/9] platform/chrome: chromeos_laptop: " Heiner Kallweit
2019-04-24 19:17 ` Heiner Kallweit
2019-04-24 19:17 ` Heiner Kallweit
2019-04-24 19:17 ` Heiner Kallweit
[not found] ` <e882f58b-0808-952e-d293-5e8cc3f04c97-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-04-25 18:21 ` Benson Leung
2019-04-25 18:21 ` Benson Leung
2019-04-25 18:21 ` Benson Leung
2019-04-25 18:21 ` Benson Leung via iommu
[not found] ` <2e1f9a57-6d08-d017-24da-3e6b97fa2449-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-04-29 21:14 ` [PATCH v2 0/9] PCI: add help pci_dev_id Bjorn Helgaas
2019-04-29 21:14 ` Bjorn Helgaas
2019-04-29 21:14 ` Bjorn Helgaas
2019-04-29 21:14 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190426134710.GD24576@8bytes.org \
--to=joro@8bytes.org \
--cc=David1.Zhou@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=alexandre.torgue@st.com \
--cc=benh@kernel.crashing.org \
--cc=bhelgaas@google.com \
--cc=bleung@chromium.org \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=davem@davemloft.net \
--cc=dwmw2@infradead.org \
--cc=hkallweit1@gmail.com \
--cc=joabreu@synopsys.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=mpe@ellerman.id.au \
--cc=nic_swsd@realtek.com \
--cc=oded.gabbay@gmail.com \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.