* [PATCH] memorder: Fix two trivial typos
@ 2019-04-26 0:56 SeongJae Park
2019-04-26 0:57 ` [PATCH 1/5] toolsoftrade: Polish an ambiguous sentence SeongJae Park
` (4 more replies)
0 siblings, 5 replies; 7+ messages in thread
From: SeongJae Park @ 2019-04-26 0:56 UTC (permalink / raw)
To: paulmck; +Cc: perfbook, SeongJae Park
Signed-off-by: SeongJae Park <sj38.park@gmail.com>
---
memorder/memorder.tex | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/memorder/memorder.tex b/memorder/memorder.tex
index 1649ce9..bb380ad 100644
--- a/memorder/memorder.tex
+++ b/memorder/memorder.tex
@@ -3125,7 +3125,7 @@ Sections~\ref{sec:toolsoftrade:A Volatile Solution}-\ref{sec:toolsoftrade:Avoidi
cause the compiler to discard a previously loaded value from
its register, and then reload it later on.
Invented loads can be prevented by using \co{READ_ONCE()} or by
- enforcing ordering as callout out above between the load and a
+ enforcing ordering as called out above between the load and a
later use of its value using \co{barrier()}.
\item Stores can be invented before a plain store, for example, by
using the stored-to location as temporary storage.
@@ -3160,7 +3160,7 @@ optimizing your parallel algorithm out of existence.
Compilers are starting to provide other mechanisms for avoiding
load and store tearing, for example, \co{memory_order_relaxed}
atomic loads and stores, however, work is still
-needed~/\cite{JonathanCorbet2016C11atomics}
+needed~\cite{JonathanCorbet2016C11atomics}.
In addition, compiler issues aside, \co{volatile} is still needed
to avoid fusing and invention of accesses, including C11 atomic accesses.
--
2.10.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 1/5] toolsoftrade: Polish an ambiguous sentence
2019-04-26 0:56 [PATCH] memorder: Fix two trivial typos SeongJae Park
@ 2019-04-26 0:57 ` SeongJae Park
2019-04-26 14:17 ` Paul E. McKenney
2019-04-26 0:57 ` [PATCH 2/5] defer/rcupai: Fix a typo: _pointer()() -> _pointer() SeongJae Park
` (3 subsequent siblings)
4 siblings, 1 reply; 7+ messages in thread
From: SeongJae Park @ 2019-04-26 0:57 UTC (permalink / raw)
To: paulmck; +Cc: perfbook, SeongJae Park
A sentence calls a 'signal or interrupt handler' as 'interrupt handler'.
This commit modifies the sentence to call it just a handler to minimize
any confusion.
Signed-off-by: SeongJae Park <sj38.park@gmail.com>
---
toolsoftrade/toolsoftrade.tex | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/toolsoftrade/toolsoftrade.tex b/toolsoftrade/toolsoftrade.tex
index 4e0764d..1cf118b 100644
--- a/toolsoftrade/toolsoftrade.tex
+++ b/toolsoftrade/toolsoftrade.tex
@@ -2365,8 +2365,8 @@ for other accesses to that same variable:
All other code must use \co{READ_ONCE()} and \co{WRITE_ONCE()}.
\item A shared variable is only accessed by a given CPU or thread
and by a signal or interrupt handler running in that CPU's
- or thread's context, and the interrupt handler always restores
- the values of any variables that it has written before return.
+ or thread's context, and the handler always restores the values of any
+ variables that it has written before return.
The handler can use plain loads and stores, as can any code
that has prevented the handler from being invoked, that is,
code that has blocked signals and/or interrupts.
--
2.10.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/5] defer/rcupai: Fix a typo: _pointer()() -> _pointer()
2019-04-26 0:56 [PATCH] memorder: Fix two trivial typos SeongJae Park
2019-04-26 0:57 ` [PATCH 1/5] toolsoftrade: Polish an ambiguous sentence SeongJae Park
@ 2019-04-26 0:57 ` SeongJae Park
2019-04-26 0:57 ` [PATCH 3/5] defer/rcuapi: Consistently use dashes for 'RCU-protected' and 'update-side' SeongJae Park
` (2 subsequent siblings)
4 siblings, 0 replies; 7+ messages in thread
From: SeongJae Park @ 2019-04-26 0:57 UTC (permalink / raw)
To: paulmck; +Cc: perfbook, SeongJae Park
Signed-off-by: SeongJae Park <sj38.park@gmail.com>
---
defer/rcuapi.tex | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/defer/rcuapi.tex b/defer/rcuapi.tex
index 93b9767..6e014e0 100644
--- a/defer/rcuapi.tex
+++ b/defer/rcuapi.tex
@@ -570,7 +570,7 @@ Again, simply loading these pointers using C-language accesses
could result in seeing pre-initialization garbage in the pointed-to data.
However, if the pointer is merely to be tested and not dereferenced,
this protection is not needed.
-In this case, \co{rcu_access_pointer()()} may be used.
+In this case, \co{rcu_access_pointer()} may be used.
Normally, however, protection is required, and so the
\co{rcu_dereference()} primitive ensures that subsequent code
dereferencing the pointer will see the effects of initialization code
--
2.10.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 3/5] defer/rcuapi: Consistently use dashes for 'RCU-protected' and 'update-side'
2019-04-26 0:56 [PATCH] memorder: Fix two trivial typos SeongJae Park
2019-04-26 0:57 ` [PATCH 1/5] toolsoftrade: Polish an ambiguous sentence SeongJae Park
2019-04-26 0:57 ` [PATCH 2/5] defer/rcupai: Fix a typo: _pointer()() -> _pointer() SeongJae Park
@ 2019-04-26 0:57 ` SeongJae Park
2019-04-26 0:57 ` [PATCH 4/5] defer: Fix a typo: processof -> process of SeongJae Park
2019-04-26 0:57 ` [PATCH 5/5] defer: Use 'Go' instead of 'golang' SeongJae Park
4 siblings, 0 replies; 7+ messages in thread
From: SeongJae Park @ 2019-04-26 0:57 UTC (permalink / raw)
To: paulmck; +Cc: perfbook, SeongJae Park
Only one sentence is not placing a 'dash' between two words: 'RCU
protected' and 'update side'. This commit adds dashes for better
consistency.
Signed-off-by: SeongJae Park <sj38.park@gmail.com>
---
defer/rcuapi.tex | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/defer/rcuapi.tex b/defer/rcuapi.tex
index 6e014e0..72aa10c 100644
--- a/defer/rcuapi.tex
+++ b/defer/rcuapi.tex
@@ -578,8 +578,8 @@ prior to the corresponding \co{rcu_assign_pointer()}, even on Alpha CPUs.
On non-Alpha CPUs, \co{rcu_dereference()} documents which pointer
dereferences require RCU protection.
-Another situation where protection is not required is when update side code
-accesses the RCU protected pointer while holding the update-side lock.
+Another situation where protection is not required is when update-side code
+accesses the RCU-protected pointer while holding the update-side lock.
The \co{rcu_dereference_protected()} API member is provided for this
situation.
Its first parameter is the RCU-protected pointer, and the second
--
2.10.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 4/5] defer: Fix a typo: processof -> process of
2019-04-26 0:56 [PATCH] memorder: Fix two trivial typos SeongJae Park
` (2 preceding siblings ...)
2019-04-26 0:57 ` [PATCH 3/5] defer/rcuapi: Consistently use dashes for 'RCU-protected' and 'update-side' SeongJae Park
@ 2019-04-26 0:57 ` SeongJae Park
2019-04-26 0:57 ` [PATCH 5/5] defer: Use 'Go' instead of 'golang' SeongJae Park
4 siblings, 0 replies; 7+ messages in thread
From: SeongJae Park @ 2019-04-26 0:57 UTC (permalink / raw)
To: paulmck; +Cc: perfbook, SeongJae Park
Signed-off-by: SeongJae Park <sj38.park@gmail.com>
---
defer/whichtochoose.tex | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/defer/whichtochoose.tex b/defer/whichtochoose.tex
index c18893d..a0af68f 100644
--- a/defer/whichtochoose.tex
+++ b/defer/whichtochoose.tex
@@ -119,7 +119,7 @@ operation, which is the case for reference counting, hazard pointers,
and sequence locks.
In the case of reference counting and hazard pointers, retries are only
required if an attempt to acquire a reference to a given object while
-that object is in the processof being deleted, a topic covered in more
+that object is in the process of being deleted, a topic covered in more
detail in the next section.
Sequence locking must of course retry its critical section should it
run concurrently with any update.
--
2.10.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 5/5] defer: Use 'Go' instead of 'golang'
2019-04-26 0:56 [PATCH] memorder: Fix two trivial typos SeongJae Park
` (3 preceding siblings ...)
2019-04-26 0:57 ` [PATCH 4/5] defer: Fix a typo: processof -> process of SeongJae Park
@ 2019-04-26 0:57 ` SeongJae Park
4 siblings, 0 replies; 7+ messages in thread
From: SeongJae Park @ 2019-04-26 0:57 UTC (permalink / raw)
To: paulmck; +Cc: perfbook, SeongJae Park
'golang' is an abbreviation for 'Go programming language'. Thus, the
term 'golang programming language', which is used in the 'defer' chapter
has unnecessary duplication. This patch modifies the sentences to use
'Go' instead of 'golang' in general.
Signed-off-by: SeongJae Park <sj38.park@gmail.com>
---
defer/whichtochoose.tex | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/defer/whichtochoose.tex b/defer/whichtochoose.tex
index a0af68f..15df46a 100644
--- a/defer/whichtochoose.tex
+++ b/defer/whichtochoose.tex
@@ -493,9 +493,9 @@ QSBR and epoch-based reclamation
both of which are types of implementations of RCU.
Sheth et al.~\cite{HarshalSheth2016goRCU}
-demonstrated the value of leveraging golang's garbage
+demonstrated the value of leveraging Go's garbage
collector to provide RCU-like functionality, and
-the golang programming language provides a \co{Value} type that can
+the Go programming language provides a \co{Value} type that can
provide this functionality.\footnote{
See \url{https://golang.org/pkg/sync/atomic/\#Value}, particularly
the ``Example (ReadMostly)''.}
--
2.10.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/5] toolsoftrade: Polish an ambiguous sentence
2019-04-26 0:57 ` [PATCH 1/5] toolsoftrade: Polish an ambiguous sentence SeongJae Park
@ 2019-04-26 14:17 ` Paul E. McKenney
0 siblings, 0 replies; 7+ messages in thread
From: Paul E. McKenney @ 2019-04-26 14:17 UTC (permalink / raw)
To: SeongJae Park; +Cc: perfbook
On Fri, Apr 26, 2019 at 09:57:00AM +0900, SeongJae Park wrote:
> A sentence calls a 'signal or interrupt handler' as 'interrupt handler'.
> This commit modifies the sentence to call it just a handler to minimize
> any confusion.
>
> Signed-off-by: SeongJae Park <sj38.park@gmail.com>
Good eyes!!! All five applied and pushed, thank you!
Thanx, Paul
> ---
> toolsoftrade/toolsoftrade.tex | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/toolsoftrade/toolsoftrade.tex b/toolsoftrade/toolsoftrade.tex
> index 4e0764d..1cf118b 100644
> --- a/toolsoftrade/toolsoftrade.tex
> +++ b/toolsoftrade/toolsoftrade.tex
> @@ -2365,8 +2365,8 @@ for other accesses to that same variable:
> All other code must use \co{READ_ONCE()} and \co{WRITE_ONCE()}.
> \item A shared variable is only accessed by a given CPU or thread
> and by a signal or interrupt handler running in that CPU's
> - or thread's context, and the interrupt handler always restores
> - the values of any variables that it has written before return.
> + or thread's context, and the handler always restores the values of any
> + variables that it has written before return.
> The handler can use plain loads and stores, as can any code
> that has prevented the handler from being invoked, that is,
> code that has blocked signals and/or interrupts.
> --
> 2.10.0
>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-04-26 14:17 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-26 0:56 [PATCH] memorder: Fix two trivial typos SeongJae Park
2019-04-26 0:57 ` [PATCH 1/5] toolsoftrade: Polish an ambiguous sentence SeongJae Park
2019-04-26 14:17 ` Paul E. McKenney
2019-04-26 0:57 ` [PATCH 2/5] defer/rcupai: Fix a typo: _pointer()() -> _pointer() SeongJae Park
2019-04-26 0:57 ` [PATCH 3/5] defer/rcuapi: Consistently use dashes for 'RCU-protected' and 'update-side' SeongJae Park
2019-04-26 0:57 ` [PATCH 4/5] defer: Fix a typo: processof -> process of SeongJae Park
2019-04-26 0:57 ` [PATCH 5/5] defer: Use 'Go' instead of 'golang' SeongJae Park
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.