All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: igt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] i915/gem_tiling_max_stride: Skip if chipset is unknown
Date: Fri, 26 Apr 2019 18:00:22 +0300	[thread overview]
Message-ID: <20190426150022.GR24299@intel.com> (raw)
In-Reply-To: <20190426075645.30812-1-chris@chris-wilson.co.uk>

On Fri, Apr 26, 2019 at 08:56:45AM +0100, Chris Wilson wrote:
> If we can't match the devid to a chipset, we do not have a reference for
> the tiling strides. Instead of randomly failing, skip with a
> semi-informative message.
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110523
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> ---
>  tests/i915/gem_tiling_max_stride.c | 16 +++++++++-------
>  1 file changed, 9 insertions(+), 7 deletions(-)
> 
> diff --git a/tests/i915/gem_tiling_max_stride.c b/tests/i915/gem_tiling_max_stride.c
> index a6f97a915..0e99d979f 100644
> --- a/tests/i915/gem_tiling_max_stride.c
> +++ b/tests/i915/gem_tiling_max_stride.c
> @@ -72,16 +72,18 @@ igt_simple_main
>  
>  	devid = intel_get_drm_devid(fd);
>  
> -	if (intel_gen(devid) >= 7)
> +	if (intel_gen(devid) >= 7) {
>  		stride = 256 * 1024;
> -	else if (intel_gen(devid) >= 4)
> +	} else if (intel_gen(devid) >= 4) {
>  		stride = 128 * 1024;
> -	else {
> -		if (IS_GEN2(devid)) {
> -			tile_width = 128;
> -			tile_height = 16;
> -		}
> +	} else if (intel_gen(devid) >= 3) {
> +		stride = 8 * 1024;
> +	} else if (intel_gen(devid) >= 2) {
> +		tile_width = 128;
> +		tile_height = 16;
>  		stride = 8 * 1024;
> +	} else {
> +		igt_skip("Unknown Intel chipset, devid=%04x\n", devid);
>  	}
>  
>  	size = stride * tile_height;
> -- 
> 2.20.1
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev

-- 
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

WARNING: multiple messages have this Message-ID (diff)
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: igt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] i915/gem_tiling_max_stride: Skip if chipset is unknown
Date: Fri, 26 Apr 2019 18:00:22 +0300	[thread overview]
Message-ID: <20190426150022.GR24299@intel.com> (raw)
In-Reply-To: <20190426075645.30812-1-chris@chris-wilson.co.uk>

On Fri, Apr 26, 2019 at 08:56:45AM +0100, Chris Wilson wrote:
> If we can't match the devid to a chipset, we do not have a reference for
> the tiling strides. Instead of randomly failing, skip with a
> semi-informative message.
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110523
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> ---
>  tests/i915/gem_tiling_max_stride.c | 16 +++++++++-------
>  1 file changed, 9 insertions(+), 7 deletions(-)
> 
> diff --git a/tests/i915/gem_tiling_max_stride.c b/tests/i915/gem_tiling_max_stride.c
> index a6f97a915..0e99d979f 100644
> --- a/tests/i915/gem_tiling_max_stride.c
> +++ b/tests/i915/gem_tiling_max_stride.c
> @@ -72,16 +72,18 @@ igt_simple_main
>  
>  	devid = intel_get_drm_devid(fd);
>  
> -	if (intel_gen(devid) >= 7)
> +	if (intel_gen(devid) >= 7) {
>  		stride = 256 * 1024;
> -	else if (intel_gen(devid) >= 4)
> +	} else if (intel_gen(devid) >= 4) {
>  		stride = 128 * 1024;
> -	else {
> -		if (IS_GEN2(devid)) {
> -			tile_width = 128;
> -			tile_height = 16;
> -		}
> +	} else if (intel_gen(devid) >= 3) {
> +		stride = 8 * 1024;
> +	} else if (intel_gen(devid) >= 2) {
> +		tile_width = 128;
> +		tile_height = 16;
>  		stride = 8 * 1024;
> +	} else {
> +		igt_skip("Unknown Intel chipset, devid=%04x\n", devid);
>  	}
>  
>  	size = stride * tile_height;
> -- 
> 2.20.1
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2019-04-26 15:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-26  7:56 [igt-dev] [PATCH i-g-t] i915/gem_tiling_max_stride: Skip if chipset is unknown Chris Wilson
2019-04-26  7:56 ` Chris Wilson
2019-04-26  8:20 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-04-26 13:47 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-04-26 15:00 ` Ville Syrjälä [this message]
2019-04-26 15:00   ` [igt-dev] [PATCH i-g-t] " Ville Syrjälä

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190426150022.GR24299@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.