All of lore.kernel.org
 help / color / mirror / Atom feed
* [RFC PATCH dm] dm: dust_rb_search() can be static
  2019-04-26 23:12 [dm:dm-5.2 22/22] drivers/md/dm-dust.c:35:17: sparse: sparse: symbol 'dust_rb_search' was not declared. Should it be static? kbuild test robot
@ 2019-04-26 23:12 ` kbuild test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kbuild test robot @ 2019-04-26 23:12 UTC (permalink / raw)
  To: Bryan Gurney; +Cc: dm-devel, kbuild-all, Mike Snitzer


Fixes: cefb8eb074c8 ("dm: add dust target")
Signed-off-by: kbuild test robot <lkp@intel.com>
---
 dm-dust.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/md/dm-dust.c b/drivers/md/dm-dust.c
index f5434ada..dd56284 100644
--- a/drivers/md/dm-dust.c
+++ b/drivers/md/dm-dust.c
@@ -32,7 +32,7 @@ struct dust_device {
 	bool quiet_mode:1;
 };
 
-struct badblock *dust_rb_search(struct rb_root *root, sector_t blk)
+static struct badblock *dust_rb_search(struct rb_root *root, sector_t blk)
 {
 	struct rb_node *node = root->rb_node;
 
@@ -50,7 +50,7 @@ struct badblock *dust_rb_search(struct rb_root *root, sector_t blk)
 	return NULL;
 }
 
-bool dust_rb_insert(struct rb_root *root, struct badblock *new)
+static bool dust_rb_insert(struct rb_root *root, struct badblock *new)
 {
 	struct badblock *bblk;
 	struct rb_node **link = &root->rb_node, *parent = NULL;
@@ -492,7 +492,7 @@ static struct target_type dust_target = {
 	.prepare_ioctl = dust_prepare_ioctl,
 };
 
-int __init dm_dust_init(void)
+static int __init dm_dust_init(void)
 {
 	int result = dm_register_target(&dust_target);
 
@@ -502,7 +502,7 @@ int __init dm_dust_init(void)
 	return result;
 }
 
-void __exit dm_dust_exit(void)
+static void __exit dm_dust_exit(void)
 {
 	dm_unregister_target(&dust_target);
 }

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [dm:dm-5.2 22/22] drivers/md/dm-dust.c:35:17: sparse: sparse: symbol 'dust_rb_search' was not declared. Should it be static?
@ 2019-04-26 23:12 kbuild test robot
  2019-04-26 23:12 ` [RFC PATCH dm] dm: dust_rb_search() can be static kbuild test robot
  0 siblings, 1 reply; 2+ messages in thread
From: kbuild test robot @ 2019-04-26 23:12 UTC (permalink / raw)
  To: Bryan Gurney; +Cc: dm-devel, kbuild-all, Mike Snitzer

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git dm-5.2
head:   cefb8eb074c8cde87d4a6947e24c00b8cbde830c
commit: cefb8eb074c8cde87d4a6947e24c00b8cbde830c [22/22] dm: add dust target
reproduce:
        # apt-get install sparse
        git checkout cefb8eb074c8cde87d4a6947e24c00b8cbde830c
        make ARCH=x86_64 allmodconfig
        make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)

>> drivers/md/dm-dust.c:35:17: sparse: sparse: symbol 'dust_rb_search' was not declared. Should it be static?
>> drivers/md/dm-dust.c:53:6: sparse: sparse: symbol 'dust_rb_insert' was not declared. Should it be static?
>> drivers/md/dm-dust.c:495:12: sparse: sparse: symbol 'dm_dust_init' was not declared. Should it be static?
>> drivers/md/dm-dust.c:505:13: sparse: sparse: symbol 'dm_dust_exit' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-04-26 23:12 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-26 23:12 [dm:dm-5.2 22/22] drivers/md/dm-dust.c:35:17: sparse: sparse: symbol 'dust_rb_search' was not declared. Should it be static? kbuild test robot
2019-04-26 23:12 ` [RFC PATCH dm] dm: dust_rb_search() can be static kbuild test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.