* [Linux-kernel-mentees] [PATCH] Fix checkpatch.pl warnings
@ 2019-04-26 13:12 ` Vandana BN
0 siblings, 0 replies; 27+ messages in thread
From: Vandana BN @ 2019-04-26 13:12 UTC (permalink / raw)
Signed-off-by: Vandana BN <bnvandana at gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_debug.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_debug.c b/drivers/staging/rtl8723bs/core/rtw_debug.c
index 0de1e12a676e..3fb09ad45a67 100644
--- a/drivers/staging/rtl8723bs/core/rtw_debug.c
+++ b/drivers/staging/rtl8723bs/core/rtw_debug.c
@@ -1425,9 +1425,8 @@ int proc_get_btcoex_info(struct seq_file *m, void *v)
padapter = (struct adapter *)rtw_netdev_priv(dev);
pbuf = rtw_zmalloc(bufsize);
- if (NULL == pbuf) {
+ if (pbuf == NULL)
return -ENOMEM;
- }
rtw_btcoex_DisplayBtCoexInfo(padapter, pbuf, bufsize);
--
2.17.1
^ permalink raw reply related [flat|nested] 27+ messages in thread* [Linux-kernel-mentees] [PATCH] Fix checkpatch.pl warnings
@ 2019-04-26 13:49 ` Shuah Khan
0 siblings, 0 replies; 27+ messages in thread
From: skhan @ 2019-04-26 13:49 UTC (permalink / raw)
On 4/26/19 7:12 AM, Vandana BN wrote:
> Signed-off-by: Vandana BN <bnvandana at gmail.com>
> ---
> drivers/staging/rtl8723bs/core/rtw_debug.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_debug.c b/drivers/staging/rtl8723bs/core/rtw_debug.c
> index 0de1e12a676e..3fb09ad45a67 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_debug.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_debug.c
> @@ -1425,9 +1425,8 @@ int proc_get_btcoex_info(struct seq_file *m, void *v)
> padapter = (struct adapter *)rtw_netdev_priv(dev);
>
> pbuf = rtw_zmalloc(bufsize);
> - if (NULL == pbuf) {
> + if (pbuf == NULL)
> return -ENOMEM;
> - }
>
> rtw_btcoex_DisplayBtCoexInfo(padapter, pbuf, bufsize);
>
>
Hi Vandana,
Thanks for the patch. A few things to note:
The commit summary line should include the area and driver.
Instead of "Fix checkpatch.pl warnings", it should say:
"staging: rtl8723bs: Fix checkpatch.pl warnings"
Please include the checkpatch warning in the commit message to tell
us more about the reason for this fix.
Please look at a few patches that get posted to Linux kernel
mailing lists - you can find them on https://lkml.org/lkml/last100/
for what kind if details should be included in the commit log.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 27+ messages in thread* [Linux-kernel-mentees] [PATCH] Fix checkpatch.pl warnings
@ 2019-04-26 13:49 ` Shuah Khan
0 siblings, 0 replies; 27+ messages in thread
From: Shuah Khan @ 2019-04-26 13:49 UTC (permalink / raw)
On 4/26/19 7:12 AM, Vandana BN wrote:
> Signed-off-by: Vandana BN <bnvandana at gmail.com>
> ---
> drivers/staging/rtl8723bs/core/rtw_debug.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_debug.c b/drivers/staging/rtl8723bs/core/rtw_debug.c
> index 0de1e12a676e..3fb09ad45a67 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_debug.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_debug.c
> @@ -1425,9 +1425,8 @@ int proc_get_btcoex_info(struct seq_file *m, void *v)
> padapter = (struct adapter *)rtw_netdev_priv(dev);
>
> pbuf = rtw_zmalloc(bufsize);
> - if (NULL == pbuf) {
> + if (pbuf == NULL)
> return -ENOMEM;
> - }
>
> rtw_btcoex_DisplayBtCoexInfo(padapter, pbuf, bufsize);
>
>
Hi Vandana,
Thanks for the patch. A few things to note:
The commit summary line should include the area and driver.
Instead of "Fix checkpatch.pl warnings", it should say:
"staging: rtl8723bs: Fix checkpatch.pl warnings"
Please include the checkpatch warning in the commit message to tell
us more about the reason for this fix.
Please look at a few patches that get posted to Linux kernel
mailing lists - you can find them on https://lkml.org/lkml/last100/
for what kind if details should be included in the commit log.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 27+ messages in thread* [Linux-kernel-mentees] [PATCH] Fix checkpatch.pl warnings
@ 2019-04-26 17:46 ` bnva
0 siblings, 0 replies; 27+ messages in thread
From: bnvandana @ 2019-04-26 17:46 UTC (permalink / raw)
On 26/04/19 7:19 PM, Shuah Khan wrote:
> On 4/26/19 7:12 AM, Vandana BN wrote:
>> Signed-off-by: Vandana BN <bnvandana at gmail.com>
>> ---
>> ? drivers/staging/rtl8723bs/core/rtw_debug.c | 3 +--
>> ? 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/rtl8723bs/core/rtw_debug.c b/drivers/staging/rtl8723bs/core/rtw_debug.c
>> index 0de1e12a676e..3fb09ad45a67 100644
>> --- a/drivers/staging/rtl8723bs/core/rtw_debug.c
>> +++ b/drivers/staging/rtl8723bs/core/rtw_debug.c
>> @@ -1425,9 +1425,8 @@ int proc_get_btcoex_info(struct seq_file *m, void *v)
>> ????? padapter = (struct adapter *)rtw_netdev_priv(dev);
>> ? ????? pbuf = rtw_zmalloc(bufsize);
>> -??? if (NULL == pbuf) {
>> +??? if (pbuf == NULL)
>> ????????? return -ENOMEM;
>> -??? }
>> ? ????? rtw_btcoex_DisplayBtCoexInfo(padapter, pbuf, bufsize);
>> ?
>
>
> Hi Vandana,
>
> Thanks for the patch. A few things to note:
>
> The commit summary line should include the area and driver.
>
> Instead of "Fix checkpatch.pl warnings", it should say:
>
> "staging: rtl8723bs: Fix checkpatch.pl warnings"
>
> Please include the checkpatch warning in the commit message to tell
> us more about the reason for this fix.
>
> Please look at a few patches that get posted to Linux kernel
> mailing lists - you can find them on https://lkml.org/lkml/last100/
> for what kind if details should be included in the commit log.
>
> thanks,
> -- Shuah
Thank you.
I have sent another patch adding commit message and changing the subject.
regards,
Vandana.
^ permalink raw reply [flat|nested] 27+ messages in thread* [Linux-kernel-mentees] [PATCH] Fix checkpatch.pl warnings
@ 2019-04-26 17:46 ` bnva
0 siblings, 0 replies; 27+ messages in thread
From: bnva @ 2019-04-26 17:46 UTC (permalink / raw)
On 26/04/19 7:19 PM, Shuah Khan wrote:
> On 4/26/19 7:12 AM, Vandana BN wrote:
>> Signed-off-by: Vandana BN <bnvandana at gmail.com>
>> ---
>> ? drivers/staging/rtl8723bs/core/rtw_debug.c | 3 +--
>> ? 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/rtl8723bs/core/rtw_debug.c b/drivers/staging/rtl8723bs/core/rtw_debug.c
>> index 0de1e12a676e..3fb09ad45a67 100644
>> --- a/drivers/staging/rtl8723bs/core/rtw_debug.c
>> +++ b/drivers/staging/rtl8723bs/core/rtw_debug.c
>> @@ -1425,9 +1425,8 @@ int proc_get_btcoex_info(struct seq_file *m, void *v)
>> ????? padapter = (struct adapter *)rtw_netdev_priv(dev);
>> ? ????? pbuf = rtw_zmalloc(bufsize);
>> -??? if (NULL == pbuf) {
>> +??? if (pbuf == NULL)
>> ????????? return -ENOMEM;
>> -??? }
>> ? ????? rtw_btcoex_DisplayBtCoexInfo(padapter, pbuf, bufsize);
>> ?
>
>
> Hi Vandana,
>
> Thanks for the patch. A few things to note:
>
> The commit summary line should include the area and driver.
>
> Instead of "Fix checkpatch.pl warnings", it should say:
>
> "staging: rtl8723bs: Fix checkpatch.pl warnings"
>
> Please include the checkpatch warning in the commit message to tell
> us more about the reason for this fix.
>
> Please look at a few patches that get posted to Linux kernel
> mailing lists - you can find them on https://lkml.org/lkml/last100/
> for what kind if details should be included in the commit log.
>
> thanks,
> -- Shuah
Thank you.
I have sent another patch adding commit message and changing the subject.
regards,
Vandana.
^ permalink raw reply [flat|nested] 27+ messages in thread
* [Linux-kernel-mentees] [PATCH v2] staging: rtl8723bs: Fix checkpatch.pl warnings
@ 2019-04-26 17:40 ` Vandana BN
0 siblings, 0 replies; 27+ messages in thread
From: bnvandana @ 2019-04-26 17:40 UTC (permalink / raw)
fixed below warnings,
Comparisons should place the constant on the right side of the test
braces {} are not necessary for single statement blocks
Signed-off-by: Vandana BN <bnvandana at gmail.com>
------
v2- Edited commit message and subject
------
---
drivers/staging/rtl8723bs/core/rtw_debug.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_debug.c b/drivers/staging/rtl8723bs/core/rtw_debug.c
index 0de1e12a676e..3fb09ad45a67 100644
--- a/drivers/staging/rtl8723bs/core/rtw_debug.c
+++ b/drivers/staging/rtl8723bs/core/rtw_debug.c
@@ -1425,9 +1425,8 @@ int proc_get_btcoex_info(struct seq_file *m, void *v)
padapter = (struct adapter *)rtw_netdev_priv(dev);
pbuf = rtw_zmalloc(bufsize);
- if (NULL == pbuf) {
+ if (pbuf == NULL)
return -ENOMEM;
- }
rtw_btcoex_DisplayBtCoexInfo(padapter, pbuf, bufsize);
--
2.17.1
^ permalink raw reply related [flat|nested] 27+ messages in thread* [Linux-kernel-mentees] [PATCH v2] staging: rtl8723bs: Fix checkpatch.pl warnings
@ 2019-04-26 17:40 ` Vandana BN
0 siblings, 0 replies; 27+ messages in thread
From: Vandana BN @ 2019-04-26 17:40 UTC (permalink / raw)
fixed below warnings,
Comparisons should place the constant on the right side of the test
braces {} are not necessary for single statement blocks
Signed-off-by: Vandana BN <bnvandana at gmail.com>
------
v2- Edited commit message and subject
------
---
drivers/staging/rtl8723bs/core/rtw_debug.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_debug.c b/drivers/staging/rtl8723bs/core/rtw_debug.c
index 0de1e12a676e..3fb09ad45a67 100644
--- a/drivers/staging/rtl8723bs/core/rtw_debug.c
+++ b/drivers/staging/rtl8723bs/core/rtw_debug.c
@@ -1425,9 +1425,8 @@ int proc_get_btcoex_info(struct seq_file *m, void *v)
padapter = (struct adapter *)rtw_netdev_priv(dev);
pbuf = rtw_zmalloc(bufsize);
- if (NULL == pbuf) {
+ if (pbuf == NULL)
return -ENOMEM;
- }
rtw_btcoex_DisplayBtCoexInfo(padapter, pbuf, bufsize);
--
2.17.1
^ permalink raw reply related [flat|nested] 27+ messages in thread* [Linux-kernel-mentees] [PATCH v2] staging: rtl8723bs: Fix checkpatch.pl warnings
@ 2019-04-26 18:08 ` Bharath Vedartham
0 siblings, 0 replies; 27+ messages in thread
From: linux.bhar @ 2019-04-26 18:08 UTC (permalink / raw)
On Fri, Apr 26, 2019 at 11:10:25PM +0530, Vandana BN wrote:
> fixed below warnings,
> Comparisons should place the constant on the right side of the test
> braces {} are not necessary for single statement blocks
>
> Signed-off-by: Vandana BN <bnvandana at gmail.com>
>
> ------
> v2- Edited commit message and subject
> ------
> ---
> drivers/staging/rtl8723bs/core/rtw_debug.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_debug.c b/drivers/staging/rtl8723bs/core/rtw_debug.c
> index 0de1e12a676e..3fb09ad45a67 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_debug.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_debug.c
> @@ -1425,9 +1425,8 @@ int proc_get_btcoex_info(struct seq_file *m, void *v)
> padapter = (struct adapter *)rtw_netdev_priv(dev);
>
> pbuf = rtw_zmalloc(bufsize);
> - if (NULL == pbuf) {
> + if (pbuf == NULL)
> return -ENOMEM;
> - }
>
> rtw_btcoex_DisplayBtCoexInfo(padapter, pbuf, bufsize);
>
> --
> 2.17.1
>
Hey!
Your patch subject should briefly describe the changes you are making.
It should not be very generic like "fix checkpatch.pl warnings" or "fix
sparse warnings".
A good subject would be:
"Place constant on the right"
In your changelog, you can mention the fact that this is a checkpatch.pl
warning. Something like:
"This patch fixes the checkpatch.pl warning:
<Whatever the warning was>
"
Read this before submitting your patch:
https://kernelnewbies.org/PatchPhilosophy
This is a great place to begin your patches journey!:
https://kernelnewbies.org/Outreachyfirstpatch
And also did you send this to the appropriate mailing lists?
Use ./scripts/get_maintainer.pl to get the maintainer and mailing list
to send this patch to. You ll be sending your patch to Greg again :p as
he maintains the staging branch.
Bharath
> _______________________________________________
> Linux-kernel-mentees mailing list
> Linux-kernel-mentees at lists.linuxfoundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
^ permalink raw reply [flat|nested] 27+ messages in thread* [Linux-kernel-mentees] [PATCH v2] staging: rtl8723bs: Fix checkpatch.pl warnings
@ 2019-04-26 18:08 ` Bharath Vedartham
0 siblings, 0 replies; 27+ messages in thread
From: Bharath Vedartham @ 2019-04-26 18:08 UTC (permalink / raw)
On Fri, Apr 26, 2019 at 11:10:25PM +0530, Vandana BN wrote:
> fixed below warnings,
> Comparisons should place the constant on the right side of the test
> braces {} are not necessary for single statement blocks
>
> Signed-off-by: Vandana BN <bnvandana at gmail.com>
>
> ------
> v2- Edited commit message and subject
> ------
> ---
> drivers/staging/rtl8723bs/core/rtw_debug.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_debug.c b/drivers/staging/rtl8723bs/core/rtw_debug.c
> index 0de1e12a676e..3fb09ad45a67 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_debug.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_debug.c
> @@ -1425,9 +1425,8 @@ int proc_get_btcoex_info(struct seq_file *m, void *v)
> padapter = (struct adapter *)rtw_netdev_priv(dev);
>
> pbuf = rtw_zmalloc(bufsize);
> - if (NULL == pbuf) {
> + if (pbuf == NULL)
> return -ENOMEM;
> - }
>
> rtw_btcoex_DisplayBtCoexInfo(padapter, pbuf, bufsize);
>
> --
> 2.17.1
>
Hey!
Your patch subject should briefly describe the changes you are making.
It should not be very generic like "fix checkpatch.pl warnings" or "fix
sparse warnings".
A good subject would be:
"Place constant on the right"
In your changelog, you can mention the fact that this is a checkpatch.pl
warning. Something like:
"This patch fixes the checkpatch.pl warning:
<Whatever the warning was>
"
Read this before submitting your patch:
https://kernelnewbies.org/PatchPhilosophy
This is a great place to begin your patches journey!:
https://kernelnewbies.org/Outreachyfirstpatch
And also did you send this to the appropriate mailing lists?
Use ./scripts/get_maintainer.pl to get the maintainer and mailing list
to send this patch to. You ll be sending your patch to Greg again :p as
he maintains the staging branch.
Bharath
> _______________________________________________
> Linux-kernel-mentees mailing list
> Linux-kernel-mentees at lists.linuxfoundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
^ permalink raw reply [flat|nested] 27+ messages in thread* [Linux-kernel-mentees] [PATCH v2] staging: rtl8723bs: Fix checkpatch.pl warnings
@ 2019-04-26 18:17 ` Shuah Khan
0 siblings, 0 replies; 27+ messages in thread
From: skhan @ 2019-04-26 18:17 UTC (permalink / raw)
On 4/26/19 12:08 PM, Bharath Vedartham wrote:
> On Fri, Apr 26, 2019 at 11:10:25PM +0530, Vandana BN wrote:
>> fixed below warnings,
>> Comparisons should place the constant on the right side of the test
>> braces {} are not necessary for single statement blocks
>>
>> Signed-off-by: Vandana BN <bnvandana at gmail.com>
>>
>> ------
>> v2- Edited commit message and subject
>> ------
>> ---
>> drivers/staging/rtl8723bs/core/rtw_debug.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/rtl8723bs/core/rtw_debug.c b/drivers/staging/rtl8723bs/core/rtw_debug.c
>> index 0de1e12a676e..3fb09ad45a67 100644
>> --- a/drivers/staging/rtl8723bs/core/rtw_debug.c
>> +++ b/drivers/staging/rtl8723bs/core/rtw_debug.c
>> @@ -1425,9 +1425,8 @@ int proc_get_btcoex_info(struct seq_file *m, void *v)
>> padapter = (struct adapter *)rtw_netdev_priv(dev);
>>
>> pbuf = rtw_zmalloc(bufsize);
>> - if (NULL == pbuf) {
>> + if (pbuf == NULL)
>> return -ENOMEM;
>> - }
>>
>> rtw_btcoex_DisplayBtCoexInfo(padapter, pbuf, bufsize);
>>
>> --
>> 2.17.1
>>
> Hey!
>
> Your patch subject should briefly describe the changes you are making.
> It should not be very generic like "fix checkpatch.pl warnings" or "fix
> sparse warnings".
>
> A good subject would be:
> "Place constant on the right"
>
> In your changelog, you can mention the fact that this is a checkpatch.pl
> warning. Something like:
> "This patch fixes the checkpatch.pl warning:
> <Whatever the warning was>
> "
>
> Read this before submitting your patch:
> https://kernelnewbies.org/PatchPhilosophy
>
> This is a great place to begin your patches journey!:
> https://kernelnewbies.org/Outreachyfirstpatch
Please don't follow Outreachyfirstpatch instructions - even if
you do, don't send the patch to OutReachy mailing list and this
will be very confusing!!
You should follow the instructions on
https://wiki.linuxfoundation.org/lkmp to send patches.
>
> And also did you send this to the appropriate mailing lists?
This is fine - the first patch can come just to
linux-kernel-mentees at lists.linuxfoundation.org
>
> Use ./scripts/get_maintainer.pl to get the maintainer and mailing list
> to send this patch to. You ll be sending your patch to Greg again :p as
> he maintains the staging branch.
>
Greg is on the cc.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 27+ messages in thread* [Linux-kernel-mentees] [PATCH v2] staging: rtl8723bs: Fix checkpatch.pl warnings
@ 2019-04-26 18:17 ` Shuah Khan
0 siblings, 0 replies; 27+ messages in thread
From: Shuah Khan @ 2019-04-26 18:17 UTC (permalink / raw)
On 4/26/19 12:08 PM, Bharath Vedartham wrote:
> On Fri, Apr 26, 2019 at 11:10:25PM +0530, Vandana BN wrote:
>> fixed below warnings,
>> Comparisons should place the constant on the right side of the test
>> braces {} are not necessary for single statement blocks
>>
>> Signed-off-by: Vandana BN <bnvandana at gmail.com>
>>
>> ------
>> v2- Edited commit message and subject
>> ------
>> ---
>> drivers/staging/rtl8723bs/core/rtw_debug.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/rtl8723bs/core/rtw_debug.c b/drivers/staging/rtl8723bs/core/rtw_debug.c
>> index 0de1e12a676e..3fb09ad45a67 100644
>> --- a/drivers/staging/rtl8723bs/core/rtw_debug.c
>> +++ b/drivers/staging/rtl8723bs/core/rtw_debug.c
>> @@ -1425,9 +1425,8 @@ int proc_get_btcoex_info(struct seq_file *m, void *v)
>> padapter = (struct adapter *)rtw_netdev_priv(dev);
>>
>> pbuf = rtw_zmalloc(bufsize);
>> - if (NULL == pbuf) {
>> + if (pbuf == NULL)
>> return -ENOMEM;
>> - }
>>
>> rtw_btcoex_DisplayBtCoexInfo(padapter, pbuf, bufsize);
>>
>> --
>> 2.17.1
>>
> Hey!
>
> Your patch subject should briefly describe the changes you are making.
> It should not be very generic like "fix checkpatch.pl warnings" or "fix
> sparse warnings".
>
> A good subject would be:
> "Place constant on the right"
>
> In your changelog, you can mention the fact that this is a checkpatch.pl
> warning. Something like:
> "This patch fixes the checkpatch.pl warning:
> <Whatever the warning was>
> "
>
> Read this before submitting your patch:
> https://kernelnewbies.org/PatchPhilosophy
>
> This is a great place to begin your patches journey!:
> https://kernelnewbies.org/Outreachyfirstpatch
Please don't follow Outreachyfirstpatch instructions - even if
you do, don't send the patch to OutReachy mailing list and this
will be very confusing!!
You should follow the instructions on
https://wiki.linuxfoundation.org/lkmp to send patches.
>
> And also did you send this to the appropriate mailing lists?
This is fine - the first patch can come just to
linux-kernel-mentees at lists.linuxfoundation.org
>
> Use ./scripts/get_maintainer.pl to get the maintainer and mailing list
> to send this patch to. You ll be sending your patch to Greg again :p as
> he maintains the staging branch.
>
Greg is on the cc.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 27+ messages in thread
* [Linux-kernel-mentees] [PATCH v2] staging: rtl8723bs: Fix checkpatch.pl warnings
@ 2019-04-26 18:54 ` Shuah Khan
0 siblings, 0 replies; 27+ messages in thread
From: skhan @ 2019-04-26 18:54 UTC (permalink / raw)
On 4/26/19 11:40 AM, Vandana BN wrote:
> fixed below warnings,
> Comparisons should place the constant on the right side of the test
> braces {} are not necessary for single statement blocks
>
> Signed-off-by: Vandana BN <bnvandana at gmail.com>
>
> ------
> v2- Edited commit message and subject
> ------
> ---
> drivers/staging/rtl8723bs/core/rtw_debug.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_debug.c b/drivers/staging/rtl8723bs/core/rtw_debug.c
> index 0de1e12a676e..3fb09ad45a67 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_debug.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_debug.c
> @@ -1425,9 +1425,8 @@ int proc_get_btcoex_info(struct seq_file *m, void *v)
> padapter = (struct adapter *)rtw_netdev_priv(dev);
>
> pbuf = rtw_zmalloc(bufsize);
> - if (NULL == pbuf) {
> + if (pbuf == NULL)
> return -ENOMEM;
> - }
>
> rtw_btcoex_DisplayBtCoexInfo(padapter, pbuf, bufsize);
>
>
Please make the changes to improve the commit log. State what you are
changing.
Please go ahead and the patch to the everybody getmaintainers.pl
suggests and cc me and linux-kernel-mentees at list.linuxfoundation.org
The same as above for your future patches.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 27+ messages in thread* [Linux-kernel-mentees] [PATCH v2] staging: rtl8723bs: Fix checkpatch.pl warnings
@ 2019-04-26 18:54 ` Shuah Khan
0 siblings, 0 replies; 27+ messages in thread
From: Shuah Khan @ 2019-04-26 18:54 UTC (permalink / raw)
On 4/26/19 11:40 AM, Vandana BN wrote:
> fixed below warnings,
> Comparisons should place the constant on the right side of the test
> braces {} are not necessary for single statement blocks
>
> Signed-off-by: Vandana BN <bnvandana at gmail.com>
>
> ------
> v2- Edited commit message and subject
> ------
> ---
> drivers/staging/rtl8723bs/core/rtw_debug.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_debug.c b/drivers/staging/rtl8723bs/core/rtw_debug.c
> index 0de1e12a676e..3fb09ad45a67 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_debug.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_debug.c
> @@ -1425,9 +1425,8 @@ int proc_get_btcoex_info(struct seq_file *m, void *v)
> padapter = (struct adapter *)rtw_netdev_priv(dev);
>
> pbuf = rtw_zmalloc(bufsize);
> - if (NULL == pbuf) {
> + if (pbuf == NULL)
> return -ENOMEM;
> - }
>
> rtw_btcoex_DisplayBtCoexInfo(padapter, pbuf, bufsize);
>
>
Please make the changes to improve the commit log. State what you are
changing.
Please go ahead and the patch to the everybody getmaintainers.pl
suggests and cc me and linux-kernel-mentees at list.linuxfoundation.org
The same as above for your future patches.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 27+ messages in thread
* [Linux-kernel-mentees] [PATCH v3] staging: rtl8723bs: Fix checkpatch.pl warnings
@ 2019-04-27 5:50 ` Vandana BN
0 siblings, 0 replies; 27+ messages in thread
From: bnvandana @ 2019-04-27 5:50 UTC (permalink / raw)
This patch resolves coding style brace warning and constant on right warning.
WARNING: Comparisons should place the constant on the right side of the test
WARNING: braces {} are not necessary for single statement blocks
Signed-off-by: Vandana BN <bnvandana at gmail.com>
------
v2- Edited commit message and subject
v3- Edited commit message
------
---
drivers/staging/rtl8723bs/core/rtw_debug.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_debug.c b/drivers/staging/rtl8723bs/core/rtw_debug.c
index 0de1e12a676e..3fb09ad45a67 100644
--- a/drivers/staging/rtl8723bs/core/rtw_debug.c
+++ b/drivers/staging/rtl8723bs/core/rtw_debug.c
@@ -1425,9 +1425,8 @@ int proc_get_btcoex_info(struct seq_file *m, void *v)
padapter = (struct adapter *)rtw_netdev_priv(dev);
pbuf = rtw_zmalloc(bufsize);
- if (NULL == pbuf) {
+ if (pbuf == NULL)
return -ENOMEM;
- }
rtw_btcoex_DisplayBtCoexInfo(padapter, pbuf, bufsize);
--
2.17.1
^ permalink raw reply related [flat|nested] 27+ messages in thread* [Linux-kernel-mentees] [PATCH v3] staging: rtl8723bs: Fix checkpatch.pl warnings
@ 2019-04-27 5:50 ` Vandana BN
0 siblings, 0 replies; 27+ messages in thread
From: Vandana BN @ 2019-04-27 5:50 UTC (permalink / raw)
This patch resolves coding style brace warning and constant on right warning.
WARNING: Comparisons should place the constant on the right side of the test
WARNING: braces {} are not necessary for single statement blocks
Signed-off-by: Vandana BN <bnvandana at gmail.com>
------
v2- Edited commit message and subject
v3- Edited commit message
------
---
drivers/staging/rtl8723bs/core/rtw_debug.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_debug.c b/drivers/staging/rtl8723bs/core/rtw_debug.c
index 0de1e12a676e..3fb09ad45a67 100644
--- a/drivers/staging/rtl8723bs/core/rtw_debug.c
+++ b/drivers/staging/rtl8723bs/core/rtw_debug.c
@@ -1425,9 +1425,8 @@ int proc_get_btcoex_info(struct seq_file *m, void *v)
padapter = (struct adapter *)rtw_netdev_priv(dev);
pbuf = rtw_zmalloc(bufsize);
- if (NULL == pbuf) {
+ if (pbuf == NULL)
return -ENOMEM;
- }
rtw_btcoex_DisplayBtCoexInfo(padapter, pbuf, bufsize);
--
2.17.1
^ permalink raw reply related [flat|nested] 27+ messages in thread* [Linux-kernel-mentees] [PATCH v3] staging: rtl8723bs: Fix checkpatch.pl warnings
@ 2019-04-27 6:31 ` Greg KH
0 siblings, 0 replies; 27+ messages in thread
From: gregkh @ 2019-04-27 6:31 UTC (permalink / raw)
On Sat, Apr 27, 2019 at 11:20:20AM +0530, Vandana BN wrote:
> This patch resolves coding style brace warning and constant on right warning.
> WARNING: Comparisons should place the constant on the right side of the test
> WARNING: braces {} are not necessary for single statement blocks
>
> Signed-off-by: Vandana BN <bnvandana at gmail.com>
I need a "real name" here, and in the From: line. Unless I am mistaken
and your last name is just "BN" and that is how you sign legal
documents? If so, please let me know.
> ------
> v2- Edited commit message and subject
> v3- Edited commit message
> ------
> ---
> drivers/staging/rtl8723bs/core/rtw_debug.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_debug.c b/drivers/staging/rtl8723bs/core/rtw_debug.c
> index 0de1e12a676e..3fb09ad45a67 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_debug.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_debug.c
> @@ -1425,9 +1425,8 @@ int proc_get_btcoex_info(struct seq_file *m, void *v)
> padapter = (struct adapter *)rtw_netdev_priv(dev);
>
> pbuf = rtw_zmalloc(bufsize);
> - if (NULL == pbuf) {
> + if (pbuf == NULL)
checkpatch.pl was ok with this? It didn't say to write this line
differently after you ran this patch through it?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 27+ messages in thread* [Linux-kernel-mentees] [PATCH v3] staging: rtl8723bs: Fix checkpatch.pl warnings
@ 2019-04-27 6:31 ` Greg KH
0 siblings, 0 replies; 27+ messages in thread
From: Greg KH @ 2019-04-27 6:31 UTC (permalink / raw)
On Sat, Apr 27, 2019 at 11:20:20AM +0530, Vandana BN wrote:
> This patch resolves coding style brace warning and constant on right warning.
> WARNING: Comparisons should place the constant on the right side of the test
> WARNING: braces {} are not necessary for single statement blocks
>
> Signed-off-by: Vandana BN <bnvandana at gmail.com>
I need a "real name" here, and in the From: line. Unless I am mistaken
and your last name is just "BN" and that is how you sign legal
documents? If so, please let me know.
> ------
> v2- Edited commit message and subject
> v3- Edited commit message
> ------
> ---
> drivers/staging/rtl8723bs/core/rtw_debug.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_debug.c b/drivers/staging/rtl8723bs/core/rtw_debug.c
> index 0de1e12a676e..3fb09ad45a67 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_debug.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_debug.c
> @@ -1425,9 +1425,8 @@ int proc_get_btcoex_info(struct seq_file *m, void *v)
> padapter = (struct adapter *)rtw_netdev_priv(dev);
>
> pbuf = rtw_zmalloc(bufsize);
> - if (NULL == pbuf) {
> + if (pbuf == NULL)
checkpatch.pl was ok with this? It didn't say to write this line
differently after you ran this patch through it?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 27+ messages in thread* [Linux-kernel-mentees] [PATCH v3] staging: rtl8723bs: Fix checkpatch.pl warnings
@ 2019-04-27 7:24 ` Vandana BN
0 siblings, 0 replies; 27+ messages in thread
From: bnvandana @ 2019-04-27 7:24 UTC (permalink / raw)
On 27/04/19 12:01 PM, Greg KH wrote:
> On Sat, Apr 27, 2019 at 11:20:20AM +0530, Vandana BN wrote:
>> This patch resolves coding style brace warning and constant on right warning.
>> WARNING: Comparisons should place the constant on the right side of the test
>> WARNING: braces {} are not necessary for single statement blocks
>>
>> Signed-off-by: Vandana BN <bnvandana at gmail.com>
> I need a "real name" here, and in the From: line. Unless I am mistaken
> and your last name is just "BN" and that is how you sign legal
> documents? If so, please let me know.
Vandana BN is my real and legal name :)
>
>
>> ------
>> v2- Edited commit message and subject
>> v3- Edited commit message
>> ------
>> ---
>> drivers/staging/rtl8723bs/core/rtw_debug.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/rtl8723bs/core/rtw_debug.c b/drivers/staging/rtl8723bs/core/rtw_debug.c
>> index 0de1e12a676e..3fb09ad45a67 100644
>> --- a/drivers/staging/rtl8723bs/core/rtw_debug.c
>> +++ b/drivers/staging/rtl8723bs/core/rtw_debug.c
>> @@ -1425,9 +1425,8 @@ int proc_get_btcoex_info(struct seq_file *m, void *v)
>> padapter = (struct adapter *)rtw_netdev_priv(dev);
>>
>> pbuf = rtw_zmalloc(bufsize);
>> - if (NULL == pbuf) {
>> + if (pbuf == NULL)
> checkpatch.pl was ok with this? It didn't say to write this line
> differently after you ran this patch through it?
>
> thanks,
>
> greg k-h
Thanks I had missed looking at CHECK .will resolve and send a new patch.
Regards,
Vandana.
^ permalink raw reply [flat|nested] 27+ messages in thread* [Linux-kernel-mentees] [PATCH v3] staging: rtl8723bs: Fix checkpatch.pl warnings
@ 2019-04-27 7:24 ` Vandana BN
0 siblings, 0 replies; 27+ messages in thread
From: Vandana BN @ 2019-04-27 7:24 UTC (permalink / raw)
On 27/04/19 12:01 PM, Greg KH wrote:
> On Sat, Apr 27, 2019 at 11:20:20AM +0530, Vandana BN wrote:
>> This patch resolves coding style brace warning and constant on right warning.
>> WARNING: Comparisons should place the constant on the right side of the test
>> WARNING: braces {} are not necessary for single statement blocks
>>
>> Signed-off-by: Vandana BN <bnvandana at gmail.com>
> I need a "real name" here, and in the From: line. Unless I am mistaken
> and your last name is just "BN" and that is how you sign legal
> documents? If so, please let me know.
Vandana BN is my real and legal name :)
>
>
>> ------
>> v2- Edited commit message and subject
>> v3- Edited commit message
>> ------
>> ---
>> drivers/staging/rtl8723bs/core/rtw_debug.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/rtl8723bs/core/rtw_debug.c b/drivers/staging/rtl8723bs/core/rtw_debug.c
>> index 0de1e12a676e..3fb09ad45a67 100644
>> --- a/drivers/staging/rtl8723bs/core/rtw_debug.c
>> +++ b/drivers/staging/rtl8723bs/core/rtw_debug.c
>> @@ -1425,9 +1425,8 @@ int proc_get_btcoex_info(struct seq_file *m, void *v)
>> padapter = (struct adapter *)rtw_netdev_priv(dev);
>>
>> pbuf = rtw_zmalloc(bufsize);
>> - if (NULL == pbuf) {
>> + if (pbuf == NULL)
> checkpatch.pl was ok with this? It didn't say to write this line
> differently after you ran this patch through it?
>
> thanks,
>
> greg k-h
Thanks I had missed looking at CHECK .will resolve and send a new patch.
Regards,
Vandana.
^ permalink raw reply [flat|nested] 27+ messages in thread* [Linux-kernel-mentees] [PATCH v3] staging: rtl8723bs: Fix checkpatch.pl warnings
@ 2019-04-27 7:31 ` Greg KH
0 siblings, 0 replies; 27+ messages in thread
From: gregkh @ 2019-04-27 7:31 UTC (permalink / raw)
On Sat, Apr 27, 2019 at 12:54:08PM +0530, Vandana BN wrote:
>
> On 27/04/19 12:01 PM, Greg KH wrote:
> > On Sat, Apr 27, 2019 at 11:20:20AM +0530, Vandana BN wrote:
> >> This patch resolves coding style brace warning and constant on right warning.
> >> WARNING: Comparisons should place the constant on the right side of the test
> >> WARNING: braces {} are not necessary for single statement blocks
> >>
> >> Signed-off-by: Vandana BN <bnvandana at gmail.com>
> > I need a "real name" here, and in the From: line. Unless I am mistaken
> > and your last name is just "BN" and that is how you sign legal
> > documents? If so, please let me know.
> Vandana BN is my real and legal name :)
Ok, thanks, I had to ask :)
greg k-h
^ permalink raw reply [flat|nested] 27+ messages in thread* [Linux-kernel-mentees] [PATCH v3] staging: rtl8723bs: Fix checkpatch.pl warnings
@ 2019-04-27 7:31 ` Greg KH
0 siblings, 0 replies; 27+ messages in thread
From: Greg KH @ 2019-04-27 7:31 UTC (permalink / raw)
On Sat, Apr 27, 2019 at 12:54:08PM +0530, Vandana BN wrote:
>
> On 27/04/19 12:01 PM, Greg KH wrote:
> > On Sat, Apr 27, 2019 at 11:20:20AM +0530, Vandana BN wrote:
> >> This patch resolves coding style brace warning and constant on right warning.
> >> WARNING: Comparisons should place the constant on the right side of the test
> >> WARNING: braces {} are not necessary for single statement blocks
> >>
> >> Signed-off-by: Vandana BN <bnvandana at gmail.com>
> > I need a "real name" here, and in the From: line. Unless I am mistaken
> > and your last name is just "BN" and that is how you sign legal
> > documents? If so, please let me know.
> Vandana BN is my real and legal name :)
Ok, thanks, I had to ask :)
greg k-h
^ permalink raw reply [flat|nested] 27+ messages in thread
* [Linux-kernel-mentees] [PATCH v4] staging: rtl8723bs: Fix checkpatch.pl warnings
@ 2019-04-27 7:40 ` Vandana BN
0 siblings, 0 replies; 27+ messages in thread
From: bnvandana @ 2019-04-27 7:40 UTC (permalink / raw)
This patch resolves coding style brace warning and constant on right warning.
WARNING: Comparisons should place the constant on the right side of the test
WARNING: braces {} are not necessary for single statement blocks
CHECK: Comparison to NULL could be written "!pbuf"
Signed-off-by: Vandana BN <bnvandana at gmail.com>
------
v2- Edited commit message and subject
v3- Edited commit message
v4- changed NULL check to use !pbuf
------
---
drivers/staging/rtl8723bs/core/rtw_debug.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_debug.c b/drivers/staging/rtl8723bs/core/rtw_debug.c
index 0de1e12a676e..9f8446ccf771 100644
--- a/drivers/staging/rtl8723bs/core/rtw_debug.c
+++ b/drivers/staging/rtl8723bs/core/rtw_debug.c
@@ -1425,9 +1425,8 @@ int proc_get_btcoex_info(struct seq_file *m, void *v)
padapter = (struct adapter *)rtw_netdev_priv(dev);
pbuf = rtw_zmalloc(bufsize);
- if (NULL == pbuf) {
+ if (!pbuf)
return -ENOMEM;
- }
rtw_btcoex_DisplayBtCoexInfo(padapter, pbuf, bufsize);
--
2.17.1
^ permalink raw reply related [flat|nested] 27+ messages in thread* [Linux-kernel-mentees] [PATCH v4] staging: rtl8723bs: Fix checkpatch.pl warnings
@ 2019-04-27 7:40 ` Vandana BN
0 siblings, 0 replies; 27+ messages in thread
From: Vandana BN @ 2019-04-27 7:40 UTC (permalink / raw)
This patch resolves coding style brace warning and constant on right warning.
WARNING: Comparisons should place the constant on the right side of the test
WARNING: braces {} are not necessary for single statement blocks
CHECK: Comparison to NULL could be written "!pbuf"
Signed-off-by: Vandana BN <bnvandana at gmail.com>
------
v2- Edited commit message and subject
v3- Edited commit message
v4- changed NULL check to use !pbuf
------
---
drivers/staging/rtl8723bs/core/rtw_debug.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_debug.c b/drivers/staging/rtl8723bs/core/rtw_debug.c
index 0de1e12a676e..9f8446ccf771 100644
--- a/drivers/staging/rtl8723bs/core/rtw_debug.c
+++ b/drivers/staging/rtl8723bs/core/rtw_debug.c
@@ -1425,9 +1425,8 @@ int proc_get_btcoex_info(struct seq_file *m, void *v)
padapter = (struct adapter *)rtw_netdev_priv(dev);
pbuf = rtw_zmalloc(bufsize);
- if (NULL == pbuf) {
+ if (!pbuf)
return -ENOMEM;
- }
rtw_btcoex_DisplayBtCoexInfo(padapter, pbuf, bufsize);
--
2.17.1
^ permalink raw reply related [flat|nested] 27+ messages in thread
* [Linux-kernel-mentees] [PATCH v4] staging: rtl8723bs: Fix checkpatch.pl warnings
@ 2019-04-29 16:00 ` Vandana BN
0 siblings, 0 replies; 27+ messages in thread
From: bnvandana @ 2019-04-29 16:00 UTC (permalink / raw)
This patch resolves coding style brace warning and constant on right warning.
WARNING: Comparisons should place the constant on the right side of the test
WARNING: braces {} are not necessary for single statement blocks
CHECK: Comparison to NULL could be written "!pbuf"
Signed-off-by: Vandana BN <bnvandana at gmail.com>
------
v2- Edited commit message and subject
v3- Edited commit message
v4- changed NULL check to use !pbuf
------
---
drivers/staging/rtl8723bs/core/rtw_debug.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_debug.c b/drivers/staging/rtl8723bs/core/rtw_debug.c
index 0de1e12a676e..9f8446ccf771 100644
--- a/drivers/staging/rtl8723bs/core/rtw_debug.c
+++ b/drivers/staging/rtl8723bs/core/rtw_debug.c
@@ -1425,9 +1425,8 @@ int proc_get_btcoex_info(struct seq_file *m, void *v)
padapter = (struct adapter *)rtw_netdev_priv(dev);
pbuf = rtw_zmalloc(bufsize);
- if (NULL == pbuf) {
+ if (!pbuf)
return -ENOMEM;
- }
rtw_btcoex_DisplayBtCoexInfo(padapter, pbuf, bufsize);
--
2.17.1
^ permalink raw reply related [flat|nested] 27+ messages in thread* [PATCH v4] staging: rtl8723bs: Fix checkpatch.pl warnings
@ 2019-04-29 16:00 ` Vandana BN
0 siblings, 0 replies; 27+ messages in thread
From: Vandana BN @ 2019-04-29 16:00 UTC (permalink / raw)
To: gregkh, straube.linux, quytelda, colin.king, hdegoede, devel,
linux-kernel
Cc: skhan, linux-kernel-mentees, Vandana BN
This patch resolves coding style brace warning and constant on right warning.
WARNING: Comparisons should place the constant on the right side of the test
WARNING: braces {} are not necessary for single statement blocks
CHECK: Comparison to NULL could be written "!pbuf"
Signed-off-by: Vandana BN <bnvandana@gmail.com>
------
v2- Edited commit message and subject
v3- Edited commit message
v4- changed NULL check to use !pbuf
------
---
drivers/staging/rtl8723bs/core/rtw_debug.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_debug.c b/drivers/staging/rtl8723bs/core/rtw_debug.c
index 0de1e12a676e..9f8446ccf771 100644
--- a/drivers/staging/rtl8723bs/core/rtw_debug.c
+++ b/drivers/staging/rtl8723bs/core/rtw_debug.c
@@ -1425,9 +1425,8 @@ int proc_get_btcoex_info(struct seq_file *m, void *v)
padapter = (struct adapter *)rtw_netdev_priv(dev);
pbuf = rtw_zmalloc(bufsize);
- if (NULL == pbuf) {
+ if (!pbuf)
return -ENOMEM;
- }
rtw_btcoex_DisplayBtCoexInfo(padapter, pbuf, bufsize);
--
2.17.1
^ permalink raw reply related [flat|nested] 27+ messages in thread* [Linux-kernel-mentees] [PATCH v4] staging: rtl8723bs: Fix checkpatch.pl warnings
@ 2019-04-29 16:00 ` Vandana BN
0 siblings, 0 replies; 27+ messages in thread
From: Vandana BN @ 2019-04-29 16:00 UTC (permalink / raw)
This patch resolves coding style brace warning and constant on right warning.
WARNING: Comparisons should place the constant on the right side of the test
WARNING: braces {} are not necessary for single statement blocks
CHECK: Comparison to NULL could be written "!pbuf"
Signed-off-by: Vandana BN <bnvandana at gmail.com>
------
v2- Edited commit message and subject
v3- Edited commit message
v4- changed NULL check to use !pbuf
------
---
drivers/staging/rtl8723bs/core/rtw_debug.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_debug.c b/drivers/staging/rtl8723bs/core/rtw_debug.c
index 0de1e12a676e..9f8446ccf771 100644
--- a/drivers/staging/rtl8723bs/core/rtw_debug.c
+++ b/drivers/staging/rtl8723bs/core/rtw_debug.c
@@ -1425,9 +1425,8 @@ int proc_get_btcoex_info(struct seq_file *m, void *v)
padapter = (struct adapter *)rtw_netdev_priv(dev);
pbuf = rtw_zmalloc(bufsize);
- if (NULL == pbuf) {
+ if (!pbuf)
return -ENOMEM;
- }
rtw_btcoex_DisplayBtCoexInfo(padapter, pbuf, bufsize);
--
2.17.1
^ permalink raw reply related [flat|nested] 27+ messages in thread