From: Andrew Lunn <andrew@lunn.ch>
To: "Petr Štetiar" <ynezz@true.cz>
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Maxime Ripard <maxime.ripard@bootlin.com>,
Alban Bedel <albeu@free.fr>, Felix Fietkau <nbd@nbd.name>,
John Crispin <john@phrozen.org>
Subject: Re: [PATCH 1/4] of_net: Add NVMEM support to of_get_mac_address
Date: Sat, 27 Apr 2019 18:28:23 +0200 [thread overview]
Message-ID: <20190427162823.GA9816@lunn.ch> (raw)
In-Reply-To: <1556320002-26213-2-git-send-email-ynezz@true.cz>
> /**
> - * Search the device tree for the best MAC address to use. 'mac-address' is
> - * checked first, because that is supposed to contain to "most recent" MAC
> - * address. If that isn't set, then 'local-mac-address' is checked next,
> - * because that is the default address. If that isn't set, then the obsolete
> - * 'address' is checked, just in case we're using an old device tree.
> + * Search the device tree for the best MAC address to use. Check NVME first as
> + * it should contain the proper MAC address, then 'mac-address' is checked
> + * next, because that is supposed to contain to "most recent" MAC address. If
> + * that isn't set, then 'local-mac-address' is checked next, because that is
> + * the default address. If that isn't set, then the obsolete 'address' is
> + * checked, just in case we're using an old device tree.
Hi Petr
I'm not sure this is the correct order. I would actually put NVMEM
after mac-address and local-mac-address. These are well established
and used. We don't want to break existing boards with a new
property. By putting NVMEM later, in order to make it used, any
existing mac-address and local-mac-address need to be removed, making
the developers actually think about what they are doing.
Andrew
next prev parent reply other threads:[~2019-04-27 16:28 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-26 23:06 [PATCH 0/4] of_net: Add NVMEM support to of_get_mac_address Petr Štetiar
2019-04-26 23:06 ` Petr Štetiar
2019-04-26 23:06 ` [PATCH 1/4] " Petr Štetiar
2019-04-27 16:28 ` Andrew Lunn [this message]
2019-04-26 23:06 ` [PATCH 2/4] dt-bindings: doc: Reflect new NVMEM of_get_mac_address behaviour Petr Štetiar
2019-04-26 23:06 ` Petr Štetiar
2019-04-26 23:06 ` Petr Štetiar
2019-04-26 23:06 ` Petr Štetiar
2019-04-27 16:31 ` Andrew Lunn
2019-04-27 16:31 ` Andrew Lunn
2019-04-27 16:31 ` Andrew Lunn
2019-04-27 16:31 ` Andrew Lunn
2019-04-27 16:39 ` Andrew Lunn
2019-04-27 16:39 ` Andrew Lunn
2019-04-27 16:39 ` Andrew Lunn
2019-04-27 16:39 ` Andrew Lunn
2019-04-27 16:56 ` Florian Fainelli
2019-04-27 16:56 ` Florian Fainelli
2019-04-27 16:56 ` Florian Fainelli
2019-04-27 16:56 ` Florian Fainelli
2019-04-26 23:06 ` [PATCH 3/4] net: macb: Drop nvmem_get_mac_address usage Petr Štetiar
2019-04-27 16:44 ` Andrew Lunn
2019-04-26 23:06 ` [PATCH 4/4] net: davinci_emac: " Petr Štetiar
2019-04-27 16:54 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190427162823.GA9816@lunn.ch \
--to=andrew@lunn.ch \
--cc=albeu@free.fr \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=frowand.list@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=john@phrozen.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@bootlin.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=ynezz@true.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.