From: Andrew Lunn <andrew@lunn.ch>
To: "Petr Štetiar" <ynezz@true.cz>
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Heiko Stuebner <heiko@sntech.de>,
Fugang Duan <fugang.duan@nxp.com>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
Yisen Zhuang <yisen.zhuang@huawei.com>,
Salil Mehta <salil.mehta@huawei.com>,
Woojung Huh <woojung.huh@microchip.com>,
Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Kunihiko Hayashi <hayashi.kunihiko@socionext.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Jassi Brar <jaswinder.singh@linaro.org>
Subject: Re: [PATCH 2/4] dt-bindings: doc: Reflect new NVMEM of_get_mac_address behaviour
Date: Sat, 27 Apr 2019 18:39:23 +0200 [thread overview]
Message-ID: <20190427163923.GC9816@lunn.ch> (raw)
In-Reply-To: <1556320002-26213-3-git-send-email-ynezz@true.cz>
> diff --git a/Documentation/devicetree/bindings/net/macb.txt b/Documentation/devicetree/bindings/net/macb.txt
> index 8b80515..92c5642 100644
> --- a/Documentation/devicetree/bindings/net/macb.txt
> +++ b/Documentation/devicetree/bindings/net/macb.txt
> @@ -26,15 +26,15 @@ Required properties:
> Optional elements: 'tsu_clk'
> - clocks: Phandles to input clocks.
>
> -Optional properties:
> -- nvmem-cells: phandle, reference to an nvmem node for the MAC address
> -- nvmem-cell-names: string, should be "mac-address" if nvmem is to be used
> -
> Optional properties for PHY child node:
> - reset-gpios : Should specify the gpio for phy reset
> - magic-packet : If present, indicates that the hardware supports waking
> up via magic packet.
> - phy-handle : see ethernet.txt file in the same directory
> +- mac-address: See ethernet.txt in the same directory.
> +- local-mac-address: See ethernet.txt in the same directory.
> +- nvmem-cells: See ethernet.txt in the same directory.
> +- nvmem-cell-names: See ethernet.txt in the same directory.
This looks wrong. The MAC address is not a PHY property, so should not
be inside the PHY child node.
phy-handle is in the wrong place, but that is a separate problem.
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: "Petr Štetiar" <ynezz@true.cz>
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Heiko Stuebner <heiko@sntech.de>,
Fugang Duan <fugang.duan@nxp.com>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
Yisen Zhuang <yisen.zhuang@huawei.com>,
Salil Mehta <salil.mehta@huawei.com>,
Woojung Huh <woojung.huh@microchip.com>,
Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Kunihiko Hayashi <hayashi.kunihiko@socionext.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Jassi Brar <jaswinder.singh@linaro.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
Kalle Valo <kvalo@codeaurora.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Li Yang <leoyang.li@nxp.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Frank Rowand <frowand.list@gmail.com>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Maxime Ripard <maxime.ripard@bootlin.com>,
Alban Bedel <albeu@free.fr>,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-oxnas@groups.io,
linux-stm32@st-md-mailman.stormreply.com,
linux-wireless@vger.kernel.org,
linux-mediatek@lists.infradead.org,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 2/4] dt-bindings: doc: Reflect new NVMEM of_get_mac_address behaviour
Date: Sat, 27 Apr 2019 18:39:23 +0200 [thread overview]
Message-ID: <20190427163923.GC9816@lunn.ch> (raw)
In-Reply-To: <1556320002-26213-3-git-send-email-ynezz@true.cz>
> diff --git a/Documentation/devicetree/bindings/net/macb.txt b/Documentation/devicetree/bindings/net/macb.txt
> index 8b80515..92c5642 100644
> --- a/Documentation/devicetree/bindings/net/macb.txt
> +++ b/Documentation/devicetree/bindings/net/macb.txt
> @@ -26,15 +26,15 @@ Required properties:
> Optional elements: 'tsu_clk'
> - clocks: Phandles to input clocks.
>
> -Optional properties:
> -- nvmem-cells: phandle, reference to an nvmem node for the MAC address
> -- nvmem-cell-names: string, should be "mac-address" if nvmem is to be used
> -
> Optional properties for PHY child node:
> - reset-gpios : Should specify the gpio for phy reset
> - magic-packet : If present, indicates that the hardware supports waking
> up via magic packet.
> - phy-handle : see ethernet.txt file in the same directory
> +- mac-address: See ethernet.txt in the same directory.
> +- local-mac-address: See ethernet.txt in the same directory.
> +- nvmem-cells: See ethernet.txt in the same directory.
> +- nvmem-cell-names: See ethernet.txt in the same directory.
This looks wrong. The MAC address is not a PHY property, so should not
be inside the PHY child node.
phy-handle is in the wrong place, but that is a separate problem.
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: "Petr Štetiar" <ynezz@true.cz>
Cc: Mark Rutland <mark.rutland@arm.com>,
Heiko Stuebner <heiko@sntech.de>,
Kunihiko Hayashi <hayashi.kunihiko@socionext.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Maxime Ripard <maxime.ripard@bootlin.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Li Yang <leoyang.li@nxp.com>,
Frank Rowand <frowand.list@gmail.com>,
linux-stm32@st-md-mailman.stormreply.com,
Florian Fainelli <f.fainelli@gmail.com>,
linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Yisen Zhuang <yisen.zhuang@huawei.com>,
Vivien Didelot <vivien.didelot@gmail.com>,
Woojung Huh <woojung.huh@microchip.com>,
devicetree@vger.kernel.org,
Alexandre Torgue <alexandre.torgue@st.com>,
Jassi Brar <jaswinder.singh@linaro.org>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
Rob Herring <robh+dt@kernel.org>,
linux-mediatek@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>,
Kalle Valo <kvalo@codeaurora.org>,
Salil Mehta <salil.mehta@huawei.com>,
Fugang Duan <fugang.duan@nxp.com>,
netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org,
Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alban Bedel <albeu@free.fr>,
linux-oxnas@groups.io, linuxppc-dev@lists.ozlabs.org,
"David S. Miller" <davem@davemloft.net>,
Heiner Kallweit <hkallweit1@gmail.com>
Subject: Re: [PATCH 2/4] dt-bindings: doc: Reflect new NVMEM of_get_mac_address behaviour
Date: Sat, 27 Apr 2019 18:39:23 +0200 [thread overview]
Message-ID: <20190427163923.GC9816@lunn.ch> (raw)
In-Reply-To: <1556320002-26213-3-git-send-email-ynezz@true.cz>
> diff --git a/Documentation/devicetree/bindings/net/macb.txt b/Documentation/devicetree/bindings/net/macb.txt
> index 8b80515..92c5642 100644
> --- a/Documentation/devicetree/bindings/net/macb.txt
> +++ b/Documentation/devicetree/bindings/net/macb.txt
> @@ -26,15 +26,15 @@ Required properties:
> Optional elements: 'tsu_clk'
> - clocks: Phandles to input clocks.
>
> -Optional properties:
> -- nvmem-cells: phandle, reference to an nvmem node for the MAC address
> -- nvmem-cell-names: string, should be "mac-address" if nvmem is to be used
> -
> Optional properties for PHY child node:
> - reset-gpios : Should specify the gpio for phy reset
> - magic-packet : If present, indicates that the hardware supports waking
> up via magic packet.
> - phy-handle : see ethernet.txt file in the same directory
> +- mac-address: See ethernet.txt in the same directory.
> +- local-mac-address: See ethernet.txt in the same directory.
> +- nvmem-cells: See ethernet.txt in the same directory.
> +- nvmem-cell-names: See ethernet.txt in the same directory.
This looks wrong. The MAC address is not a PHY property, so should not
be inside the PHY child node.
phy-handle is in the wrong place, but that is a separate problem.
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: "Petr Štetiar" <ynezz@true.cz>
Cc: Mark Rutland <mark.rutland@arm.com>,
Heiko Stuebner <heiko@sntech.de>,
Kunihiko Hayashi <hayashi.kunihiko@socionext.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Maxime Ripard <maxime.ripard@bootlin.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Li Yang <leoyang.li@nxp.com>,
Frank Rowand <frowand.list@gmail.com>,
linux-stm32@st-md-mailman.stormreply.com,
Florian Fainelli <f.fainelli@gmail.com>,
linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Yisen Zhuang <yisen.zhuang@huawei.com>,
Vivien Didelot <vivien.didelot@gmail.com>,
Woojung Huh <woojung.huh@microchip.com>,
devicetree@vger.kernel.org,
Alexandre Torgue <alexandre.torgue@st.com>,
Jassi Brar <jaswinder.singh@linaro.org>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
Rob Herring <robh+dt@kernel.org>,
linux-mediatek@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>,
Kalle Valo <kvalo@codeaurora.org>,
Salil Mehta <salil.mehta@huawei.com>,
Fugang Duan <fugang.duan@nxp.com>,
netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org,
Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alban Bedel <albeu@free.fr>,
linux-oxnas@groups.io, linuxppc-dev@lists.ozlabs.org,
"David S. Miller" <davem@davemloft.net>,
Heiner Kallweit <hkallweit1@gmail.com>
Subject: Re: [PATCH 2/4] dt-bindings: doc: Reflect new NVMEM of_get_mac_address behaviour
Date: Sat, 27 Apr 2019 18:39:23 +0200 [thread overview]
Message-ID: <20190427163923.GC9816@lunn.ch> (raw)
In-Reply-To: <1556320002-26213-3-git-send-email-ynezz@true.cz>
> diff --git a/Documentation/devicetree/bindings/net/macb.txt b/Documentation/devicetree/bindings/net/macb.txt
> index 8b80515..92c5642 100644
> --- a/Documentation/devicetree/bindings/net/macb.txt
> +++ b/Documentation/devicetree/bindings/net/macb.txt
> @@ -26,15 +26,15 @@ Required properties:
> Optional elements: 'tsu_clk'
> - clocks: Phandles to input clocks.
>
> -Optional properties:
> -- nvmem-cells: phandle, reference to an nvmem node for the MAC address
> -- nvmem-cell-names: string, should be "mac-address" if nvmem is to be used
> -
> Optional properties for PHY child node:
> - reset-gpios : Should specify the gpio for phy reset
> - magic-packet : If present, indicates that the hardware supports waking
> up via magic packet.
> - phy-handle : see ethernet.txt file in the same directory
> +- mac-address: See ethernet.txt in the same directory.
> +- local-mac-address: See ethernet.txt in the same directory.
> +- nvmem-cells: See ethernet.txt in the same directory.
> +- nvmem-cell-names: See ethernet.txt in the same directory.
This looks wrong. The MAC address is not a PHY property, so should not
be inside the PHY child node.
phy-handle is in the wrong place, but that is a separate problem.
Andrew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-04-27 16:39 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-26 23:06 [PATCH 0/4] of_net: Add NVMEM support to of_get_mac_address Petr Štetiar
2019-04-26 23:06 ` Petr Štetiar
2019-04-26 23:06 ` [PATCH 1/4] " Petr Štetiar
2019-04-27 16:28 ` Andrew Lunn
2019-04-26 23:06 ` [PATCH 2/4] dt-bindings: doc: Reflect new NVMEM of_get_mac_address behaviour Petr Štetiar
2019-04-26 23:06 ` Petr Štetiar
2019-04-26 23:06 ` Petr Štetiar
2019-04-26 23:06 ` Petr Štetiar
2019-04-27 16:31 ` Andrew Lunn
2019-04-27 16:31 ` Andrew Lunn
2019-04-27 16:31 ` Andrew Lunn
2019-04-27 16:31 ` Andrew Lunn
2019-04-27 16:39 ` Andrew Lunn [this message]
2019-04-27 16:39 ` Andrew Lunn
2019-04-27 16:39 ` Andrew Lunn
2019-04-27 16:39 ` Andrew Lunn
2019-04-27 16:56 ` Florian Fainelli
2019-04-27 16:56 ` Florian Fainelli
2019-04-27 16:56 ` Florian Fainelli
2019-04-27 16:56 ` Florian Fainelli
2019-04-26 23:06 ` [PATCH 3/4] net: macb: Drop nvmem_get_mac_address usage Petr Štetiar
2019-04-27 16:44 ` Andrew Lunn
2019-04-26 23:06 ` [PATCH 4/4] net: davinci_emac: " Petr Štetiar
2019-04-27 16:54 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190427163923.GC9816@lunn.ch \
--to=andrew@lunn.ch \
--cc=UNGLinuxDriver@microchip.com \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=fugang.duan@nxp.com \
--cc=hayashi.kunihiko@socionext.com \
--cc=heiko@sntech.de \
--cc=jaswinder.singh@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=narmstrong@baylibre.com \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=salil.mehta@huawei.com \
--cc=vivien.didelot@gmail.com \
--cc=woojung.huh@microchip.com \
--cc=yamada.masahiro@socionext.com \
--cc=yisen.zhuang@huawei.com \
--cc=ynezz@true.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.