From: "Theodore Ts'o" <tytso@mit.edu>
To: Gabriel Krisman Bertazi <krisman@collabora.com>
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>,
Olaf Weber <olaf@sgi.com>,
Gabriel Krisman Bertazi <krisman@collabora.co.uk>,
Michal Marek <michal.lkml@markovi.net>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Colin King <colin.king@canonical.com>,
kernel-janitors@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][next] unicode: fix dereference of a potentially null pointer
Date: Sun, 28 Apr 2019 13:21:26 +0000 [thread overview]
Message-ID: <20190428132126.GB24089@mit.edu> (raw)
In-Reply-To: <85ef5mcrze.fsf@collabora.com>
On Sun, Apr 28, 2019 at 07:02:45AM -0400, Gabriel Krisman Bertazi wrote:
> > On Sat, Apr 27, 2019 at 7:22 AM Colin King <colin.king@canonical.com> wrote:
> >>
> >> From: Colin Ian King <colin.king@canonical.com>
> >>
> >> The pointer 'tree' is deferenced when assigning pointer 'trie', however
> >> trie is being null checked a few lines later, so it could potentially
> >> be null. Fix the potential null pointer dereference by only dereferencing
> >> it after it has been null checked.
> >>
> >> Addresses-Coverity: ("Dereference before null check")
> >> Fixes: b08fcacaaaf4 ("unicode: introduce UTF-8 character database")
> >> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
> Acked-by: Gabriel Krisman Bertazi <krisman@collabora.com>
>
> Ted, can you pick this up directly for now?
Ack, I've merged it into the the patch "unicode: introduce UTF-8
character database".
- Ted
WARNING: multiple messages have this Message-ID (diff)
From: "Theodore Ts'o" <tytso@mit.edu>
To: Gabriel Krisman Bertazi <krisman@collabora.com>
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>,
Olaf Weber <olaf@sgi.com>,
Gabriel Krisman Bertazi <krisman@collabora.co.uk>,
Michal Marek <michal.lkml@markovi.net>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Colin King <colin.king@canonical.com>,
kernel-janitors@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][next] unicode: fix dereference of a potentially null pointer
Date: Sun, 28 Apr 2019 09:21:26 -0400 [thread overview]
Message-ID: <20190428132126.GB24089@mit.edu> (raw)
In-Reply-To: <85ef5mcrze.fsf@collabora.com>
On Sun, Apr 28, 2019 at 07:02:45AM -0400, Gabriel Krisman Bertazi wrote:
> > On Sat, Apr 27, 2019 at 7:22 AM Colin King <colin.king@canonical.com> wrote:
> >>
> >> From: Colin Ian King <colin.king@canonical.com>
> >>
> >> The pointer 'tree' is deferenced when assigning pointer 'trie', however
> >> trie is being null checked a few lines later, so it could potentially
> >> be null. Fix the potential null pointer dereference by only dereferencing
> >> it after it has been null checked.
> >>
> >> Addresses-Coverity: ("Dereference before null check")
> >> Fixes: b08fcacaaaf4 ("unicode: introduce UTF-8 character database")
> >> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
> Acked-by: Gabriel Krisman Bertazi <krisman@collabora.com>
>
> Ted, can you pick this up directly for now?
Ack, I've merged it into the the patch "unicode: introduce UTF-8
character database".
- Ted
next prev parent reply other threads:[~2019-04-28 13:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-26 22:22 [PATCH][next] unicode: fix dereference of a potentially null pointer Colin King
2019-04-26 22:22 ` Colin King
2019-04-27 6:29 ` Masahiro Yamada
2019-04-27 6:29 ` Masahiro Yamada
2019-04-28 11:02 ` Gabriel Krisman Bertazi
2019-04-28 11:02 ` Gabriel Krisman Bertazi
2019-04-28 13:21 ` Theodore Ts'o [this message]
2019-04-28 13:21 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190428132126.GB24089@mit.edu \
--to=tytso@mit.edu \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=krisman@collabora.co.uk \
--cc=krisman@collabora.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=olaf@sgi.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.