From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Richard Weinberger <richard@nod.at>
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
Tudor Ambarus <Tudor.Ambarus@microchip.com>,
stable@vger.kernel.org, Marek Vasut <marek.vasut@gmail.com>,
Boris Brezillon <boris.brezillon@collabora.com>,
linux-mtd@lists.infradead.org,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
Daniel Mack <daniel@zonque.org>
Subject: Re: [PATCH v2] mtd: rawnand: marvell: Clean the controller state before each operation
Date: Mon, 29 Apr 2019 11:00:13 +0200 [thread overview]
Message-ID: <20190429110013.68984b7f@xps13> (raw)
In-Reply-To: <2565820.SR17ECleB1@blindfold>
Hi Richard,
Richard Weinberger <richard@nod.at> wrote on Sun, 28 Apr 2019 15:07:40
+0200:
> Daniel,
>
> Am Sonntag, 28. April 2019, 14:20:49 CEST schrieb Daniel Mack:
> > On 14/4/2019 10:50 AM, Boris Brezillon wrote:
> > > On Mon, 8 Apr 2019 10:31:45 +0200
> > > Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> > >
> > >> Since the migration of the driver to stop using the legacy
> > >> ->select_chip() hook, there is nothing deselecting the target anymore,
> > >> thus the selection is not forced at the next access. Ensure the ND_RUN
> > >> bit and the interrupts are always in a clean state.
> > >>
> > >> Cc: Daniel Mack <daniel@zonque.org>
> > >> Cc: stable@vger.kernel.org
> > >> Fixes: b25251414f6e00 ("mtd: rawnand: marvell: Stop implementing ->select_chip()")
> > >> Suggested-by: Boris Brezillon <boris.brezillon@collabora.com>
> > >> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> > >
> > > Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
> >
> > Has this one been queued in any tree yet?
>
> Isn't it visible in linux-next?
> I was about to send a final PR to Linus later today.
>
Indeed the patch is missing in 20190426 -next.
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Richard Weinberger <richard@nod.at>
Cc: Daniel Mack <daniel@zonque.org>,
Boris Brezillon <boris.brezillon@collabora.com>,
David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Marek Vasut <marek.vasut@gmail.com>,
Tudor Ambarus <Tudor.Ambarus@microchip.com>,
Vignesh Raghavendra <vigneshr@ti.com>,
linux-mtd@lists.infradead.org, stable@vger.kernel.org
Subject: Re: [PATCH v2] mtd: rawnand: marvell: Clean the controller state before each operation
Date: Mon, 29 Apr 2019 11:00:13 +0200 [thread overview]
Message-ID: <20190429110013.68984b7f@xps13> (raw)
In-Reply-To: <2565820.SR17ECleB1@blindfold>
Hi Richard,
Richard Weinberger <richard@nod.at> wrote on Sun, 28 Apr 2019 15:07:40
+0200:
> Daniel,
>
> Am Sonntag, 28. April 2019, 14:20:49 CEST schrieb Daniel Mack:
> > On 14/4/2019 10:50 AM, Boris Brezillon wrote:
> > > On Mon, 8 Apr 2019 10:31:45 +0200
> > > Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> > >
> > >> Since the migration of the driver to stop using the legacy
> > >> ->select_chip() hook, there is nothing deselecting the target anymore,
> > >> thus the selection is not forced at the next access. Ensure the ND_RUN
> > >> bit and the interrupts are always in a clean state.
> > >>
> > >> Cc: Daniel Mack <daniel@zonque.org>
> > >> Cc: stable@vger.kernel.org
> > >> Fixes: b25251414f6e00 ("mtd: rawnand: marvell: Stop implementing ->select_chip()")
> > >> Suggested-by: Boris Brezillon <boris.brezillon@collabora.com>
> > >> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> > >
> > > Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
> >
> > Has this one been queued in any tree yet?
>
> Isn't it visible in linux-next?
> I was about to send a final PR to Linus later today.
>
Indeed the patch is missing in 20190426 -next.
Thanks,
Miquèl
next prev parent reply other threads:[~2019-04-29 9:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-08 8:31 [PATCH v2] mtd: rawnand: marvell: Clean the controller state before each operation Miquel Raynal
2019-04-08 8:31 ` Miquel Raynal
2019-04-08 16:50 ` Daniel Mack
2019-04-08 16:50 ` Daniel Mack
2019-04-14 8:50 ` Boris Brezillon
2019-04-14 8:50 ` Boris Brezillon
2019-04-28 12:20 ` Daniel Mack
2019-04-28 12:20 ` Daniel Mack
2019-04-28 13:07 ` Richard Weinberger
2019-04-28 13:07 ` Richard Weinberger
2019-04-29 9:00 ` Miquel Raynal [this message]
2019-04-29 9:00 ` Miquel Raynal
2019-04-29 20:39 ` Richard Weinberger
2019-04-29 20:39 ` Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190429110013.68984b7f@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=Tudor.Ambarus@microchip.com \
--cc=boris.brezillon@collabora.com \
--cc=computersforpeace@gmail.com \
--cc=daniel@zonque.org \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=richard@nod.at \
--cc=stable@vger.kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.