From: Kalle Valo <kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
To: "Rafael J. Wysocki" <rjw-LthD3rsA81gm4RdzfppkhA@public.gmane.org>
Cc: Linux PM <linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Srinivas Pandruvada
<srinivas.pandruvada-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
ath10k-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Todd Brandt
<todd.e.brandt-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] ath10k: Drop WARN_ON()s that always trigger during system resume
Date: Mon, 29 Apr 2019 14:26:55 +0000 (UTC) [thread overview]
Message-ID: <20190429142655.81B08608D4@smtp.codeaurora.org> (raw)
In-Reply-To: <2884043.Jv1Mn93hE8-yvgW3jdyMHm1GS7QM15AGw@public.gmane.org>
"Rafael J. Wysocki" <rjw-LthD3rsA81gm4RdzfppkhA@public.gmane.org> wrote:
> ath10k_mac_vif_chan() always returns an error for the given vif
> during system-wide resume which reliably triggers two WARN_ON()s
> in ath10k_bss_info_changed() and they are not particularly
> useful in that code path, so drop them.
>
> Tested: QCA6174 hw3.2 PCI with WLAN.RM.2.0-00180-QCARMSWPZ-1
> Tested: QCA6174 hw3.2 SDIO with WLAN.RMH.4.4.1-00007-QCARMSWP-1
>
> Fixes: cd93b83ad927 ("ath10k: support for multicast rate control")
> Fixes: f279294e9ee2 ("ath10k: add support for configuring management packet rate")
> Cc: stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> Reviewed-by: Brian Norris <briannorris-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
> Tested-by: Brian Norris <briannorris-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
> Tested-by: Claire Chang <tientzu-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> Signed-off-by: Kalle Valo <kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
Patch applied to ath-current branch of ath.git, thanks.
9e80ad37f678 ath10k: Drop WARN_ON()s that always trigger during system resume
--
https://patchwork.kernel.org/patch/10837139/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Linux PM <linux-pm@vger.kernel.org>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
ath10k@lists.infradead.org, Todd Brandt <todd.e.brandt@intel.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ath10k: Drop WARN_ON()s that always trigger during system resume
Date: Mon, 29 Apr 2019 14:26:55 +0000 (UTC) [thread overview]
Message-ID: <20190429142655.81B08608D4@smtp.codeaurora.org> (raw)
Message-ID: <20190429142655.PAOZ-KUxaGVOwGqyG2kRfTFSvTdwdRWPFOT5F00Tf6o@z> (raw)
In-Reply-To: <2884043.Jv1Mn93hE8@aspire.rjw.lan>
"Rafael J. Wysocki" <rjw@rjwysocki.net> wrote:
> ath10k_mac_vif_chan() always returns an error for the given vif
> during system-wide resume which reliably triggers two WARN_ON()s
> in ath10k_bss_info_changed() and they are not particularly
> useful in that code path, so drop them.
>
> Tested: QCA6174 hw3.2 PCI with WLAN.RM.2.0-00180-QCARMSWPZ-1
> Tested: QCA6174 hw3.2 SDIO with WLAN.RMH.4.4.1-00007-QCARMSWP-1
>
> Fixes: cd93b83ad927 ("ath10k: support for multicast rate control")
> Fixes: f279294e9ee2 ("ath10k: add support for configuring management packet rate")
> Cc: stable@vger.kernel.org
> Reviewed-by: Brian Norris <briannorris@chromium.org>
> Tested-by: Brian Norris <briannorris@chromium.org>
> Tested-by: Claire Chang <tientzu@chromium.org>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-current branch of ath.git, thanks.
9e80ad37f678 ath10k: Drop WARN_ON()s that always trigger during system resume
--
https://patchwork.kernel.org/patch/10837139/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2019-04-29 14:26 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-03 17:24 [PATCH] ath10k: Drop WARN_ON()s that always trigger during system resume Rafael J. Wysocki
2019-03-03 17:24 ` Rafael J. Wysocki
2019-03-03 17:24 ` Rafael J. Wysocki
2019-04-03 19:57 ` Brian Norris
2019-04-03 19:57 ` Brian Norris
2019-04-03 19:57 ` Brian Norris
2019-04-03 21:44 ` Rafael J. Wysocki
2019-04-03 21:44 ` Rafael J. Wysocki
2019-04-03 21:44 ` Rafael J. Wysocki
2019-04-03 21:54 ` Brian Norris
2019-04-03 21:54 ` Brian Norris
2019-04-03 21:54 ` Brian Norris
2019-04-04 4:06 ` Kalle Valo
2019-04-04 4:06 ` Kalle Valo
2019-04-04 4:06 ` Kalle Valo
2019-04-04 8:28 ` Rafael J. Wysocki
2019-04-04 8:28 ` Rafael J. Wysocki
2019-04-04 8:28 ` Rafael J. Wysocki
2019-04-26 7:18 ` Kalle Valo
2019-04-26 7:18 ` Kalle Valo
2019-04-26 7:18 ` Kalle Valo
2019-04-29 8:48 ` Rafael J. Wysocki
2019-04-29 8:48 ` Rafael J. Wysocki
2019-04-29 8:48 ` Rafael J. Wysocki
2019-04-29 10:41 ` Claire Chang
2019-04-29 10:41 ` Claire Chang
2019-04-29 10:41 ` Claire Chang
2019-04-29 14:12 ` Kalle Valo
2019-04-29 14:12 ` Kalle Valo
2019-04-29 14:12 ` Kalle Valo
2019-04-29 14:10 ` Kalle Valo
2019-04-29 14:10 ` Kalle Valo
2019-04-29 14:10 ` Kalle Valo
2019-04-29 14:26 ` Kalle Valo
2019-04-29 14:26 ` Kalle Valo
[not found] ` <2884043.Jv1Mn93hE8-yvgW3jdyMHm1GS7QM15AGw@public.gmane.org>
2019-04-29 14:26 ` Kalle Valo [this message]
2019-04-29 14:26 ` Kalle Valo
-- strict thread matches above, loose matches on Subject: below --
2019-03-01 12:51 Rafael J. Wysocki
2019-03-01 12:51 ` Rafael J. Wysocki
2019-03-01 13:45 ` Kalle Valo
2019-03-01 13:45 ` Kalle Valo
2019-03-03 17:24 ` Rafael J. Wysocki
2019-03-03 17:24 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190429142655.81B08608D4@smtp.codeaurora.org \
--to=kvalo-sgv2jx0feol9jmxxk+q4oq@public.gmane.org \
--cc=ath10k-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=rjw-LthD3rsA81gm4RdzfppkhA@public.gmane.org \
--cc=srinivas.pandruvada-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=todd.e.brandt-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.