From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Enrico Weigelt, metux IT consult" <lkml@metux.net>
Cc: sparclinux@vger.kernel.org, lorenzo.pieralisi@arm.com,
linux-ia64@vger.kernel.org, linux-serial@vger.kernel.org,
andrew@aj.id.au, gregkh@linuxfoundation.org,
sudeep.holla@arm.com, liviu.dudau@arm.com,
linux-kernel@vger.kernel.org, vz@mleia.com,
linux@prisktech.co.nz, linuxppc-dev@lists.ozlabs.org,
khilman@baylibre.com, macro@linux-mips.org,
slemieux.tyco@gmail.com, matthias.bgg@gmail.com,
jacmet@sunsite.dk, linux-amlogic@lists.infradead.org,
linux-mips@vger.kernel.org, "Enrico Weigelt,
metux IT consult" <info@metux.net>,
davem@davemloft.net
Subject: Re: [PATCH 36/41] drivers: tty: serial: 8250: store mmio resource size in port struct
Date: Mon, 29 Apr 2019 18:39:49 +0300 [thread overview]
Message-ID: <20190429153949.GV9224@smile.fi.intel.com> (raw)
In-Reply-To: <4bab941a-c2f2-7f1c-9bc2-86c63f171c25@metux.net>
On Mon, Apr 29, 2019 at 04:55:05PM +0200, Enrico Weigelt, metux IT consult wrote:
> On 28.04.19 17:18, Andy Shevchenko wrote:
> > On Sat, Apr 27, 2019 at 02:52:17PM +0200, Enrico Weigelt, metux IT consult wrote:
> >> - int ret = 0;
> >
> > This and Co is a separate change that can be done in its own patch.
>
> I don't really understand :(
> Do you mean the splitting off the retval part from the rest ?
You do two things here: one of them is removing ret and other relative changes.
This should be split to a separate patch.
> > You may increase readability by introducing temporary variables
> >
> > ... mapbase = port->mapbase;
> > ... mapsize = port->mapsize;
> > ...
> > port->membase = ioremap_nocache(mapbase, mapsize);
> > ...
>
> Is that really necessary ? Maybe it's just my personal taste, but I
> don't feel the more more verbose one is really easier to read.
Up to Greg. For me it's harder to read all those port-> in several parameters.
--
With Best Regards,
Andy Shevchenko
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Enrico Weigelt, metux IT consult" <lkml@metux.net>
Cc: "Enrico Weigelt, metux IT consult" <info@metux.net>,
linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
andrew@aj.id.au, macro@linux-mips.org, vz@mleia.com,
slemieux.tyco@gmail.com, khilman@baylibre.com,
liviu.dudau@arm.com, sudeep.holla@arm.com,
lorenzo.pieralisi@arm.com, davem@davemloft.net,
jacmet@sunsite.dk, linux@prisktech.co.nz, matthias.bgg@gmail.com,
linux-mips@vger.kernel.org, linux-serial@vger.kernel.org,
linux-ia64@vger.kernel.org, linux-amlogic@lists.infradead.org,
linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org
Subject: Re: [PATCH 36/41] drivers: tty: serial: 8250: store mmio resource size in port struct
Date: Mon, 29 Apr 2019 15:39:49 +0000 [thread overview]
Message-ID: <20190429153949.GV9224@smile.fi.intel.com> (raw)
In-Reply-To: <4bab941a-c2f2-7f1c-9bc2-86c63f171c25@metux.net>
On Mon, Apr 29, 2019 at 04:55:05PM +0200, Enrico Weigelt, metux IT consult wrote:
> On 28.04.19 17:18, Andy Shevchenko wrote:
> > On Sat, Apr 27, 2019 at 02:52:17PM +0200, Enrico Weigelt, metux IT consult wrote:
> >> - int ret = 0;
> >
> > This and Co is a separate change that can be done in its own patch.
>
> I don't really understand :(
> Do you mean the splitting off the retval part from the rest ?
You do two things here: one of them is removing ret and other relative changes.
This should be split to a separate patch.
> > You may increase readability by introducing temporary variables
> >
> > ... mapbase = port->mapbase;
> > ... mapsize = port->mapsize;
> > ...
> > port->membase = ioremap_nocache(mapbase, mapsize);
> > ...
>
> Is that really necessary ? Maybe it's just my personal taste, but I
> don't feel the more more verbose one is really easier to read.
Up to Greg. For me it's harder to read all those port-> in several parameters.
--
With Best Regards,
Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Enrico Weigelt, metux IT consult" <lkml@metux.net>
Cc: "Enrico Weigelt, metux IT consult" <info@metux.net>,
linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
andrew@aj.id.au, macro@linux-mips.org, vz@mleia.com,
slemieux.tyco@gmail.com, khilman@baylibre.com,
liviu.dudau@arm.com, sudeep.holla@arm.com,
lorenzo.pieralisi@arm.com, davem@davemloft.net,
jacmet@sunsite.dk, linux@prisktech.co.nz, matthias.bgg@gmail.com,
linux-mips@vger.kernel.org, linux-serial@vger.kernel.org,
linux-ia64@vger.kernel.org, linux-amlogic@lists.infradead.org,
linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org
Subject: Re: [PATCH 36/41] drivers: tty: serial: 8250: store mmio resource size in port struct
Date: Mon, 29 Apr 2019 18:39:49 +0300 [thread overview]
Message-ID: <20190429153949.GV9224@smile.fi.intel.com> (raw)
In-Reply-To: <4bab941a-c2f2-7f1c-9bc2-86c63f171c25@metux.net>
On Mon, Apr 29, 2019 at 04:55:05PM +0200, Enrico Weigelt, metux IT consult wrote:
> On 28.04.19 17:18, Andy Shevchenko wrote:
> > On Sat, Apr 27, 2019 at 02:52:17PM +0200, Enrico Weigelt, metux IT consult wrote:
> >> - int ret = 0;
> >
> > This and Co is a separate change that can be done in its own patch.
>
> I don't really understand :(
> Do you mean the splitting off the retval part from the rest ?
You do two things here: one of them is removing ret and other relative changes.
This should be split to a separate patch.
> > You may increase readability by introducing temporary variables
> >
> > ... mapbase = port->mapbase;
> > ... mapsize = port->mapsize;
> > ...
> > port->membase = ioremap_nocache(mapbase, mapsize);
> > ...
>
> Is that really necessary ? Maybe it's just my personal taste, but I
> don't feel the more more verbose one is really easier to read.
Up to Greg. For me it's harder to read all those port-> in several parameters.
--
With Best Regards,
Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Enrico Weigelt, metux IT consult" <lkml@metux.net>
Cc: sparclinux@vger.kernel.org, lorenzo.pieralisi@arm.com,
linux-ia64@vger.kernel.org, linux-serial@vger.kernel.org,
andrew@aj.id.au, gregkh@linuxfoundation.org,
sudeep.holla@arm.com, liviu.dudau@arm.com,
linux-kernel@vger.kernel.org, vz@mleia.com,
linux@prisktech.co.nz, linuxppc-dev@lists.ozlabs.org,
khilman@baylibre.com, macro@linux-mips.org,
slemieux.tyco@gmail.com, matthias.bgg@gmail.com,
jacmet@sunsite.dk, linux-amlogic@lists.infradead.org,
linux-mips@vger.kernel.org, "Enrico Weigelt,
metux IT consult" <info@metux.net>,
davem@davemloft.net
Subject: Re: [PATCH 36/41] drivers: tty: serial: 8250: store mmio resource size in port struct
Date: Mon, 29 Apr 2019 18:39:49 +0300 [thread overview]
Message-ID: <20190429153949.GV9224@smile.fi.intel.com> (raw)
In-Reply-To: <4bab941a-c2f2-7f1c-9bc2-86c63f171c25@metux.net>
On Mon, Apr 29, 2019 at 04:55:05PM +0200, Enrico Weigelt, metux IT consult wrote:
> On 28.04.19 17:18, Andy Shevchenko wrote:
> > On Sat, Apr 27, 2019 at 02:52:17PM +0200, Enrico Weigelt, metux IT consult wrote:
> >> - int ret = 0;
> >
> > This and Co is a separate change that can be done in its own patch.
>
> I don't really understand :(
> Do you mean the splitting off the retval part from the rest ?
You do two things here: one of them is removing ret and other relative changes.
This should be split to a separate patch.
> > You may increase readability by introducing temporary variables
> >
> > ... mapbase = port->mapbase;
> > ... mapsize = port->mapsize;
> > ...
> > port->membase = ioremap_nocache(mapbase, mapsize);
> > ...
>
> Is that really necessary ? Maybe it's just my personal taste, but I
> don't feel the more more verbose one is really easier to read.
Up to Greg. For me it's harder to read all those port-> in several parameters.
--
With Best Regards,
Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Enrico Weigelt, metux IT consult" <lkml@metux.net>
Cc: sparclinux@vger.kernel.org, lorenzo.pieralisi@arm.com,
linux-ia64@vger.kernel.org, linux-serial@vger.kernel.org,
andrew@aj.id.au, gregkh@linuxfoundation.org,
sudeep.holla@arm.com, liviu.dudau@arm.com,
linux-kernel@vger.kernel.org, vz@mleia.com,
linux@prisktech.co.nz, linuxppc-dev@lists.ozlabs.org,
khilman@baylibre.com, macro@linux-mips.org,
slemieux.tyco@gmail.com, matthias.bgg@gmail.com,
jacmet@sunsite.dk, linux-amlogic@lists.infradead.org,
linux-mips@vger.kernel.org, "Enrico Weigelt,
metux IT consult" <info@metux.net>,
davem@davemloft.net
Subject: Re: [PATCH 36/41] drivers: tty: serial: 8250: store mmio resource size in port struct
Date: Mon, 29 Apr 2019 15:39:49 +0000 [thread overview]
Message-ID: <20190429153949.GV9224@smile.fi.intel.com> (raw)
In-Reply-To: <4bab941a-c2f2-7f1c-9bc2-86c63f171c25@metux.net>
On Mon, Apr 29, 2019 at 04:55:05PM +0200, Enrico Weigelt, metux IT consult wrote:
> On 28.04.19 17:18, Andy Shevchenko wrote:
> > On Sat, Apr 27, 2019 at 02:52:17PM +0200, Enrico Weigelt, metux IT consult wrote:
> >> - int ret = 0;
> >
> > This and Co is a separate change that can be done in its own patch.
>
> I don't really understand :(
> Do you mean the splitting off the retval part from the rest ?
You do two things here: one of them is removing ret and other relative changes.
This should be split to a separate patch.
> > You may increase readability by introducing temporary variables
> >
> > ... mapbase = port->mapbase;
> > ... mapsize = port->mapsize;
> > ...
> > port->membase = ioremap_nocache(mapbase, mapsize);
> > ...
>
> Is that really necessary ? Maybe it's just my personal taste, but I
> don't feel the more more verbose one is really easier to read.
Up to Greg. For me it's harder to read all those port-> in several parameters.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2019-04-29 15:42 UTC|newest]
Thread overview: 421+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-27 12:51 serial drivers polishing Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` [PATCH 01/41] drivers: tty: serial: dz: use dev_err() instead of printk() Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` Enrico Weigelt, metux IT consult
2019-04-27 13:29 ` Greg KH
2019-04-27 13:29 ` Greg KH
2019-04-27 13:29 ` Greg KH
2019-04-27 13:29 ` Greg KH
2019-04-27 13:29 ` Greg KH
2019-04-29 14:11 ` Enrico Weigelt, metux IT consult
2019-04-29 14:11 ` Enrico Weigelt, metux IT consult
2019-04-29 14:11 ` Enrico Weigelt, metux IT consult
2019-04-29 14:11 ` Enrico Weigelt, metux IT consult
2019-04-29 14:11 ` Enrico Weigelt, metux IT consult
2019-04-29 14:23 ` Greg KH
2019-04-29 14:23 ` Greg KH
2019-04-29 14:23 ` Greg KH
2019-04-29 14:23 ` Greg KH
2019-04-29 14:23 ` Greg KH
2019-04-27 13:31 ` Greg KH
2019-04-27 13:31 ` Greg KH
2019-04-27 13:31 ` Greg KH
2019-04-27 13:31 ` Greg KH
2019-04-27 13:31 ` Greg KH
2019-04-29 7:23 ` Enrico Weigelt, metux IT consult
2019-04-29 7:23 ` Enrico Weigelt, metux IT consult
2019-04-29 7:23 ` Enrico Weigelt, metux IT consult
2019-04-29 7:23 ` Enrico Weigelt, metux IT consult
2019-04-29 7:23 ` Enrico Weigelt, metux IT consult
2019-04-29 12:37 ` Enrico Weigelt, metux IT consult
2019-04-29 12:37 ` Enrico Weigelt, metux IT consult
2019-04-29 12:37 ` Enrico Weigelt, metux IT consult
2019-04-29 12:37 ` Enrico Weigelt, metux IT consult
2019-04-29 12:37 ` Enrico Weigelt, metux IT consult
2019-04-29 13:12 ` Greg KH
2019-04-29 13:12 ` Greg KH
2019-04-29 13:12 ` Greg KH
2019-04-29 13:12 ` Greg KH
2019-04-29 13:12 ` Greg KH
2019-05-01 2:20 ` Maciej W. Rozycki
2019-05-01 2:20 ` Maciej W. Rozycki
2019-05-01 2:20 ` Maciej W. Rozycki
2019-05-01 2:20 ` Maciej W. Rozycki
2019-05-01 2:20 ` Maciej W. Rozycki
2019-04-27 12:51 ` [PATCH 02/41] drivers: tty: serial: dz: include <linux/io.h> instead of <asm/io.h> Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` [PATCH 03/41] drivers: tty: serial: dz: fix missing parentheses Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` [PATCH 04/41] drivers: tty: serial: dz: fix use fix bare 'unsigned' Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` [PATCH 05/41] drivers: tty: serial: dz: use pr_info() instead of incomplete printk() Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` Enrico Weigelt, metux IT consult
2019-04-27 13:30 ` Greg KH
2019-04-27 13:30 ` Greg KH
2019-04-27 13:30 ` Greg KH
2019-04-27 13:30 ` Greg KH
2019-04-27 13:30 ` Greg KH
2019-04-27 12:51 ` [PATCH 06/41] drivers: tty: serial: sb1250-duart: use dev_err() instead of printk() Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` Enrico Weigelt, metux IT consult
2019-05-01 2:29 ` Maciej W. Rozycki
2019-05-01 2:29 ` Maciej W. Rozycki
2019-05-01 2:29 ` Maciej W. Rozycki
2019-05-01 2:29 ` Maciej W. Rozycki
2019-05-01 2:29 ` Maciej W. Rozycki
2019-04-27 12:51 ` [PATCH 07/41] drivers: tty: serial: sb1250-duart: include <linux/io.h> instead of <asm/io.h> Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` [PATCH 08/41] drivers: tty: serial: sb1250-duart: fix checkpatch warning on printk() Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` [PATCH 09/41] drivers: tty: serial: sb1250-duart: fill mapsize and use it Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` [PATCH 10/41] drivers: tty: serial: sb1250-duart: fix missing parentheses Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` Enrico Weigelt, metux IT consult
2019-04-27 13:32 ` Greg KH
2019-04-27 13:32 ` Greg KH
2019-04-27 13:32 ` Greg KH
2019-04-27 13:32 ` Greg KH
2019-04-27 13:32 ` Greg KH
2019-04-27 12:51 ` [PATCH 11/41] drivers: tty: serial: sb1250-duart: fix formatting error Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` [PATCH 12/41] drivers: tty: serial: uartlite: use dev_dbg() instead of pr_debug() Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` Enrico Weigelt, metux IT consult
2019-04-29 15:26 ` Peter Korsgaard
2019-04-29 15:26 ` Peter Korsgaard
2019-04-29 15:26 ` Peter Korsgaard
2019-04-29 15:26 ` Peter Korsgaard
2019-04-29 15:26 ` Peter Korsgaard
2019-04-29 15:26 ` Peter Korsgaard
2019-04-27 12:51 ` [PATCH 13/41] drivers: tty: serial: uartlite: fill mapsize and use it Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` Enrico Weigelt, metux IT consult
2019-04-29 15:19 ` Peter Korsgaard
2019-04-29 15:19 ` Peter Korsgaard
2019-04-29 15:19 ` Peter Korsgaard
2019-04-29 15:19 ` Peter Korsgaard
2019-04-29 15:19 ` Peter Korsgaard
2019-04-29 15:19 ` Peter Korsgaard
2019-04-29 18:26 ` Enrico Weigelt, metux IT consult
2019-04-29 18:26 ` Enrico Weigelt, metux IT consult
2019-04-29 18:26 ` Enrico Weigelt, metux IT consult
2019-04-29 18:26 ` Enrico Weigelt, metux IT consult
2019-04-29 18:26 ` Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` [PATCH 14/41] drivers: tty: serial: uartlite: remove unnecessary braces Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` Enrico Weigelt, metux IT consult
2019-04-29 15:20 ` Peter Korsgaard
2019-04-29 15:20 ` Peter Korsgaard
2019-04-29 15:20 ` Peter Korsgaard
2019-04-29 15:20 ` Peter Korsgaard
2019-04-29 15:20 ` Peter Korsgaard
2019-04-29 15:20 ` Peter Korsgaard
2019-04-27 12:51 ` [PATCH 15/41] drivers: tty: serial: uartlite: fix use fix bare 'unsigned' Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` Enrico Weigelt, metux IT consult
2019-04-29 15:21 ` Peter Korsgaard
2019-04-29 15:21 ` Peter Korsgaard
2019-04-29 15:21 ` Peter Korsgaard
2019-04-29 15:21 ` Peter Korsgaard
2019-04-29 15:21 ` Peter Korsgaard
2019-04-29 15:21 ` Peter Korsgaard
2019-04-27 12:51 ` [PATCH 16/41] drivers: tty: serial: uartlite: fix overlong lines Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` Enrico Weigelt, metux IT consult
2019-04-29 15:24 ` Peter Korsgaard
2019-04-29 15:24 ` Peter Korsgaard
2019-04-29 15:24 ` Peter Korsgaard
2019-04-29 15:24 ` Peter Korsgaard
2019-04-29 15:24 ` Peter Korsgaard
2019-04-29 15:24 ` Peter Korsgaard
2019-04-27 12:51 ` [PATCH 17/41] drivers: tty: serial: apbuart: fix logging calls Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` [PATCH 18/41] drivers: tty: serial: apbuart: use dev_info() instead of printk() Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` Enrico Weigelt, metux IT consult
2019-04-27 12:51 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` [PATCH 19/41] drivers: tty: serial: apbuart: fix code formatting Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` [PATCH 20/41] drivers: tty: serial: cpm_uart: use dev_err()/dev_warn() instead of printk() Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-29 16:02 ` Christophe Leroy
2019-04-29 16:02 ` Christophe Leroy
2019-04-29 16:02 ` Christophe Leroy
2019-04-29 16:02 ` Christophe Leroy
2019-04-29 16:02 ` Christophe Leroy
2019-04-27 12:52 ` [PATCH 21/41] drivers: tty: serial: cpm_uart: fix includes Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-29 16:02 ` Christophe Leroy
2019-04-29 16:02 ` Christophe Leroy
2019-04-29 16:02 ` Christophe Leroy
2019-04-29 16:02 ` Christophe Leroy
2019-04-29 16:02 ` Christophe Leroy
2019-04-27 12:52 ` [PATCH 22/41] drivers: tty: serial: cpm_uart: fix logging calls Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-29 15:59 ` Christophe Leroy
2019-04-29 15:59 ` Christophe Leroy
2019-04-29 15:59 ` Christophe Leroy
2019-04-29 15:59 ` Christophe Leroy
2019-04-29 15:59 ` Christophe Leroy
2019-04-29 16:20 ` Enrico Weigelt, metux IT consult
2019-04-29 16:20 ` Enrico Weigelt, metux IT consult
2019-04-29 16:20 ` Enrico Weigelt, metux IT consult
2019-04-29 16:20 ` Enrico Weigelt, metux IT consult
2019-04-29 16:20 ` Enrico Weigelt, metux IT consult
2019-04-30 14:10 ` Andy Shevchenko
2019-04-30 14:10 ` Andy Shevchenko
2019-04-30 14:10 ` Andy Shevchenko
2019-04-30 14:10 ` Andy Shevchenko
2019-04-30 14:10 ` Andy Shevchenko
2019-04-27 12:52 ` [PATCH 23/41] drivers: tty: serial: cpm_uart: fix styling issues Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-29 15:56 ` Christophe Leroy
2019-04-29 15:56 ` Christophe Leroy
2019-04-29 15:56 ` Christophe Leroy
2019-04-29 15:56 ` Christophe Leroy
2019-04-29 15:56 ` Christophe Leroy
2019-04-27 12:52 ` [PATCH 24/41] drivers: tty: serial: timbuart: use dev_err() instead of printk() Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` [PATCH 25/41] drivers: tty: serial: timbuart: fix formatting issues Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` [PATCH 26/41] drivers: tty: serial: sunzilog: use dev_info() instead of printk() Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` [PATCH 27/41] drivers: tty: serial: sunzilog: fix formatting issues Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` [PATCH 28/41] drivers: tty: serial: sunzilog: fix includes Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` [PATCH 29/41] drivers: tty: serial: sunzilog: cleanup logging Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` [PATCH 30/41] drivers: tty: serial: ioc4_serial: use dev_warn() instead of printk() Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` [PATCH 31/41] drivers: tty: serial: ioc4_serial: use pr_*() " Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` [PATCH 32/41] drivers: tty: serial: 21285: define's for address/size, use mapsize field Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` [PATCH 33/41] drivers: tty: serial: zs: use dev_err() instead of printk() Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` [PATCH 34/41] drivers: tty: serial: zs: fill mapsize and use it Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` [PATCH 35/41] drivers: tty: serial: 8250: add mapsize to platform data Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-29 7:06 ` Esben Haabendal
2019-04-29 7:06 ` Esben Haabendal
2019-04-29 7:06 ` Esben Haabendal
2019-04-29 7:06 ` Esben Haabendal
2019-04-29 7:06 ` Esben Haabendal
2019-04-29 7:06 ` Esben Haabendal
2019-04-27 12:52 ` [PATCH 36/41] drivers: tty: serial: 8250: store mmio resource size in port struct Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-28 15:18 ` Andy Shevchenko
2019-04-28 15:18 ` Andy Shevchenko
2019-04-28 15:18 ` Andy Shevchenko
2019-04-28 15:18 ` Andy Shevchenko
2019-04-28 15:18 ` Andy Shevchenko
2019-04-29 14:55 ` Enrico Weigelt, metux IT consult
2019-04-29 14:55 ` Enrico Weigelt, metux IT consult
2019-04-29 14:55 ` Enrico Weigelt, metux IT consult
2019-04-29 14:55 ` Enrico Weigelt, metux IT consult
2019-04-29 14:55 ` Enrico Weigelt, metux IT consult
2019-04-29 15:39 ` Andy Shevchenko [this message]
2019-04-29 15:39 ` Andy Shevchenko
2019-04-29 15:39 ` Andy Shevchenko
2019-04-29 15:39 ` Andy Shevchenko
2019-04-29 15:39 ` Andy Shevchenko
2019-04-27 12:52 ` [PATCH 37/41] drivers: tty: serial: 8250: simplify io resource size computation Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 13:03 ` John Paul Adrian Glaubitz
2019-04-27 13:03 ` John Paul Adrian Glaubitz
2019-04-27 13:03 ` John Paul Adrian Glaubitz
2019-04-27 13:03 ` John Paul Adrian Glaubitz
2019-04-27 13:03 ` John Paul Adrian Glaubitz
2019-04-29 15:58 ` Enrico Weigelt, metux IT consult
2019-04-29 15:58 ` Enrico Weigelt, metux IT consult
2019-04-29 15:58 ` Enrico Weigelt, metux IT consult
2019-04-29 15:58 ` Enrico Weigelt, metux IT consult
2019-04-29 15:58 ` Enrico Weigelt, metux IT consult
2019-04-28 15:21 ` Andy Shevchenko
2019-04-28 15:21 ` Andy Shevchenko
2019-04-28 15:21 ` Andy Shevchenko
2019-04-28 15:21 ` Andy Shevchenko
2019-04-28 15:21 ` Andy Shevchenko
2019-04-29 6:48 ` Enrico Weigelt, metux IT consult
2019-04-29 6:48 ` Enrico Weigelt, metux IT consult
2019-04-29 6:48 ` Enrico Weigelt, metux IT consult
2019-04-29 6:48 ` Enrico Weigelt, metux IT consult
2019-04-29 6:48 ` Enrico Weigelt, metux IT consult
2019-04-29 13:19 ` Andy Shevchenko
2019-04-29 13:19 ` Andy Shevchenko
2019-04-29 13:19 ` Andy Shevchenko
2019-04-29 13:19 ` Andy Shevchenko
2019-04-29 13:19 ` Andy Shevchenko
2019-04-27 12:52 ` [PATCH 38/41] drivers: tty: serial: xilinx_uartps: fill mapsize and use it Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` [PATCH 39/41] drivers: tty: serial: pmac_zilog: " Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` [PATCH 40/41] drivers: tty: serial: helper for setting mmio range Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-28 15:39 ` Andy Shevchenko
2019-04-28 15:39 ` Andy Shevchenko
2019-04-28 15:39 ` Andy Shevchenko
2019-04-28 15:39 ` Andy Shevchenko
2019-04-28 15:39 ` Andy Shevchenko
2019-04-29 10:12 ` Enrico Weigelt, metux IT consult
2019-04-29 10:12 ` Enrico Weigelt, metux IT consult
2019-04-29 10:12 ` Enrico Weigelt, metux IT consult
2019-04-29 10:12 ` Enrico Weigelt, metux IT consult
2019-04-29 10:12 ` Enrico Weigelt, metux IT consult
2019-04-29 13:28 ` Andy Shevchenko
2019-04-29 13:28 ` Andy Shevchenko
2019-04-29 13:28 ` Andy Shevchenko
2019-04-29 13:28 ` Andy Shevchenko
2019-04-29 13:28 ` Andy Shevchenko
2019-04-29 6:57 ` Esben Haabendal
2019-04-29 6:57 ` Esben Haabendal
2019-04-29 6:57 ` Esben Haabendal
2019-04-29 6:57 ` Esben Haabendal
2019-04-29 6:57 ` Esben Haabendal
2019-04-29 6:57 ` Esben Haabendal
2019-04-29 7:03 ` Esben Haabendal
2019-04-29 7:03 ` Esben Haabendal
2019-04-29 7:03 ` Esben Haabendal
2019-04-29 7:03 ` Esben Haabendal
2019-04-29 7:03 ` Esben Haabendal
2019-04-29 7:03 ` Esben Haabendal
2019-04-29 9:43 ` Enrico Weigelt, metux IT consult
2019-04-29 9:43 ` Enrico Weigelt, metux IT consult
2019-04-29 9:43 ` Enrico Weigelt, metux IT consult
2019-04-29 9:43 ` Enrico Weigelt, metux IT consult
2019-04-29 9:43 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` [PATCH 41/41] drivers: tty: serial: lpc32xx_hs: fill mapsize and use it Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-27 12:52 ` Enrico Weigelt, metux IT consult
2019-04-30 20:52 ` Vladimir Zapolskiy
2019-04-30 20:52 ` Vladimir Zapolskiy
2019-04-30 20:52 ` Vladimir Zapolskiy
2019-04-30 20:52 ` Vladimir Zapolskiy
2019-04-30 20:52 ` Vladimir Zapolskiy
2019-04-29 16:16 ` serial drivers polishing Christophe Leroy
2019-04-29 16:16 ` Christophe Leroy
2019-04-29 16:16 ` Christophe Leroy
2019-04-29 16:50 ` Enrico Weigelt, metux IT consult
2019-04-29 16:50 ` Enrico Weigelt, metux IT consult
2019-04-29 16:50 ` Enrico Weigelt, metux IT consult
2019-04-29 16:50 ` Enrico Weigelt, metux IT consult
2019-04-29 16:50 ` Enrico Weigelt, metux IT consult
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190429153949.GV9224@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=andrew@aj.id.au \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=info@metux.net \
--cc=jacmet@sunsite.dk \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@prisktech.co.nz \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=liviu.dudau@arm.com \
--cc=lkml@metux.net \
--cc=lorenzo.pieralisi@arm.com \
--cc=macro@linux-mips.org \
--cc=matthias.bgg@gmail.com \
--cc=slemieux.tyco@gmail.com \
--cc=sparclinux@vger.kernel.org \
--cc=sudeep.holla@arm.com \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.