* [PATCH] drm/i915: Fix bug for GeminiLake
@ 2019-04-29 15:10 Stanislav Lisovskiy
2019-04-29 15:37 ` ✗ Fi.CI.SPARSE: warning for " Patchwork
` (4 more replies)
0 siblings, 5 replies; 7+ messages in thread
From: Stanislav Lisovskiy @ 2019-04-29 15:10 UTC (permalink / raw)
To: intel-gfx; +Cc: ville.syrjala, martin.peres
When CDCLK is as low as 79200, picture gets
unstable, while DSI and DE pll values were
confirmed to be correct.
Limiting to 158400 as agreed with Ville.
Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
---
drivers/gpu/drm/i915/intel_cdclk.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_cdclk.c b/drivers/gpu/drm/i915/intel_cdclk.c
index ae40a8679314..2b23f8500362 100644
--- a/drivers/gpu/drm/i915/intel_cdclk.c
+++ b/drivers/gpu/drm/i915/intel_cdclk.c
@@ -2277,6 +2277,15 @@ int intel_crtc_compute_min_cdclk(const struct intel_crtc_state *crtc_state)
IS_VALLEYVIEW(dev_priv))
min_cdclk = max(320000, min_cdclk);
+ /*
+ * On Geminilake once the CDCLK gets as low as 79200
+ * picture gets unstable, despite that values are
+ * correct for DSI PLL and DE PLL.
+ */
+ if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_DSI) &&
+ IS_GEMINILAKE(dev_priv))
+ min_cdclk = max(158400, min_cdclk);
+
if (min_cdclk > dev_priv->max_cdclk_freq) {
DRM_DEBUG_KMS("required cdclk (%d kHz) exceeds max (%d kHz)\n",
min_cdclk, dev_priv->max_cdclk_freq);
--
2.17.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 7+ messages in thread* ✗ Fi.CI.SPARSE: warning for drm/i915: Fix bug for GeminiLake 2019-04-29 15:10 [PATCH] drm/i915: Fix bug for GeminiLake Stanislav Lisovskiy @ 2019-04-29 15:37 ` Patchwork 2019-04-29 15:55 ` [PATCH] " Ville Syrjälä ` (3 subsequent siblings) 4 siblings, 0 replies; 7+ messages in thread From: Patchwork @ 2019-04-29 15:37 UTC (permalink / raw) To: Stanislav Lisovskiy; +Cc: intel-gfx == Series Details == Series: drm/i915: Fix bug for GeminiLake URL : https://patchwork.freedesktop.org/series/60065/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: Fix bug for GeminiLake -O:drivers/gpu/drm/i915/intel_cdclk.c:2266:29: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_cdclk.c:2266:29: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_cdclk.c:2275:29: warning: expression using sizeof(void) _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drm/i915: Fix bug for GeminiLake 2019-04-29 15:10 [PATCH] drm/i915: Fix bug for GeminiLake Stanislav Lisovskiy 2019-04-29 15:37 ` ✗ Fi.CI.SPARSE: warning for " Patchwork @ 2019-04-29 15:55 ` Ville Syrjälä 2019-04-29 16:35 ` ✓ Fi.CI.BAT: success for " Patchwork ` (2 subsequent siblings) 4 siblings, 0 replies; 7+ messages in thread From: Ville Syrjälä @ 2019-04-29 15:55 UTC (permalink / raw) To: Stanislav Lisovskiy; +Cc: intel-gfx, ville.syrjala, martin.peres On Mon, Apr 29, 2019 at 06:10:23PM +0300, Stanislav Lisovskiy wrote: > "drm/i915: Fix bug for GeminiLake" The patch subject is rather generic. With that improved Acked-by: Ville Syrjälä <ville.syrjala@linux.intel.com> since we didn't managed to come up with a good explanation for the failure. PS. you cc:ed me on the wrong address > When CDCLK is as low as 79200, picture gets > unstable, while DSI and DE pll values were > confirmed to be correct. > Limiting to 158400 as agreed with Ville. > > Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com> > --- > drivers/gpu/drm/i915/intel_cdclk.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/drivers/gpu/drm/i915/intel_cdclk.c b/drivers/gpu/drm/i915/intel_cdclk.c > index ae40a8679314..2b23f8500362 100644 > --- a/drivers/gpu/drm/i915/intel_cdclk.c > +++ b/drivers/gpu/drm/i915/intel_cdclk.c > @@ -2277,6 +2277,15 @@ int intel_crtc_compute_min_cdclk(const struct intel_crtc_state *crtc_state) > IS_VALLEYVIEW(dev_priv)) > min_cdclk = max(320000, min_cdclk); > > + /* > + * On Geminilake once the CDCLK gets as low as 79200 > + * picture gets unstable, despite that values are > + * correct for DSI PLL and DE PLL. > + */ > + if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_DSI) && > + IS_GEMINILAKE(dev_priv)) > + min_cdclk = max(158400, min_cdclk); > + > if (min_cdclk > dev_priv->max_cdclk_freq) { > DRM_DEBUG_KMS("required cdclk (%d kHz) exceeds max (%d kHz)\n", > min_cdclk, dev_priv->max_cdclk_freq); > -- > 2.17.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 7+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: Fix bug for GeminiLake 2019-04-29 15:10 [PATCH] drm/i915: Fix bug for GeminiLake Stanislav Lisovskiy 2019-04-29 15:37 ` ✗ Fi.CI.SPARSE: warning for " Patchwork 2019-04-29 15:55 ` [PATCH] " Ville Syrjälä @ 2019-04-29 16:35 ` Patchwork 2019-04-29 21:03 ` ✗ Fi.CI.IGT: failure " Patchwork 2019-04-30 6:41 ` [PATCH] " Maarten Lankhorst 4 siblings, 0 replies; 7+ messages in thread From: Patchwork @ 2019-04-29 16:35 UTC (permalink / raw) To: Stanislav Lisovskiy; +Cc: intel-gfx == Series Details == Series: drm/i915: Fix bug for GeminiLake URL : https://patchwork.freedesktop.org/series/60065/ State : success == Summary == CI Bug Log - changes from CI_DRM_6012 -> Patchwork_12897 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://patchwork.freedesktop.org/api/1.0/series/60065/revisions/1/mbox/ Possible new issues ------------------- Here are the unknown changes that may have been introduced in Patchwork_12897: ### IGT changes ### #### Suppressed #### The following results come from untrusted machines, tests, or statuses. They do not affect the overall result. * igt@kms_chamelium@dp-hpd-fast: - {fi-cml-u2}: [FAIL][1] ([fdo#108767]) -> [SKIP][2] +8 similar issues [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/fi-cml-u2/igt@kms_chamelium@dp-hpd-fast.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12897/fi-cml-u2/igt@kms_chamelium@dp-hpd-fast.html Known issues ------------ Here are the changes found in Patchwork_12897 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@kms_chamelium@dp-crc-fast: - fi-kbl-7500u: [PASS][3] -> [DMESG-WARN][4] ([fdo#103841]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/fi-kbl-7500u/igt@kms_chamelium@dp-crc-fast.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12897/fi-kbl-7500u/igt@kms_chamelium@dp-crc-fast.html * igt@kms_flip@basic-flip-vs-wf_vblank: - fi-pnv-d510: [PASS][5] -> [FAIL][6] ([fdo#100368]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/fi-pnv-d510/igt@kms_flip@basic-flip-vs-wf_vblank.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12897/fi-pnv-d510/igt@kms_flip@basic-flip-vs-wf_vblank.html * igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence: - fi-byt-clapper: [PASS][7] -> [FAIL][8] ([fdo#103191]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/fi-byt-clapper/igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12897/fi-byt-clapper/igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence.html #### Possible fixes #### * igt@amdgpu/amd_basic@userptr: - fi-kbl-8809g: [DMESG-WARN][9] ([fdo#108965]) -> [PASS][10] [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/fi-kbl-8809g/igt@amdgpu/amd_basic@userptr.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12897/fi-kbl-8809g/igt@amdgpu/amd_basic@userptr.html * igt@gem_exec_basic@basic-blt: - {fi-icl-u2}: [INCOMPLETE][11] ([fdo#107713] / [fdo#110246]) -> [PASS][12] [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/fi-icl-u2/igt@gem_exec_basic@basic-blt.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12897/fi-icl-u2/igt@gem_exec_basic@basic-blt.html * igt@gem_exec_fence@basic-busy-default: - fi-icl-y: [INCOMPLETE][13] ([fdo#107713]) -> [PASS][14] [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/fi-icl-y/igt@gem_exec_fence@basic-busy-default.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12897/fi-icl-y/igt@gem_exec_fence@basic-busy-default.html * igt@kms_frontbuffer_tracking@basic: - fi-glk-dsi: [FAIL][15] ([fdo#103167]) -> [PASS][16] [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/fi-glk-dsi/igt@kms_frontbuffer_tracking@basic.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12897/fi-glk-dsi/igt@kms_frontbuffer_tracking@basic.html * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a: - fi-byt-clapper: [FAIL][17] ([fdo#103191]) -> [PASS][18] +1 similar issue [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/fi-byt-clapper/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12897/fi-byt-clapper/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#100368]: https://bugs.freedesktop.org/show_bug.cgi?id=100368 [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167 [fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191 [fdo#103841]: https://bugs.freedesktop.org/show_bug.cgi?id=103841 [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713 [fdo#108767]: https://bugs.freedesktop.org/show_bug.cgi?id=108767 [fdo#108965]: https://bugs.freedesktop.org/show_bug.cgi?id=108965 [fdo#110246]: https://bugs.freedesktop.org/show_bug.cgi?id=110246 Participating hosts (52 -> 45) ------------------------------ Missing (7): fi-kbl-soraka fi-ilk-m540 fi-bsw-n3050 fi-byt-squawks fi-bsw-cyan fi-hsw-4770 fi-bdw-samus Build changes ------------- * Linux: CI_DRM_6012 -> Patchwork_12897 CI_DRM_6012: e4882f199157e3fb73d1791352931096f6ecfcfd @ git://anongit.freedesktop.org/gfx-ci/linux IGT_4968: caed251990f35bfe45368f803980071a73e36315 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_12897: fe434945fabb8f57dab85ae95063f7049c911971 @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == fe434945fabb drm/i915: Fix bug for GeminiLake == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12897/ _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 7+ messages in thread
* ✗ Fi.CI.IGT: failure for drm/i915: Fix bug for GeminiLake 2019-04-29 15:10 [PATCH] drm/i915: Fix bug for GeminiLake Stanislav Lisovskiy ` (2 preceding siblings ...) 2019-04-29 16:35 ` ✓ Fi.CI.BAT: success for " Patchwork @ 2019-04-29 21:03 ` Patchwork 2019-04-30 6:41 ` [PATCH] " Maarten Lankhorst 4 siblings, 0 replies; 7+ messages in thread From: Patchwork @ 2019-04-29 21:03 UTC (permalink / raw) To: Stanislav Lisovskiy; +Cc: intel-gfx == Series Details == Series: drm/i915: Fix bug for GeminiLake URL : https://patchwork.freedesktop.org/series/60065/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6012_full -> Patchwork_12897_full ==================================================== Summary ------- **FAILURE** Serious unknown changes coming with Patchwork_12897_full absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_12897_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. Possible new issues ------------------- Here are the unknown changes that may have been introduced in Patchwork_12897_full: ### IGT changes ### #### Possible regressions #### * igt@gem_ctx_switch@basic-all-heavy: - shard-skl: NOTRUN -> [INCOMPLETE][1] +3 similar issues [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12897/shard-skl10/igt@gem_ctx_switch@basic-all-heavy.html * igt@gem_eio@banned: - shard-glk: [PASS][2] -> [FAIL][3] [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-glk2/igt@gem_eio@banned.html [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12897/shard-glk5/igt@gem_eio@banned.html * igt@gem_exec_schedule@smoketest-all: - shard-skl: [PASS][4] -> [INCOMPLETE][5] +10 similar issues [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-skl2/igt@gem_exec_schedule@smoketest-all.html [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12897/shard-skl7/igt@gem_exec_schedule@smoketest-all.html #### Warnings #### * igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-shrfb-draw-mmap-gtt: - shard-skl: [SKIP][6] ([fdo#109271]) -> [INCOMPLETE][7] +1 similar issue [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-skl6/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-shrfb-draw-mmap-gtt.html [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12897/shard-skl5/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-shrfb-draw-mmap-gtt.html Known issues ------------ Here are the changes found in Patchwork_12897_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@debugfs_test@read_all_entries_display_off: - shard-skl: [PASS][8] -> [INCOMPLETE][9] ([fdo#104108]) [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-skl7/igt@debugfs_test@read_all_entries_display_off.html [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12897/shard-skl4/igt@debugfs_test@read_all_entries_display_off.html * igt@gem_cpu_reloc@forked: - shard-iclb: [PASS][10] -> [INCOMPLETE][11] ([fdo#107713] / [fdo#109100]) [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-iclb4/igt@gem_cpu_reloc@forked.html [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12897/shard-iclb3/igt@gem_cpu_reloc@forked.html * igt@i915_selftest@mock_requests: - shard-snb: [PASS][12] -> [INCOMPLETE][13] ([fdo#105411]) [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-snb6/igt@i915_selftest@mock_requests.html [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12897/shard-snb5/igt@i915_selftest@mock_requests.html * igt@i915_suspend@sysfs-reader: - shard-apl: [PASS][14] -> [DMESG-WARN][15] ([fdo#108566]) +4 similar issues [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-apl1/igt@i915_suspend@sysfs-reader.html [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12897/shard-apl6/igt@i915_suspend@sysfs-reader.html * igt@kms_flip@2x-flip-vs-expired-vblank-interruptible: - shard-glk: [PASS][16] -> [FAIL][17] ([fdo#105363]) [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-glk4/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12897/shard-glk1/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html * igt@kms_flip@flip-vs-suspend: - shard-hsw: [PASS][18] -> [INCOMPLETE][19] ([fdo#103540]) +2 similar issues [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-hsw5/igt@kms_flip@flip-vs-suspend.html [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12897/shard-hsw5/igt@kms_flip@flip-vs-suspend.html * igt@kms_flip@nonexisting-fb-interruptible: - shard-iclb: [PASS][20] -> [INCOMPLETE][21] ([fdo#107713]) [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-iclb3/igt@kms_flip@nonexisting-fb-interruptible.html [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12897/shard-iclb1/igt@kms_flip@nonexisting-fb-interruptible.html * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt: - shard-iclb: [PASS][22] -> [FAIL][23] ([fdo#103167]) +3 similar issues [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-iclb7/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt.html [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12897/shard-iclb7/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt.html * igt@kms_frontbuffer_tracking@fbc-suspend: - shard-apl: [PASS][24] -> [INCOMPLETE][25] ([fdo#103927]) [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-apl1/igt@kms_frontbuffer_tracking@fbc-suspend.html [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12897/shard-apl3/igt@kms_frontbuffer_tracking@fbc-suspend.html * igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-render: - shard-skl: [PASS][26] -> [INCOMPLETE][27] ([fdo#106978]) +1 similar issue [26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-skl1/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-render.html [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12897/shard-skl10/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-render.html * igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min: - shard-skl: [PASS][28] -> [FAIL][29] ([fdo#108145]) [28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-skl5/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12897/shard-skl5/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html * igt@kms_plane_lowres@pipe-a-tiling-y: - shard-iclb: [PASS][30] -> [FAIL][31] ([fdo#103166]) [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-iclb5/igt@kms_plane_lowres@pipe-a-tiling-y.html [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12897/shard-iclb1/igt@kms_plane_lowres@pipe-a-tiling-y.html * igt@kms_psr@psr2_cursor_mmap_cpu: - shard-iclb: [PASS][32] -> [SKIP][33] ([fdo#109441]) +1 similar issue [32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12897/shard-iclb4/igt@kms_psr@psr2_cursor_mmap_cpu.html * igt@kms_setmode@basic: - shard-kbl: [PASS][34] -> [FAIL][35] ([fdo#99912]) [34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-kbl5/igt@kms_setmode@basic.html [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12897/shard-kbl7/igt@kms_setmode@basic.html * igt@kms_vblank@pipe-a-ts-continuation-idle-hang: - shard-glk: [PASS][36] -> [INCOMPLETE][37] ([fdo#103359] / [k.org#198133]) +6 similar issues [36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-glk6/igt@kms_vblank@pipe-a-ts-continuation-idle-hang.html [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12897/shard-glk9/igt@kms_vblank@pipe-a-ts-continuation-idle-hang.html #### Possible fixes #### * igt@i915_suspend@debugfs-reader: - shard-apl: [DMESG-WARN][38] ([fdo#108566]) -> [PASS][39] +6 similar issues [38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-apl3/igt@i915_suspend@debugfs-reader.html [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12897/shard-apl3/igt@i915_suspend@debugfs-reader.html * igt@kms_cursor_crc@cursor-64x64-suspend: - shard-skl: [INCOMPLETE][40] ([fdo#104108]) -> [PASS][41] [40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-skl3/igt@kms_cursor_crc@cursor-64x64-suspend.html [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12897/shard-skl2/igt@kms_cursor_crc@cursor-64x64-suspend.html * igt@kms_cursor_legacy@2x-nonblocking-modeset-vs-cursor-atomic: - shard-glk: [FAIL][42] ([fdo#106509] / [fdo#107409]) -> [PASS][43] [42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-glk2/igt@kms_cursor_legacy@2x-nonblocking-modeset-vs-cursor-atomic.html [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12897/shard-glk5/igt@kms_cursor_legacy@2x-nonblocking-modeset-vs-cursor-atomic.html * igt@kms_flip@flip-vs-expired-vblank-interruptible: - shard-skl: [FAIL][44] ([fdo#105363]) -> [PASS][45] [44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-skl3/igt@kms_flip@flip-vs-expired-vblank-interruptible.html [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12897/shard-skl9/igt@kms_flip@flip-vs-expired-vblank-interruptible.html * igt@kms_flip@modeset-vs-vblank-race: - shard-glk: [FAIL][46] ([fdo#103060]) -> [PASS][47] [46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-glk8/igt@kms_flip@modeset-vs-vblank-race.html [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12897/shard-glk2/igt@kms_flip@modeset-vs-vblank-race.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw: - shard-iclb: [FAIL][48] ([fdo#103167]) -> [PASS][49] +4 similar issues [48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-iclb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw.html [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12897/shard-iclb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw.html * igt@kms_frontbuffer_tracking@fbcpsr-suspend: - shard-skl: [INCOMPLETE][50] ([fdo#104108] / [fdo#106978]) -> [PASS][51] [50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-skl7/igt@kms_frontbuffer_tracking@fbcpsr-suspend.html [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12897/shard-skl3/igt@kms_frontbuffer_tracking@fbcpsr-suspend.html - shard-iclb: [INCOMPLETE][52] ([fdo#106978] / [fdo#107713]) -> [PASS][53] [52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-iclb4/igt@kms_frontbuffer_tracking@fbcpsr-suspend.html [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12897/shard-iclb3/igt@kms_frontbuffer_tracking@fbcpsr-suspend.html * igt@kms_psr2_su@frontbuffer: - shard-iclb: [SKIP][54] ([fdo#109642]) -> [PASS][55] [54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-iclb8/igt@kms_psr2_su@frontbuffer.html [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12897/shard-iclb2/igt@kms_psr2_su@frontbuffer.html * igt@kms_psr@psr2_sprite_mmap_gtt: - shard-iclb: [SKIP][56] ([fdo#109441]) -> [PASS][57] +2 similar issues [56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-iclb3/igt@kms_psr@psr2_sprite_mmap_gtt.html [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12897/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_gtt.html * igt@kms_setmode@basic: - shard-apl: [FAIL][58] ([fdo#99912]) -> [PASS][59] [58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-apl5/igt@kms_setmode@basic.html [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12897/shard-apl8/igt@kms_setmode@basic.html * igt@tools_test@tools_test: - shard-iclb: [SKIP][60] ([fdo#109352]) -> [PASS][61] [60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-iclb8/igt@tools_test@tools_test.html [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12897/shard-iclb6/igt@tools_test@tools_test.html #### Warnings #### * igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-pwrite: - shard-skl: [FAIL][62] ([fdo#108040]) -> [FAIL][63] ([fdo#103167]) [62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-skl10/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-pwrite.html [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12897/shard-skl7/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-pwrite.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#103060]: https://bugs.freedesktop.org/show_bug.cgi?id=103060 [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166 [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167 [fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359 [fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540 [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927 [fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108 [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363 [fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411 [fdo#106509]: https://bugs.freedesktop.org/show_bug.cgi?id=106509 [fdo#106978]: https://bugs.freedesktop.org/show_bug.cgi?id=106978 [fdo#107409]: https://bugs.freedesktop.org/show_bug.cgi?id=107409 [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713 [fdo#108040]: https://bugs.freedesktop.org/show_bug.cgi?id=108040 [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566 [fdo#109100]: https://bugs.freedesktop.org/show_bug.cgi?id=109100 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109352]: https://bugs.freedesktop.org/show_bug.cgi?id=109352 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642 [fdo#110519]: https://bugs.freedesktop.org/show_bug.cgi?id=110519 [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912 [k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133 Participating hosts (10 -> 10) ------------------------------ No changes in participating hosts Build changes ------------- * Linux: CI_DRM_6012 -> Patchwork_12897 CI_DRM_6012: e4882f199157e3fb73d1791352931096f6ecfcfd @ git://anongit.freedesktop.org/gfx-ci/linux IGT_4968: caed251990f35bfe45368f803980071a73e36315 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_12897: fe434945fabb8f57dab85ae95063f7049c911971 @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12897/ _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drm/i915: Fix bug for GeminiLake 2019-04-29 15:10 [PATCH] drm/i915: Fix bug for GeminiLake Stanislav Lisovskiy ` (3 preceding siblings ...) 2019-04-29 21:03 ` ✗ Fi.CI.IGT: failure " Patchwork @ 2019-04-30 6:41 ` Maarten Lankhorst 2019-04-30 6:56 ` Lisovskiy, Stanislav 4 siblings, 1 reply; 7+ messages in thread From: Maarten Lankhorst @ 2019-04-30 6:41 UTC (permalink / raw) To: Stanislav Lisovskiy, intel-gfx; +Cc: ville.syrjala, martin.peres Op 29-04-2019 om 17:10 schreef Stanislav Lisovskiy: > When CDCLK is as low as 79200, picture gets > unstable, while DSI and DE pll values were > confirmed to be correct. > Limiting to 158400 as agreed with Ville. > > Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com> > --- > drivers/gpu/drm/i915/intel_cdclk.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/drivers/gpu/drm/i915/intel_cdclk.c b/drivers/gpu/drm/i915/intel_cdclk.c > index ae40a8679314..2b23f8500362 100644 > --- a/drivers/gpu/drm/i915/intel_cdclk.c > +++ b/drivers/gpu/drm/i915/intel_cdclk.c > @@ -2277,6 +2277,15 @@ int intel_crtc_compute_min_cdclk(const struct intel_crtc_state *crtc_state) > IS_VALLEYVIEW(dev_priv)) > min_cdclk = max(320000, min_cdclk); > > + /* > + * On Geminilake once the CDCLK gets as low as 79200 > + * picture gets unstable, despite that values are > + * correct for DSI PLL and DE PLL. > + */ > + if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_DSI) && > + IS_GEMINILAKE(dev_priv)) > + min_cdclk = max(158400, min_cdclk); > + > if (min_cdclk > dev_priv->max_cdclk_freq) { > DRM_DEBUG_KMS("required cdclk (%d kHz) exceeds max (%d kHz)\n", > min_cdclk, dev_priv->max_cdclk_freq); Hey, With a bit of love to the commit's first line, I think this patch looks good. :) Is this behavior documented somewhere? ~Maarten _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drm/i915: Fix bug for GeminiLake 2019-04-30 6:41 ` [PATCH] " Maarten Lankhorst @ 2019-04-30 6:56 ` Lisovskiy, Stanislav 0 siblings, 0 replies; 7+ messages in thread From: Lisovskiy, Stanislav @ 2019-04-30 6:56 UTC (permalink / raw) To: Maarten Lankhorst, intel-gfx@lists.freedesktop.org Cc: Syrjala, Ville, Peres, Martin > > + /* > + * On Geminilake once the CDCLK gets as low as 79200 > + * picture gets unstable, despite that values are > + * correct for DSI PLL and DE PLL. > + */ > + if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_DSI) && > + IS_GEMINILAKE(dev_priv)) > + min_cdclk = max(158400, min_cdclk); > + > if (min_cdclk > dev_priv->max_cdclk_freq) { > DRM_DEBUG_KMS("required cdclk (%d kHz) exceeds max (%d kHz)\n", > min_cdclk, dev_priv->max_cdclk_freq); >Hey, >With a bit of love to the commit's first line, I think this patch looks good. :) Yes, I've just sent a v2 version with a bit more detailed explanation :) >Is this behavior documented somewhere? In fact no, there are similar issues with VLV so I actually simply used similar approach. We were first suspecting that we get to high DSI PLL dividers due to agressive rounding, so tried different ratios, however no success. Also CDCLK clocking seems to be correct, however display looks like complete garbage. Any other CDCLK clock > 79200 for DSI solves the issue. -Stanislav >~Maarten _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-04-30 6:56 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-04-29 15:10 [PATCH] drm/i915: Fix bug for GeminiLake Stanislav Lisovskiy 2019-04-29 15:37 ` ✗ Fi.CI.SPARSE: warning for " Patchwork 2019-04-29 15:55 ` [PATCH] " Ville Syrjälä 2019-04-29 16:35 ` ✓ Fi.CI.BAT: success for " Patchwork 2019-04-29 21:03 ` ✗ Fi.CI.IGT: failure " Patchwork 2019-04-30 6:41 ` [PATCH] " Maarten Lankhorst 2019-04-30 6:56 ` Lisovskiy, Stanislav
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.