From: Rob Herring <robh@kernel.org>
Cc: robh+dt@kernel.org, jacek.anaszewski@gmail.com, pavel@ucw.cz,
lee.jones@linaro.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
Dan Murphy <dmurphy@ti.com>
Subject: Re: [PATCH v2 4/6] dt-bindings: ti-lmu: Modify dt bindings for the LM3697
Date: Mon, 29 Apr 2019 12:34:20 -0500 [thread overview]
Message-ID: <20190429173420.GA1273@bogus> (raw)
In-Reply-To: <20190405142855.3969-4-dmurphy@ti.com>
On Fri, 5 Apr 2019 09:28:53 -0500, Dan Murphy wrote:
> The LM3697 is a single function LED driver. The single function LED
> driver needs to reside in the LED directory as a dedicated LED driver
> and not as a MFD device. The device does have common brightness and ramp
> features and those can be accomodated by a TI LMU framework.
>
> The LM3697 dt binding needs to be moved from the ti-lmu.txt and a dedicated
> LED dt binding needs to be added. The new LM3697 LED dt binding will then
> reside in the Documentation/devicetree/bindings/leds directory and follow the
> current LED and general bindings guidelines.
>
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> ---
>
> v2 - Made changes to reference ti,brightness-resolution to the ti-lmu.txt -
> https://lore.kernel.org/patchwork/patch/1054501/
>
> .../devicetree/bindings/leds/leds-lm3697.txt | 73 +++++++++++++++++++
> .../devicetree/bindings/mfd/ti-lmu.txt | 27 +------
> 2 files changed, 74 insertions(+), 26 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/leds/leds-lm3697.txt
>
Reviewed-by: Rob Herring <robh@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Dan Murphy <dmurphy@ti.com>
Cc: robh+dt@kernel.org, jacek.anaszewski@gmail.com, pavel@ucw.cz,
lee.jones@linaro.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
Dan Murphy <dmurphy@ti.com>
Subject: Re: [PATCH v2 4/6] dt-bindings: ti-lmu: Modify dt bindings for the LM3697
Date: Mon, 29 Apr 2019 12:34:20 -0500 [thread overview]
Message-ID: <20190429173420.GA1273@bogus> (raw)
In-Reply-To: <20190405142855.3969-4-dmurphy@ti.com>
On Fri, 5 Apr 2019 09:28:53 -0500, Dan Murphy wrote:
> The LM3697 is a single function LED driver. The single function LED
> driver needs to reside in the LED directory as a dedicated LED driver
> and not as a MFD device. The device does have common brightness and ramp
> features and those can be accomodated by a TI LMU framework.
>
> The LM3697 dt binding needs to be moved from the ti-lmu.txt and a dedicated
> LED dt binding needs to be added. The new LM3697 LED dt binding will then
> reside in the Documentation/devicetree/bindings/leds directory and follow the
> current LED and general bindings guidelines.
>
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> ---
>
> v2 - Made changes to reference ti,brightness-resolution to the ti-lmu.txt -
> https://lore.kernel.org/patchwork/patch/1054501/
>
> .../devicetree/bindings/leds/leds-lm3697.txt | 73 +++++++++++++++++++
> .../devicetree/bindings/mfd/ti-lmu.txt | 27 +------
> 2 files changed, 74 insertions(+), 26 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/leds/leds-lm3697.txt
>
Reviewed-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2019-04-29 17:34 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-05 14:28 [PATCH v2 1/6] dt-bindings: mfd: LMU: Add the ramp up/down property Dan Murphy
2019-04-05 14:28 ` Dan Murphy
2019-04-05 14:28 ` [PATCH v2 2/6] dt-bindings: mfd: LMU: Add ti,brightness-resolution Dan Murphy
2019-04-05 14:28 ` Dan Murphy
2019-04-29 17:33 ` Rob Herring
2019-04-29 17:33 ` Rob Herring
2019-04-05 14:28 ` [PATCH v2 3/6] leds: TI LMU: Add common code for TI LMU devices Dan Murphy
2019-04-05 14:28 ` Dan Murphy
2019-04-05 14:28 ` [PATCH v2 4/6] dt-bindings: ti-lmu: Modify dt bindings for the LM3697 Dan Murphy
2019-04-05 14:28 ` Dan Murphy
2019-04-11 19:48 ` Jacek Anaszewski
2019-04-12 19:34 ` Jacek Anaszewski
2019-04-24 19:24 ` Dan Murphy
2019-04-24 19:24 ` Dan Murphy
2019-04-29 17:34 ` Rob Herring [this message]
2019-04-29 17:34 ` Rob Herring
2019-04-05 14:28 ` [PATCH v2 5/6] mfd: ti-lmu: Remove support for LM3697 Dan Murphy
2019-04-05 14:28 ` Dan Murphy
2019-04-05 14:28 ` [PATCH v2 6/6] leds: lm3697: Introduce the lm3697 driver Dan Murphy
2019-04-05 14:28 ` Dan Murphy
2019-04-29 17:32 ` [PATCH v2 1/6] dt-bindings: mfd: LMU: Add the ramp up/down property Rob Herring
2019-04-29 17:32 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190429173420.GA1273@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.