From: Christoph Hellwig <hch@lst.de>
To: Robin Murphy <robin.murphy@arm.com>
Cc: Christoph Hellwig <hch@lst.de>, Joerg Roedel <joro@8bytes.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
iommu@lists.linux-foundation.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 02/26] arm64/iommu: improve mmap bounds checking
Date: Mon, 29 Apr 2019 21:01:20 +0200 [thread overview]
Message-ID: <20190429190120.GA5637@lst.de> (raw)
In-Reply-To: <306b7a19-4eb5-d1d8-5250-40f3ba9bca16@arm.com>
On Mon, Apr 29, 2019 at 01:35:46PM +0100, Robin Murphy wrote:
> On 22/04/2019 18:59, Christoph Hellwig wrote:
>> The nr_pages checks should be done for all mmap requests, not just those
>> using remap_pfn_range.
>
> I think it probably makes sense now to just squash this with #22 one way or
> the other, but if you really really still want to keep it as a separate
> patch with a misleading commit message then I'm willing to keep my
> complaints to myself :)
Well, I split this out in response to your earlier comments, so if you
prefer it squasheѕ back in I can do that..
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Robin Murphy <robin.murphy@arm.com>
Cc: Tom Lendacky <thomas.lendacky@amd.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
Christoph Hellwig <hch@lst.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 02/26] arm64/iommu: improve mmap bounds checking
Date: Mon, 29 Apr 2019 21:01:20 +0200 [thread overview]
Message-ID: <20190429190120.GA5637@lst.de> (raw)
Message-ID: <20190429190120.zR8PLgoTvQ_wzQCizDFewIp1utSbxNG8G2w5xhk4FgI@z> (raw)
In-Reply-To: <306b7a19-4eb5-d1d8-5250-40f3ba9bca16@arm.com>
On Mon, Apr 29, 2019 at 01:35:46PM +0100, Robin Murphy wrote:
> On 22/04/2019 18:59, Christoph Hellwig wrote:
>> The nr_pages checks should be done for all mmap requests, not just those
>> using remap_pfn_range.
>
> I think it probably makes sense now to just squash this with #22 one way or
> the other, but if you really really still want to keep it as a separate
> patch with a misleading commit message then I'm willing to keep my
> complaints to myself :)
Well, I split this out in response to your earlier comments, so if you
prefer it squasheѕ back in I can do that..
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Robin Murphy <robin.murphy@arm.com>
Cc: Tom Lendacky <thomas.lendacky@amd.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Joerg Roedel <joro@8bytes.org>, Will Deacon <will.deacon@arm.com>,
linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
Christoph Hellwig <hch@lst.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 02/26] arm64/iommu: improve mmap bounds checking
Date: Mon, 29 Apr 2019 21:01:20 +0200 [thread overview]
Message-ID: <20190429190120.GA5637@lst.de> (raw)
In-Reply-To: <306b7a19-4eb5-d1d8-5250-40f3ba9bca16@arm.com>
On Mon, Apr 29, 2019 at 01:35:46PM +0100, Robin Murphy wrote:
> On 22/04/2019 18:59, Christoph Hellwig wrote:
>> The nr_pages checks should be done for all mmap requests, not just those
>> using remap_pfn_range.
>
> I think it probably makes sense now to just squash this with #22 one way or
> the other, but if you really really still want to keep it as a separate
> patch with a misleading commit message then I'm willing to keep my
> complaints to myself :)
Well, I split this out in response to your earlier comments, so if you
prefer it squasheѕ back in I can do that..
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-04-29 19:01 UTC|newest]
Thread overview: 155+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-22 17:59 implement generic dma_map_ops for IOMMUs v3 Christoph Hellwig
2019-04-22 17:59 ` Christoph Hellwig
2019-04-22 17:59 ` Christoph Hellwig
2019-04-22 17:59 ` Christoph Hellwig
[not found] ` <20190422175942.18788-1-hch-jcswGhMUV9g@public.gmane.org>
2019-04-22 17:59 ` [PATCH 01/26] arm64/iommu: handle non-remapped addresses in ->mmap and ->get_sgtable Christoph Hellwig
2019-04-22 17:59 ` Christoph Hellwig
2019-04-22 17:59 ` Christoph Hellwig
2019-04-22 17:59 ` Christoph Hellwig
2019-04-22 17:59 ` [PATCH 02/26] arm64/iommu: improve mmap bounds checking Christoph Hellwig
2019-04-22 17:59 ` Christoph Hellwig
2019-04-22 17:59 ` Christoph Hellwig
2019-04-22 17:59 ` Christoph Hellwig
2019-04-29 12:35 ` Robin Murphy
2019-04-29 12:35 ` Robin Murphy
2019-04-29 12:35 ` Robin Murphy
2019-04-29 19:01 ` Christoph Hellwig [this message]
2019-04-29 19:01 ` Christoph Hellwig
2019-04-29 19:01 ` Christoph Hellwig
2019-04-30 11:38 ` Robin Murphy
2019-04-30 11:38 ` Robin Murphy
2019-04-30 11:38 ` Robin Murphy
2019-04-22 17:59 ` [PATCH 12/26] iommu/dma: Refactor the page array remapping allocator Christoph Hellwig
2019-04-22 17:59 ` Christoph Hellwig
2019-04-22 17:59 ` Christoph Hellwig
2019-04-22 17:59 ` Christoph Hellwig
2019-04-29 13:10 ` Robin Murphy
2019-04-29 13:10 ` Robin Murphy
2019-04-29 13:10 ` Robin Murphy
2019-04-22 17:59 ` [PATCH 13/26] iommu/dma: Remove __iommu_dma_free Christoph Hellwig
2019-04-22 17:59 ` Christoph Hellwig
2019-04-22 17:59 ` Christoph Hellwig
2019-04-22 17:59 ` Christoph Hellwig
2019-04-29 13:18 ` Robin Murphy
2019-04-29 13:18 ` Robin Murphy
2019-04-29 13:18 ` Robin Murphy
2019-04-22 17:59 ` [PATCH 03/26] dma-mapping: add a Kconfig symbol to indicated arch_dma_prep_coherent presence Christoph Hellwig
2019-04-22 17:59 ` Christoph Hellwig
2019-04-22 17:59 ` Christoph Hellwig
2019-04-22 17:59 ` [PATCH 04/26] iommu/dma: Cleanup dma-iommu.h Christoph Hellwig
2019-04-22 17:59 ` Christoph Hellwig
2019-04-22 17:59 ` Christoph Hellwig
2019-04-22 17:59 ` [PATCH 05/26] iommu/dma: Remove the flush_page callback Christoph Hellwig
2019-04-22 17:59 ` Christoph Hellwig
2019-04-22 17:59 ` Christoph Hellwig
2019-04-22 17:59 ` [PATCH 06/26] iommu/dma: Use for_each_sg in iommu_dma_alloc Christoph Hellwig
2019-04-22 17:59 ` Christoph Hellwig
2019-04-22 17:59 ` Christoph Hellwig
2019-04-22 17:59 ` [PATCH 07/26] iommu/dma: move the arm64 wrappers to common code Christoph Hellwig
2019-06-05 0:47 ` Hillf Danton
2019-06-05 0:47 ` Hillf Danton
2019-04-22 17:59 ` Christoph Hellwig
2019-04-22 17:59 ` Christoph Hellwig
2019-04-29 12:56 ` Robin Murphy
2019-04-29 12:56 ` Robin Murphy
2019-04-29 12:56 ` Robin Murphy
2019-06-03 19:47 ` Jon Hunter
2019-06-03 19:47 ` Jon Hunter
2019-06-03 19:47 ` Jon Hunter
2019-06-03 19:47 ` Jon Hunter
2019-06-04 6:05 ` Christoph Hellwig
2019-06-04 6:05 ` Christoph Hellwig
2019-06-04 6:05 ` Christoph Hellwig
2019-06-04 6:05 ` Christoph Hellwig
2019-06-04 11:35 ` Jon Hunter
2019-06-04 11:35 ` Jon Hunter
2019-06-04 11:35 ` Jon Hunter
2019-06-04 11:35 ` Jon Hunter
2019-04-22 17:59 ` [PATCH 08/26] iommu/dma: Move __iommu_dma_map Christoph Hellwig
2019-04-22 17:59 ` Christoph Hellwig
2019-04-22 17:59 ` Christoph Hellwig
2019-04-22 17:59 ` [PATCH 09/26] iommu/dma: Move domain lookup into __iommu_dma_{map,unmap} Christoph Hellwig
2019-04-22 17:59 ` [PATCH 09/26] iommu/dma: Move domain lookup into __iommu_dma_{map, unmap} Christoph Hellwig
2019-04-22 17:59 ` Christoph Hellwig
2019-04-22 17:59 ` [PATCH 10/26] iommu/dma: Squash __iommu_dma_{map,unmap}_page helpers Christoph Hellwig
2019-04-22 17:59 ` Christoph Hellwig
2019-04-22 17:59 ` Christoph Hellwig
2019-04-22 17:59 ` [PATCH 11/26] iommu/dma: Factor out remapped pages lookup Christoph Hellwig
2019-04-22 17:59 ` Christoph Hellwig
2019-04-22 17:59 ` Christoph Hellwig
2019-04-29 13:05 ` Robin Murphy
2019-04-29 13:05 ` Robin Murphy
2019-04-29 13:05 ` Robin Murphy
2019-04-29 19:10 ` Christoph Hellwig
2019-04-29 19:10 ` Christoph Hellwig
2019-04-29 19:10 ` Christoph Hellwig
2019-04-22 17:59 ` [PATCH 14/26] iommu/dma: Refactor iommu_dma_free Christoph Hellwig
2019-04-22 17:59 ` Christoph Hellwig
2019-04-22 17:59 ` Christoph Hellwig
2019-04-29 13:59 ` Robin Murphy
2019-04-29 13:59 ` Robin Murphy
2019-04-29 13:59 ` Robin Murphy
2019-04-29 19:03 ` Christoph Hellwig
2019-04-29 19:03 ` Christoph Hellwig
2019-04-29 19:03 ` Christoph Hellwig
2019-04-29 19:16 ` Christoph Hellwig
2019-04-29 19:16 ` Christoph Hellwig
2019-04-29 19:16 ` Christoph Hellwig
2019-04-22 17:59 ` [PATCH 15/26] iommu/dma: Refactor iommu_dma_alloc Christoph Hellwig
2019-04-22 17:59 ` Christoph Hellwig
2019-04-22 17:59 ` Christoph Hellwig
2019-04-22 17:59 ` [PATCH 16/26] iommu/dma: Don't remap CMA unnecessarily Christoph Hellwig
2019-04-22 17:59 ` Christoph Hellwig
2019-04-22 17:59 ` Christoph Hellwig
2019-04-22 17:59 ` [PATCH 17/26] iommu/dma: Merge the CMA and alloc_pages allocation paths Christoph Hellwig
2019-04-22 17:59 ` Christoph Hellwig
2019-04-22 17:59 ` Christoph Hellwig
2019-04-22 17:59 ` [PATCH 18/26] iommu/dma: Split iommu_dma_free Christoph Hellwig
2019-04-22 17:59 ` Christoph Hellwig
2019-04-22 17:59 ` Christoph Hellwig
2019-04-22 17:59 ` [PATCH 19/26] iommu/dma: Cleanup variable naming in iommu_dma_alloc Christoph Hellwig
2019-04-22 17:59 ` Christoph Hellwig
2019-04-22 17:59 ` Christoph Hellwig
2019-04-29 14:11 ` Robin Murphy
2019-04-29 14:11 ` Robin Murphy
2019-04-29 14:11 ` Robin Murphy
2019-04-22 17:59 ` [PATCH 20/26] iommu/dma: Refactor iommu_dma_alloc, part 2 Christoph Hellwig
2019-04-22 17:59 ` Christoph Hellwig
2019-04-22 17:59 ` Christoph Hellwig
2019-04-29 14:45 ` Robin Murphy
2019-04-29 14:45 ` Robin Murphy
2019-04-29 14:45 ` Robin Murphy
2019-04-29 14:45 ` Robin Murphy
2019-04-22 17:59 ` [PATCH 21/26] iommu/dma: Refactor iommu_dma_get_sgtable Christoph Hellwig
2019-04-22 17:59 ` Christoph Hellwig
2019-04-22 17:59 ` Christoph Hellwig
2019-04-29 14:08 ` Robin Murphy
2019-04-29 14:08 ` Robin Murphy
2019-04-29 14:08 ` Robin Murphy
2019-04-22 17:59 ` [PATCH 22/26] iommu/dma: Refactor iommu_dma_mmap Christoph Hellwig
2019-04-22 17:59 ` Christoph Hellwig
2019-04-22 17:59 ` Christoph Hellwig
2019-04-29 14:04 ` Robin Murphy
2019-04-29 14:04 ` Robin Murphy
2019-04-29 14:04 ` Robin Murphy
2019-04-22 17:59 ` [PATCH 23/26] iommu/dma: Don't depend on CONFIG_DMA_DIRECT_REMAP Christoph Hellwig
2019-04-22 17:59 ` Christoph Hellwig
2019-04-22 17:59 ` Christoph Hellwig
2019-04-29 14:46 ` Robin Murphy
2019-04-29 14:46 ` Robin Murphy
2019-04-29 14:46 ` Robin Murphy
2019-04-22 17:59 ` [PATCH 24/26] iommu/dma: Switch copyright boilerplace to SPDX Christoph Hellwig
2019-04-22 17:59 ` Christoph Hellwig
2019-04-22 17:59 ` Christoph Hellwig
2019-04-22 17:59 ` [PATCH 25/26] arm64: switch copyright boilerplace to SPDX in dma-mapping.c Christoph Hellwig
2019-04-22 17:59 ` Christoph Hellwig
2019-04-22 17:59 ` Christoph Hellwig
2019-04-22 17:59 ` [PATCH 26/26] arm64: trim includes " Christoph Hellwig
2019-04-22 17:59 ` Christoph Hellwig
2019-04-22 17:59 ` Christoph Hellwig
2019-04-29 15:00 ` Robin Murphy
2019-04-29 15:00 ` Robin Murphy
2019-04-29 15:00 ` Robin Murphy
2019-04-29 15:03 ` implement generic dma_map_ops for IOMMUs v3 Robin Murphy
2019-04-29 15:03 ` Robin Murphy
2019-04-29 15:03 ` Robin Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190429190120.GA5637@lst.de \
--to=hch@lst.de \
--cc=catalin.marinas@arm.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=thomas.lendacky@amd.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.