From: Raul E Rangel <rrangel@chromium.org>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: linux-usb@vger.kernel.org,
Mathias Nyman <mathias.nyman@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Subject: [v2] xhci: Convert xhci_handshake() to use readl_poll_timeout_atomic()
Date: Mon, 29 Apr 2019 14:05:41 -0600 [thread overview]
Message-ID: <20190429200541.GA116440@google.com> (raw)
On Thu, Feb 07, 2019 at 05:48:16PM -0800, Andrey Smirnov wrote:
> Xhci_handshake() implements the algorithm already captured by
> readl_poll_timeout_atomic(). Convert the former to use the latter to
> avoid repetition.
>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Tested-by: Raul E Rangel <rrangel@chromium.org>
Reviewed-by: Raul E Rangel <rrangel@chromium.org>
This fixes a bug on the AMD Stoneyridge platform. usleep(1) sometimes
takes over 10ms. This means a 5 second timeout can easily take over 15
seconds which will trigger the watchdog and reboot the system.
Thanks for the patch.
WARNING: multiple messages have this Message-ID (diff)
From: Raul Rangel <rrangel@chromium.org>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: linux-usb@vger.kernel.org,
Mathias Nyman <mathias.nyman@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] xhci: Convert xhci_handshake() to use readl_poll_timeout_atomic()
Date: Mon, 29 Apr 2019 14:05:41 -0600 [thread overview]
Message-ID: <20190429200541.GA116440@google.com> (raw)
Message-ID: <20190429200541.itwfzHmPh3kL68cm6AFLS4g-kTqUI1dTfLvSa4ZW7f8@z> (raw)
In-Reply-To: <20190208014816.21869-1-andrew.smirnov@gmail.com>
On Thu, Feb 07, 2019 at 05:48:16PM -0800, Andrey Smirnov wrote:
> Xhci_handshake() implements the algorithm already captured by
> readl_poll_timeout_atomic(). Convert the former to use the latter to
> avoid repetition.
>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Tested-by: Raul E Rangel <rrangel@chromium.org>
Reviewed-by: Raul E Rangel <rrangel@chromium.org>
This fixes a bug on the AMD Stoneyridge platform. usleep(1) sometimes
takes over 10ms. This means a 5 second timeout can easily take over 15
seconds which will trigger the watchdog and reboot the system.
Thanks for the patch.
next reply other threads:[~2019-04-29 20:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-29 20:05 Raul E Rangel [this message]
2019-04-29 20:05 ` [PATCH v2] xhci: Convert xhci_handshake() to use readl_poll_timeout_atomic() Raul Rangel
-- strict thread matches above, loose matches on Subject: below --
2019-05-02 12:17 [v2] " Mathias Nyman
2019-05-02 12:17 ` [PATCH v2] " Mathias Nyman
2019-02-08 1:48 [v2] " Andrey Smirnov
2019-02-08 1:48 ` [PATCH v2] " Andrey Smirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190429200541.GA116440@google.com \
--to=rrangel@chromium.org \
--cc=andrew.smirnov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.