All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: "Shivamurthy Shastri (sshivamurthy)" <sshivamurthy@micron.com>
Cc: Boris Brezillon <bbrezillon@kernel.org>,
	Marcel Ziswiler <marcel.ziswiler@toradex.com>,
	Richard Weinberger <richard@nod.at>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Frieder Schrempf <frieder.schrempf@kontron.de>,
	Marek Vasut <marek.vasut@gmail.com>,
	"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
	Brian Norris <computersforpeace@gmail.com>,
	David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH 1/4] mtd: rawnand: Turn the ONFI support to generic
Date: Tue, 30 Apr 2019 08:30:59 +0200	[thread overview]
Message-ID: <20190430083059.629e0bf1@xps13> (raw)
In-Reply-To: <MN2PR08MB5951BDBAC83D3D04B3B122A5B85F0@MN2PR08MB5951.namprd08.prod.outlook.com>

Hi Shivamurthy,

Sorry for the long delay I was a bit overloaded.

"Shivamurthy Shastri (sshivamurthy)" <sshivamurthy@micron.com> wrote on
Tue, 26 Mar 2019 10:51:47 +0000:

> Fix headers to make way for adding helper functions.
> 
> Add onfi helper structure.
> 
> Add helper functions in raw NAND core, which later will be used during
> ONFI detection.
> 

As you are touching the core, I need to identify clearly each change
you make; typically in this commit you do several different changes.
Please split this patch in small meaningful peaces.

> Signed-off-by: Shivamurthy Shastri <sshivamurthy@micron.com>
> ---
>  drivers/mtd/nand/raw/internals.h |   6 +-
>  drivers/mtd/nand/raw/nand_base.c | 236 ++++++++++++++++++++++++++++---
>  drivers/mtd/nand/raw/nand_onfi.c | 215 +++++-----------------------
>  include/linux/mtd/nand.h         |  30 ++++
>  include/linux/mtd/rawnand.h      |   5 +
>  5 files changed, 289 insertions(+), 203 deletions(-)
> 

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: "Shivamurthy Shastri (sshivamurthy)" <sshivamurthy@micron.com>
Cc: Boris Brezillon <bbrezillon@kernel.org>,
	"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Richard Weinberger <richard@nod.at>,
	David Woodhouse <dwmw2@infradead.org>,
	Brian Norris <computersforpeace@gmail.com>,
	"Marek Vasut" <marek.vasut@gmail.com>,
	Marcel Ziswiler <marcel.ziswiler@toradex.com>,
	Frieder Schrempf <frieder.schrempf@kontron.de>
Subject: Re: [PATCH 1/4] mtd: rawnand: Turn the ONFI support to generic
Date: Tue, 30 Apr 2019 08:30:59 +0200	[thread overview]
Message-ID: <20190430083059.629e0bf1@xps13> (raw)
In-Reply-To: <MN2PR08MB5951BDBAC83D3D04B3B122A5B85F0@MN2PR08MB5951.namprd08.prod.outlook.com>

Hi Shivamurthy,

Sorry for the long delay I was a bit overloaded.

"Shivamurthy Shastri (sshivamurthy)" <sshivamurthy@micron.com> wrote on
Tue, 26 Mar 2019 10:51:47 +0000:

> Fix headers to make way for adding helper functions.
> 
> Add onfi helper structure.
> 
> Add helper functions in raw NAND core, which later will be used during
> ONFI detection.
> 

As you are touching the core, I need to identify clearly each change
you make; typically in this commit you do several different changes.
Please split this patch in small meaningful peaces.

> Signed-off-by: Shivamurthy Shastri <sshivamurthy@micron.com>
> ---
>  drivers/mtd/nand/raw/internals.h |   6 +-
>  drivers/mtd/nand/raw/nand_base.c | 236 ++++++++++++++++++++++++++++---
>  drivers/mtd/nand/raw/nand_onfi.c | 215 +++++-----------------------
>  include/linux/mtd/nand.h         |  30 ++++
>  include/linux/mtd/rawnand.h      |   5 +
>  5 files changed, 289 insertions(+), 203 deletions(-)
> 

Thanks,
Miquèl

  reply	other threads:[~2019-04-30  6:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-26 10:51 [PATCH 1/4] mtd: rawnand: Turn the ONFI support to generic Shivamurthy Shastri (sshivamurthy)
2019-03-26 10:51 ` Shivamurthy Shastri (sshivamurthy)
2019-04-30  6:30 ` Miquel Raynal [this message]
2019-04-30  6:30   ` Miquel Raynal
2019-05-02  8:34   ` [EXT] " Shivamurthy Shastri (sshivamurthy)
2019-05-02  8:34     ` Shivamurthy Shastri (sshivamurthy)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190430083059.629e0bf1@xps13 \
    --to=miquel.raynal@bootlin.com \
    --cc=bbrezillon@kernel.org \
    --cc=computersforpeace@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=frieder.schrempf@kontron.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=marcel.ziswiler@toradex.com \
    --cc=marek.vasut@gmail.com \
    --cc=richard@nod.at \
    --cc=sshivamurthy@micron.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.