All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Mackerras <paulus@ozlabs.org>
To: Suraj Jitindar Singh <sjitindarsingh@gmail.com>
Cc: kvm-ppc@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: PPC: Book3S HV: Save/restore vrsave register in kvmhv_p9_guest_entry()
Date: Tue, 30 Apr 2019 10:08:52 +0000	[thread overview]
Message-ID: <20190430100852.GI32205@blackberry> (raw)
In-Reply-To: <20190430004123.1189-1-sjitindarsingh@gmail.com>

On Tue, Apr 30, 2019 at 10:41:23AM +1000, Suraj Jitindar Singh wrote:
> On POWER9 and later processors where the host can schedule vcpus on a
> per thread basis, there is a streamlined entry path used when the guest
> is radix. This entry path saves/restores the fp and vr state in
> kvmhv_p9_guest_entry() by calling store_[fp/vr]_state() and
> load_[fp/vr]_state(). This is the same as the old entry path however the
> old entry path also saved/restored the VRSAVE register, which isn't done
> in the new entry path.
> 
> This means that the vrsave register is now volatile across guest exit,
> which is an incorrect change in behaviour.
> 
> Fix this by saving/restoring the vrsave register in kvmhv_p9_guest_entry().
> This restores the old, correct, behaviour.
> 
> Fixes: 95a6432ce9038 ("KVM: PPC: Book3S HV: Streamlined guest entry/exit path on P9 for radix guests")
> 
> Signed-off-by: Suraj Jitindar Singh <sjitindarsingh@gmail.com>

Thanks, patch applied to my kvm-ppc-next tree.

Paul.

WARNING: multiple messages have this Message-ID (diff)
From: Paul Mackerras <paulus@ozlabs.org>
To: Suraj Jitindar Singh <sjitindarsingh@gmail.com>
Cc: kvm-ppc@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: PPC: Book3S HV: Save/restore vrsave register in kvmhv_p9_guest_entry()
Date: Tue, 30 Apr 2019 20:08:52 +1000	[thread overview]
Message-ID: <20190430100852.GI32205@blackberry> (raw)
In-Reply-To: <20190430004123.1189-1-sjitindarsingh@gmail.com>

On Tue, Apr 30, 2019 at 10:41:23AM +1000, Suraj Jitindar Singh wrote:
> On POWER9 and later processors where the host can schedule vcpus on a
> per thread basis, there is a streamlined entry path used when the guest
> is radix. This entry path saves/restores the fp and vr state in
> kvmhv_p9_guest_entry() by calling store_[fp/vr]_state() and
> load_[fp/vr]_state(). This is the same as the old entry path however the
> old entry path also saved/restored the VRSAVE register, which isn't done
> in the new entry path.
> 
> This means that the vrsave register is now volatile across guest exit,
> which is an incorrect change in behaviour.
> 
> Fix this by saving/restoring the vrsave register in kvmhv_p9_guest_entry().
> This restores the old, correct, behaviour.
> 
> Fixes: 95a6432ce9038 ("KVM: PPC: Book3S HV: Streamlined guest entry/exit path on P9 for radix guests")
> 
> Signed-off-by: Suraj Jitindar Singh <sjitindarsingh@gmail.com>

Thanks, patch applied to my kvm-ppc-next tree.

Paul.

  reply	other threads:[~2019-04-30 10:08 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-11 10:51 [PATCH] KVM: PPC: Book3S HV: Save/restore SIAR and SDAR along with other PMU registers Paul Mackerras
2013-07-11 10:51 ` Paul Mackerras
2013-07-11 11:06 ` Alexander Graf
2013-07-11 11:06   ` Alexander Graf
2016-11-07  4:09 ` [PATCH] KVM: PPC: Book3S HV: Save/restore XER in checkpointed register state Paul Mackerras
2016-11-07  4:09   ` Paul Mackerras
2016-11-07  7:38   ` Thomas Huth
2016-11-07  7:38     ` Thomas Huth
2016-11-21  5:07   ` Paul Mackerras
2016-11-21  5:07     ` Paul Mackerras
2019-04-30  0:41 ` [PATCH] KVM: PPC: Book3S HV: Save/restore vrsave register in kvmhv_p9_guest_entry() Suraj Jitindar Singh
2019-04-30  0:41   ` Suraj Jitindar Singh
2019-04-30 10:08   ` Paul Mackerras [this message]
2019-04-30 10:08     ` Paul Mackerras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190430100852.GI32205@blackberry \
    --to=paulus@ozlabs.org \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=sjitindarsingh@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.