From: Christoph Hellwig <hch@lst.de>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH v7 2/5] fs: Turn __generic_write_end into a void function
Date: Tue, 30 Apr 2019 12:29:25 +0200 [thread overview]
Message-ID: <20190430102925.GA19506@lst.de> (raw)
In-Reply-To: <20190429220934.10415-3-agruenba@redhat.com>
On Tue, Apr 30, 2019 at 12:09:31AM +0200, Andreas Gruenbacher wrote:
> The VFS-internal __generic_write_end helper always returns the value of
> its @copied argument. This can be confusing, and it isn't very useful
> anyway, so turn __generic_write_end into a function returning void
> instead.
>
> Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Andreas Gruenbacher <agruenba@redhat.com>
Cc: cluster-devel@redhat.com,
"Darrick J . Wong" <darrick.wong@oracle.com>,
"Christoph Hellwig" <hch@lst.de>,
"Bob Peterson" <rpeterso@redhat.com>, "Jan Kara" <jack@suse.cz>,
"Dave Chinner" <david@fromorbit.com>,
"Ross Lagerwall" <ross.lagerwall@citrix.com>,
"Mark Syms" <Mark.Syms@citrix.com>,
"Edwin Török" <edvin.torok@citrix.com>,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v7 2/5] fs: Turn __generic_write_end into a void function
Date: Tue, 30 Apr 2019 12:29:25 +0200 [thread overview]
Message-ID: <20190430102925.GA19506@lst.de> (raw)
In-Reply-To: <20190429220934.10415-3-agruenba@redhat.com>
On Tue, Apr 30, 2019 at 12:09:31AM +0200, Andreas Gruenbacher wrote:
> The VFS-internal __generic_write_end helper always returns the value of
> its @copied argument. This can be confusing, and it isn't very useful
> anyway, so turn __generic_write_end into a function returning void
> instead.
>
> Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2019-04-30 10:29 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-29 22:09 [Cluster-devel] [PATCH v7 0/5] iomap and gfs2 fixes Andreas Gruenbacher
2019-04-29 22:09 ` Andreas Gruenbacher
2019-04-29 22:09 ` [Cluster-devel] [PATCH v7 1/5] iomap: Clean up __generic_write_end calling Andreas Gruenbacher
2019-04-29 22:09 ` Andreas Gruenbacher
2019-04-30 15:14 ` [Cluster-devel] " Darrick J. Wong
2019-04-30 15:14 ` Darrick J. Wong
2019-04-29 22:09 ` [Cluster-devel] [PATCH v7 2/5] fs: Turn __generic_write_end into a void function Andreas Gruenbacher
2019-04-29 22:09 ` Andreas Gruenbacher
2019-04-30 10:29 ` Christoph Hellwig [this message]
2019-04-30 10:29 ` Christoph Hellwig
2019-04-30 15:17 ` [Cluster-devel] " Darrick J. Wong
2019-04-30 15:17 ` Darrick J. Wong
2019-04-29 22:09 ` [Cluster-devel] [PATCH v7 3/5] iomap: Fix use-after-free error in page_done callback Andreas Gruenbacher
2019-04-29 22:09 ` Andreas Gruenbacher
2019-04-30 15:23 ` [Cluster-devel] " Darrick J. Wong
2019-04-30 15:23 ` Darrick J. Wong
2019-04-29 22:09 ` [Cluster-devel] [PATCH v7 4/5] iomap: Add a page_prepare callback Andreas Gruenbacher
2019-04-29 22:09 ` Andreas Gruenbacher
2019-04-30 15:26 ` [Cluster-devel] " Darrick J. Wong
2019-04-30 15:26 ` Darrick J. Wong
2019-04-29 22:09 ` [Cluster-devel] [PATCH v7 5/5] gfs2: Fix iomap write page reclaim deadlock Andreas Gruenbacher
2019-04-29 22:09 ` Andreas Gruenbacher
2019-04-30 15:32 ` [Cluster-devel] " Darrick J. Wong
2019-04-30 15:32 ` Darrick J. Wong
2019-04-30 15:39 ` [Cluster-devel] " Andreas Gruenbacher
2019-04-30 15:39 ` Andreas Gruenbacher
2019-04-30 15:47 ` [Cluster-devel] " Darrick J. Wong
2019-04-30 15:47 ` Darrick J. Wong
2019-04-30 16:15 ` [Cluster-devel] " Andreas Grünbacher
2019-04-30 16:15 ` Andreas Grünbacher
2019-04-30 2:50 ` [Cluster-devel] [PATCH v7 0/5] iomap and gfs2 fixes Darrick J. Wong
2019-04-30 2:50 ` Darrick J. Wong
2019-04-30 21:21 ` [Cluster-devel] " Dave Chinner
2019-04-30 21:21 ` Dave Chinner
2019-05-01 15:06 ` [Cluster-devel] " Darrick J. Wong
2019-05-01 15:06 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190430102925.GA19506@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.