From: Jacob Pan <jacob.jun.pan@linux.intel.com>
To: Jean-Philippe Brucker <jean-philippe.brucker@arm.com>
Cc: Auger Eric <eric.auger@redhat.com>,
iommu@lists.linux-foundation.org,
LKML <linux-kernel@vger.kernel.org>,
Joerg Roedel <joro@8bytes.org>,
David Woodhouse <dwmw2@infradead.org>,
Alex Williamson <alex.williamson@redhat.com>,
"Tian, Kevin" <kevin.tian@intel.com>,
Raj Ashok <ashok.raj@intel.com>,
Andriy Shevchenko <andriy.shevchenko@linux.intel.com>,
jacob.jun.pan@linux.intel.com
Subject: Re: [PATCH v2 06/19] drivers core: Add I/O ASID allocator
Date: Tue, 30 Apr 2019 13:24:05 -0700 [thread overview]
Message-ID: <20190430132405.62902350@jacob-builder> (raw)
In-Reply-To: <fd5b8c6c-05f0-307b-aaa2-0938337014a8@arm.com>
On Thu, 25 Apr 2019 11:41:05 +0100
Jean-Philippe Brucker <jean-philippe.brucker@arm.com> wrote:
> On 25/04/2019 11:17, Auger Eric wrote:
> >> +/**
> >> + * ioasid_alloc - Allocate an IOASID
> >> + * @set: the IOASID set
> >> + * @min: the minimum ID (inclusive)
> >> + * @max: the maximum ID (exclusive)
> >> + * @private: data private to the caller
> >> + *
> >> + * Allocate an ID between @min and @max (or %0 and %INT_MAX).
> >> Return the
> > I would remove "(or %0 and %INT_MAX)".
>
> Agreed, those where the default values of idr, but the xarray doesn't
> define a default max value. By the way, I do think squashing patches 6
> and 7 would be better (keeping my SOB but you can change the author).
>
I will squash 6 and 7 in v3. I will just add my SOB but keep the
author if that is OK.
WARNING: multiple messages have this Message-ID (diff)
From: Jacob Pan <jacob.jun.pan@linux.intel.com>
To: Jean-Philippe Brucker <jean-philippe.brucker@arm.com>
Cc: "Tian, Kevin" <kevin.tian@intel.com>,
Raj Ashok <ashok.raj@intel.com>,
iommu@lists.linux-foundation.org,
LKML <linux-kernel@vger.kernel.org>,
Alex Williamson <alex.williamson@redhat.com>,
Andriy Shevchenko <andriy.shevchenko@linux.intel.com>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH v2 06/19] drivers core: Add I/O ASID allocator
Date: Tue, 30 Apr 2019 13:24:05 -0700 [thread overview]
Message-ID: <20190430132405.62902350@jacob-builder> (raw)
Message-ID: <20190430202405.j3qjxAO6qagXf04PD6MLcPiKzMw7qBhVDF2ZpNTE4KQ@z> (raw)
In-Reply-To: <fd5b8c6c-05f0-307b-aaa2-0938337014a8@arm.com>
On Thu, 25 Apr 2019 11:41:05 +0100
Jean-Philippe Brucker <jean-philippe.brucker@arm.com> wrote:
> On 25/04/2019 11:17, Auger Eric wrote:
> >> +/**
> >> + * ioasid_alloc - Allocate an IOASID
> >> + * @set: the IOASID set
> >> + * @min: the minimum ID (inclusive)
> >> + * @max: the maximum ID (exclusive)
> >> + * @private: data private to the caller
> >> + *
> >> + * Allocate an ID between @min and @max (or %0 and %INT_MAX).
> >> Return the
> > I would remove "(or %0 and %INT_MAX)".
>
> Agreed, those where the default values of idr, but the xarray doesn't
> define a default max value. By the way, I do think squashing patches 6
> and 7 would be better (keeping my SOB but you can change the author).
>
I will squash 6 and 7 in v3. I will just add my SOB but keep the
author if that is OK.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2019-04-30 20:24 UTC|newest]
Thread overview: 161+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-23 23:31 [PATCH v2 00/19] Shared virtual address IOMMU and VT-d support Jacob Pan
2019-04-23 23:31 ` Jacob Pan
2019-04-23 23:31 ` [PATCH v2 03/19] iommu: introduce device fault report API Jacob Pan
2019-04-23 23:31 ` Jacob Pan
2019-04-23 23:31 ` [PATCH v2 04/19] iommu: Introduce attach/detach_pasid_table API Jacob Pan
2019-04-23 23:31 ` Jacob Pan
[not found] ` <1556062279-64135-1-git-send-email-jacob.jun.pan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2019-04-23 23:31 ` [PATCH v2 01/19] driver core: add per device iommu param Jacob Pan
2019-04-23 23:31 ` Jacob Pan
2019-04-23 23:31 ` Jacob Pan
2019-04-23 23:31 ` [PATCH v2 02/19] iommu: introduce device fault data Jacob Pan
2019-04-23 23:31 ` Jacob Pan
2019-04-23 23:31 ` Jacob Pan
2019-04-25 12:46 ` Jean-Philippe Brucker
2019-04-25 12:46 ` Jean-Philippe Brucker
2019-04-25 13:21 ` Auger Eric
2019-04-25 13:21 ` Auger Eric
2019-04-25 14:33 ` Jean-Philippe Brucker
2019-04-25 14:33 ` Jean-Philippe Brucker
2019-04-25 18:07 ` Jacob Pan
2019-04-25 18:07 ` Jacob Pan
2019-04-23 23:31 ` [PATCH v2 05/19] iommu: Introduce cache_invalidate API Jacob Pan
2019-04-23 23:31 ` Jacob Pan
2019-04-23 23:31 ` Jacob Pan
2019-04-23 23:31 ` [PATCH v2 06/19] drivers core: Add I/O ASID allocator Jacob Pan
2019-04-23 23:31 ` Jacob Pan
2019-04-23 23:31 ` Jacob Pan
2019-04-24 6:19 ` Christoph Hellwig
2019-04-24 6:19 ` Christoph Hellwig
2019-04-25 18:19 ` Jacob Pan
2019-04-25 18:19 ` Jacob Pan
2019-04-25 18:19 ` Jacob Pan
2019-04-26 11:47 ` Jean-Philippe Brucker
2019-04-26 11:47 ` Jean-Philippe Brucker
2019-04-26 12:21 ` Christoph Hellwig
2019-04-26 12:21 ` Christoph Hellwig
2019-04-26 16:58 ` Jacob Pan
2019-04-26 16:58 ` Jacob Pan
2019-04-25 10:17 ` Auger Eric
2019-04-25 10:17 ` Auger Eric
2019-04-25 10:41 ` Jean-Philippe Brucker
2019-04-25 10:41 ` Jean-Philippe Brucker
2019-04-30 20:24 ` Jacob Pan [this message]
2019-04-30 20:24 ` Jacob Pan
2019-05-01 17:40 ` Jean-Philippe Brucker
2019-05-01 17:40 ` Jean-Philippe Brucker
2019-04-23 23:31 ` [PATCH v2 07/19] ioasid: Convert ioasid_idr to XArray Jacob Pan
2019-04-23 23:31 ` Jacob Pan
2019-04-23 23:31 ` Jacob Pan
2019-04-23 23:31 ` [PATCH v2 08/19] ioasid: Add custom IOASID allocator Jacob Pan
2019-04-23 23:31 ` Jacob Pan
2019-04-25 10:03 ` Auger Eric
2019-04-25 10:03 ` Auger Eric
2019-04-25 21:29 ` Jacob Pan
2019-04-25 21:29 ` Jacob Pan
2019-04-26 9:06 ` Auger Eric
2019-04-26 9:06 ` Auger Eric
2019-04-26 15:19 ` Jacob Pan
2019-04-26 15:19 ` Jacob Pan
2019-05-06 17:59 ` Jacob Pan
2019-05-06 17:59 ` Jacob Pan
2019-04-23 23:31 ` [PATCH v2 09/19] iommu/vt-d: Enlightened PASID allocation Jacob Pan
2019-04-23 23:31 ` Jacob Pan
[not found] ` <1556062279-64135-10-git-send-email-jacob.jun.pan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2019-04-24 17:27 ` Auger Eric
2019-04-24 17:27 ` Auger Eric
2019-04-24 17:27 ` Auger Eric
2019-04-25 7:12 ` Liu, Yi L
2019-04-25 7:12 ` Liu, Yi L
2019-04-25 7:40 ` Auger Eric
2019-04-25 7:40 ` Auger Eric
[not found] ` <c847182b-6e5c-5344-a162-29e273a489fb-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2019-04-25 23:01 ` Jacob Pan
2019-04-25 23:01 ` Jacob Pan
2019-04-25 23:01 ` Jacob Pan
2019-04-25 23:40 ` Jacob Pan
2019-04-25 23:40 ` Jacob Pan
2019-04-26 7:24 ` Auger Eric
2019-04-26 7:24 ` Auger Eric
2019-04-26 15:05 ` Jacob Pan
2019-04-26 15:05 ` Jacob Pan
2019-04-23 23:31 ` [PATCH v2 10/19] iommu/vt-d: Add custom allocator for IOASID Jacob Pan
2019-04-23 23:31 ` Jacob Pan
[not found] ` <1556062279-64135-11-git-send-email-jacob.jun.pan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2019-04-24 17:27 ` Auger Eric
2019-04-24 17:27 ` Auger Eric
2019-04-24 17:27 ` Auger Eric
2019-04-26 20:11 ` Jacob Pan
2019-04-26 20:11 ` Jacob Pan
2019-04-23 23:31 ` [PATCH v2 11/19] iommu/vt-d: Replace Intel specific PASID allocator with IOASID Jacob Pan
2019-04-23 23:31 ` Jacob Pan
2019-04-25 10:04 ` Auger Eric
2019-04-25 10:04 ` Auger Eric
[not found] ` <e542fd95-acbe-05e9-e441-27dff752c21a-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2019-04-26 21:01 ` Jacob Pan
2019-04-26 21:01 ` Jacob Pan
2019-04-27 8:38 ` Auger Eric
2019-04-27 8:38 ` Auger Eric
2019-04-29 10:00 ` Jean-Philippe Brucker
2019-04-29 10:00 ` Jean-Philippe Brucker
2019-04-23 23:31 ` [PATCH v2 12/19] iommu/vt-d: Move domain helper to header Jacob Pan
2019-04-23 23:31 ` Jacob Pan
[not found] ` <1556062279-64135-13-git-send-email-jacob.jun.pan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2019-04-24 17:27 ` Auger Eric
2019-04-24 17:27 ` Auger Eric
2019-04-24 17:27 ` Auger Eric
2019-04-23 23:31 ` [PATCH v2 13/19] iommu/vt-d: Add nested translation support Jacob Pan
2019-04-23 23:31 ` Jacob Pan
2019-04-26 15:42 ` Auger Eric
2019-04-26 15:42 ` Auger Eric
2019-04-26 21:57 ` Jacob Pan
2019-04-26 21:57 ` Jacob Pan
2019-04-23 23:31 ` [PATCH v2 14/19] iommu: Add guest PASID bind function Jacob Pan
2019-04-23 23:31 ` Jacob Pan
2019-04-26 15:53 ` Auger Eric
2019-04-26 15:53 ` Auger Eric
2019-04-26 22:11 ` Jacob Pan
2019-04-26 22:11 ` Jacob Pan
2019-04-27 8:37 ` Auger Eric
2019-04-27 8:37 ` Auger Eric
2019-04-23 23:31 ` [PATCH v2 15/19] iommu/vt-d: Add bind guest PASID support Jacob Pan
2019-04-23 23:31 ` Jacob Pan
2019-04-26 16:15 ` Auger Eric
2019-04-26 16:15 ` Auger Eric
2019-04-29 15:25 ` Jacob Pan
2019-04-29 15:25 ` Jacob Pan
2019-04-30 7:05 ` Auger Eric
2019-04-30 7:05 ` Auger Eric
2019-04-30 17:49 ` Jacob Pan
2019-04-30 17:49 ` Jacob Pan
2019-04-23 23:31 ` [PATCH v2 16/19] iommu/vtd: Clean up for SVM device list Jacob Pan
2019-04-23 23:31 ` Jacob Pan
2019-04-26 16:19 ` Auger Eric
2019-04-26 16:19 ` Auger Eric
2019-04-23 23:31 ` [PATCH v2 17/19] iommu: Add max num of cache and granu types Jacob Pan
2019-04-23 23:31 ` Jacob Pan
2019-04-26 16:22 ` Auger Eric
2019-04-26 16:22 ` Auger Eric
2019-04-29 16:17 ` Jacob Pan
2019-04-29 16:17 ` Jacob Pan
2019-04-30 5:15 ` Auger Eric
2019-04-30 5:15 ` Auger Eric
2019-04-23 23:31 ` [PATCH v2 18/19] iommu/vt-d: Support flushing more translation cache types Jacob Pan
2019-04-23 23:31 ` Jacob Pan
2019-04-27 9:04 ` Auger Eric
2019-04-27 9:04 ` Auger Eric
2019-04-29 21:29 ` Jacob Pan
2019-04-29 21:29 ` Jacob Pan
2019-04-30 4:41 ` Auger Eric
2019-04-30 4:41 ` Auger Eric
2019-04-30 4:41 ` Auger Eric
2019-04-30 17:15 ` Jacob Pan
2019-04-30 17:15 ` Jacob Pan
2019-04-30 17:41 ` Auger Eric
2019-04-30 17:41 ` Auger Eric
2019-04-23 23:31 ` [PATCH v2 19/19] iommu/vt-d: Add svm/sva invalidate function Jacob Pan
2019-04-23 23:31 ` Jacob Pan
2019-04-26 17:23 ` Auger Eric
2019-04-26 17:23 ` Auger Eric
2019-04-29 22:41 ` Jacob Pan
2019-04-29 22:41 ` Jacob Pan
2019-04-30 6:57 ` Auger Eric
2019-04-30 6:57 ` Auger Eric
2019-04-30 17:22 ` Jacob Pan
2019-04-30 17:22 ` Jacob Pan
2019-04-30 17:36 ` Auger Eric
2019-04-30 17:36 ` Auger Eric
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190430132405.62902350@jacob-builder \
--to=jacob.jun.pan@linux.intel.com \
--cc=alex.williamson@redhat.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=ashok.raj@intel.com \
--cc=dwmw2@infradead.org \
--cc=eric.auger@redhat.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jean-philippe.brucker@arm.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.