From: "Michael S. Tsirkin" <mst@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>,
Wei Yang <richard.weiyang@gmail.com>,
Wei Yang <richardw.yang@linux.intel.com>,
pagupta@redhat.com, xiaoguangrong.eric@gmail.com,
Haozhong Zhang <haozhong.zhang@intel.com>,
qemu-devel@nongnu.org, yi.z.zhang@linux.intel.com,
yu.c.zhang@linux.intel.com, stefanha@redhat.com,
imammedo@redhat.com, dan.j.williams@intel.com
Subject: Re: [Qemu-devel] [PATCH v15 1/2] util/mmap-alloc: support MAP_SYNC in qemu_ram_mmap()
Date: Tue, 30 Apr 2019 19:38:59 -0400 [thread overview]
Message-ID: <20190430193838-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <86e00247-588c-37c1-0737-82614a8f18c0@redhat.com>
On Wed, May 01, 2019 at 01:11:34AM +0200, Paolo Bonzini wrote:
> On 01/05/19 00:50, Michael S. Tsirkin wrote:
> >> Stefan, did you hit a build failure, or it was just theoretical?
> >>
> >> linux-headers/*/mman.h is updated by "linux-headers: add
> >> linux/mman.h" (commit 8cf108c5d159). If the build really fails,
> >> something else is broken in our build system.
> > I think it's for non-linux hosts. linux-headers/ is only used
> > on linux hosts.
>
> Yes, it is. Maybe the #ifndef/#define part should be only used for
> non-Linux.
>
> Paolo
Makes sense. We'd rather have an error on linux than stub it out as 0.
--
MST
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: pagupta@redhat.com, xiaoguangrong.eric@gmail.com,
Haozhong Zhang <haozhong.zhang@intel.com>,
qemu-devel@nongnu.org, Wei Yang <richard.weiyang@gmail.com>,
yi.z.zhang@linux.intel.com, yu.c.zhang@linux.intel.com,
Wei Yang <richardw.yang@linux.intel.com>,
stefanha@redhat.com, imammedo@redhat.com,
dan.j.williams@intel.com, Eduardo Habkost <ehabkost@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v15 1/2] util/mmap-alloc: support MAP_SYNC in qemu_ram_mmap()
Date: Tue, 30 Apr 2019 19:38:59 -0400 [thread overview]
Message-ID: <20190430193838-mutt-send-email-mst@kernel.org> (raw)
Message-ID: <20190430233859.H86datj5rTUWS5qajksxERZlybg1IghqqxhRYlcLk_o@z> (raw)
In-Reply-To: <86e00247-588c-37c1-0737-82614a8f18c0@redhat.com>
On Wed, May 01, 2019 at 01:11:34AM +0200, Paolo Bonzini wrote:
> On 01/05/19 00:50, Michael S. Tsirkin wrote:
> >> Stefan, did you hit a build failure, or it was just theoretical?
> >>
> >> linux-headers/*/mman.h is updated by "linux-headers: add
> >> linux/mman.h" (commit 8cf108c5d159). If the build really fails,
> >> something else is broken in our build system.
> > I think it's for non-linux hosts. linux-headers/ is only used
> > on linux hosts.
>
> Yes, it is. Maybe the #ifndef/#define part should be only used for
> non-Linux.
>
> Paolo
Makes sense. We'd rather have an error on linux than stub it out as 0.
--
MST
next prev parent reply other threads:[~2019-04-30 23:39 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-26 0:36 [Qemu-devel] [PATCH v15 0/2] support MAP_SYNC for memory-backend-file Wei Yang
2019-04-26 0:36 ` Wei Yang
2019-04-26 0:36 ` [Qemu-devel] [PATCH v15 1/2] util/mmap-alloc: support MAP_SYNC in qemu_ram_mmap() Wei Yang
2019-04-26 0:36 ` Wei Yang
2019-04-30 20:46 ` Eduardo Habkost
2019-04-30 20:46 ` Eduardo Habkost
2019-04-30 22:36 ` Wei Yang
2019-04-30 22:36 ` Wei Yang
2019-04-30 22:48 ` Eduardo Habkost
2019-04-30 22:48 ` Eduardo Habkost
2019-04-30 22:50 ` Michael S. Tsirkin
2019-04-30 22:50 ` Michael S. Tsirkin
2019-04-30 23:11 ` Paolo Bonzini
2019-04-30 23:11 ` Paolo Bonzini
2019-04-30 23:38 ` Michael S. Tsirkin [this message]
2019-04-30 23:38 ` Michael S. Tsirkin
2019-05-01 16:58 ` Eduardo Habkost
2019-05-01 16:58 ` Eduardo Habkost
2019-05-01 17:26 ` Stefan Hajnoczi
2019-05-01 17:26 ` Stefan Hajnoczi
2019-04-26 0:36 ` [Qemu-devel] [PATCH v15 2/2] docs: Added MAP_SYNC documentation Wei Yang
2019-04-26 0:36 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190430193838-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=ehabkost@redhat.com \
--cc=haozhong.zhang@intel.com \
--cc=imammedo@redhat.com \
--cc=pagupta@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.weiyang@gmail.com \
--cc=richardw.yang@linux.intel.com \
--cc=stefanha@redhat.com \
--cc=xiaoguangrong.eric@gmail.com \
--cc=yi.z.zhang@linux.intel.com \
--cc=yu.c.zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.