* [Linux-kernel-mentees] [PATCH] Staging: rtl8192u: ieee80211: Fix indentation errors by removing extra spaces
@ 2019-05-01 20:23 ` Puranjay Mohan
0 siblings, 0 replies; 4+ messages in thread
From: puranjay12 @ 2019-05-01 20:23 UTC (permalink / raw)
Remove extra spaces before statements to fix
following indentation warnings reported by checkpatch.pl.
WARNING: Statements should start on a tabstop
+ struct rtl_80211_hdr_3addr *delba = NULL;
WARNING: Statements should start on a tabstop
+ struct rtl_80211_hdr_3addr *rsp = NULL;
WARNING: Statements should start on a tabstop
+ struct rtl_80211_hdr_3addr *req = NULL;
WARNING: Statements should start on a tabstop
+ struct rtl_80211_hdr_3addr *Delba = NULL;
WARNING: Statements should start on a tabstop
+ struct rtl_80211_hdr_3addr *BAReq = NULL;
Signed-off-by: Puranjay Mohan <puranjay12 at gmail.com>
---
drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c b/drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c
index af396c53a929..37ec3eee8651 100644
--- a/drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c
+++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c
@@ -108,7 +108,7 @@ void ResetBaEntry(struct ba_record *pBA)
static struct sk_buff *ieee80211_ADDBA(struct ieee80211_device *ieee, u8 *Dst, struct ba_record *pBA, u16 StatusCode, u8 type)
{
struct sk_buff *skb = NULL;
- struct rtl_80211_hdr_3addr *BAReq = NULL;
+ struct rtl_80211_hdr_3addr *BAReq = NULL;
u8 *tag = NULL;
u16 len = ieee->tx_headroom + 9;
//category(1) + action field(1) + Dialog Token(1) + BA Parameter Set(2) + BA Timeout Value(2) + BA Start SeqCtrl(2)(or StatusCode(2))
@@ -187,7 +187,7 @@ static struct sk_buff *ieee80211_DELBA(
{
union delba_param_set DelbaParamSet;
struct sk_buff *skb = NULL;
- struct rtl_80211_hdr_3addr *Delba = NULL;
+ struct rtl_80211_hdr_3addr *Delba = NULL;
u8 *tag = NULL;
//len = head len + DELBA Parameter Set(2) + Reason Code(2)
u16 len = 6 + ieee->tx_headroom;
@@ -314,7 +314,7 @@ static void ieee80211_send_DELBA(struct ieee80211_device *ieee, u8 *dst,
********************************************************************************************************************/
int ieee80211_rx_ADDBAReq(struct ieee80211_device *ieee, struct sk_buff *skb)
{
- struct rtl_80211_hdr_3addr *req = NULL;
+ struct rtl_80211_hdr_3addr *req = NULL;
u16 rc = 0;
u8 *dst = NULL, *pDialogToken = NULL, *tag = NULL;
struct ba_record *pBA = NULL;
@@ -414,7 +414,7 @@ int ieee80211_rx_ADDBAReq(struct ieee80211_device *ieee, struct sk_buff *skb)
********************************************************************************************************************/
int ieee80211_rx_ADDBARsp(struct ieee80211_device *ieee, struct sk_buff *skb)
{
- struct rtl_80211_hdr_3addr *rsp = NULL;
+ struct rtl_80211_hdr_3addr *rsp = NULL;
struct ba_record *pPendingBA, *pAdmittedBA;
struct tx_ts_record *pTS = NULL;
u8 *dst = NULL, *pDialogToken = NULL, *tag = NULL;
@@ -538,7 +538,7 @@ int ieee80211_rx_ADDBARsp(struct ieee80211_device *ieee, struct sk_buff *skb)
********************************************************************************************************************/
int ieee80211_rx_DELBA(struct ieee80211_device *ieee, struct sk_buff *skb)
{
- struct rtl_80211_hdr_3addr *delba = NULL;
+ struct rtl_80211_hdr_3addr *delba = NULL;
union delba_param_set *pDelBaParamSet = NULL;
u8 *dst = NULL;
--
2.21.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* [Linux-kernel-mentees] [PATCH] Staging: rtl8192u: ieee80211: Fix indentation errors by removing extra spaces
@ 2019-05-01 20:23 ` Puranjay Mohan
0 siblings, 0 replies; 4+ messages in thread
From: Puranjay Mohan @ 2019-05-01 20:23 UTC (permalink / raw)
Remove extra spaces before statements to fix
following indentation warnings reported by checkpatch.pl.
WARNING: Statements should start on a tabstop
+ struct rtl_80211_hdr_3addr *delba = NULL;
WARNING: Statements should start on a tabstop
+ struct rtl_80211_hdr_3addr *rsp = NULL;
WARNING: Statements should start on a tabstop
+ struct rtl_80211_hdr_3addr *req = NULL;
WARNING: Statements should start on a tabstop
+ struct rtl_80211_hdr_3addr *Delba = NULL;
WARNING: Statements should start on a tabstop
+ struct rtl_80211_hdr_3addr *BAReq = NULL;
Signed-off-by: Puranjay Mohan <puranjay12 at gmail.com>
---
drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c b/drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c
index af396c53a929..37ec3eee8651 100644
--- a/drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c
+++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c
@@ -108,7 +108,7 @@ void ResetBaEntry(struct ba_record *pBA)
static struct sk_buff *ieee80211_ADDBA(struct ieee80211_device *ieee, u8 *Dst, struct ba_record *pBA, u16 StatusCode, u8 type)
{
struct sk_buff *skb = NULL;
- struct rtl_80211_hdr_3addr *BAReq = NULL;
+ struct rtl_80211_hdr_3addr *BAReq = NULL;
u8 *tag = NULL;
u16 len = ieee->tx_headroom + 9;
//category(1) + action field(1) + Dialog Token(1) + BA Parameter Set(2) + BA Timeout Value(2) + BA Start SeqCtrl(2)(or StatusCode(2))
@@ -187,7 +187,7 @@ static struct sk_buff *ieee80211_DELBA(
{
union delba_param_set DelbaParamSet;
struct sk_buff *skb = NULL;
- struct rtl_80211_hdr_3addr *Delba = NULL;
+ struct rtl_80211_hdr_3addr *Delba = NULL;
u8 *tag = NULL;
//len = head len + DELBA Parameter Set(2) + Reason Code(2)
u16 len = 6 + ieee->tx_headroom;
@@ -314,7 +314,7 @@ static void ieee80211_send_DELBA(struct ieee80211_device *ieee, u8 *dst,
********************************************************************************************************************/
int ieee80211_rx_ADDBAReq(struct ieee80211_device *ieee, struct sk_buff *skb)
{
- struct rtl_80211_hdr_3addr *req = NULL;
+ struct rtl_80211_hdr_3addr *req = NULL;
u16 rc = 0;
u8 *dst = NULL, *pDialogToken = NULL, *tag = NULL;
struct ba_record *pBA = NULL;
@@ -414,7 +414,7 @@ int ieee80211_rx_ADDBAReq(struct ieee80211_device *ieee, struct sk_buff *skb)
********************************************************************************************************************/
int ieee80211_rx_ADDBARsp(struct ieee80211_device *ieee, struct sk_buff *skb)
{
- struct rtl_80211_hdr_3addr *rsp = NULL;
+ struct rtl_80211_hdr_3addr *rsp = NULL;
struct ba_record *pPendingBA, *pAdmittedBA;
struct tx_ts_record *pTS = NULL;
u8 *dst = NULL, *pDialogToken = NULL, *tag = NULL;
@@ -538,7 +538,7 @@ int ieee80211_rx_ADDBARsp(struct ieee80211_device *ieee, struct sk_buff *skb)
********************************************************************************************************************/
int ieee80211_rx_DELBA(struct ieee80211_device *ieee, struct sk_buff *skb)
{
- struct rtl_80211_hdr_3addr *delba = NULL;
+ struct rtl_80211_hdr_3addr *delba = NULL;
union delba_param_set *pDelBaParamSet = NULL;
u8 *dst = NULL;
--
2.21.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* [Linux-kernel-mentees] [PATCH] Staging: rtl8192u: ieee80211: Fix indentation errors by removing extra spaces
@ 2019-05-01 21:27 ` Bjorn Helgaas
0 siblings, 0 replies; 4+ messages in thread
From: bjorn.helgaas @ 2019-05-01 21:27 UTC (permalink / raw)
On Wed, May 1, 2019 at 3:24 PM Puranjay Mohan <puranjay12 at gmail.com> wrote:
>
> Remove extra spaces before statements to fix
> following indentation warnings reported by checkpatch.pl.
>
> WARNING: Statements should start on a tabstop
> + struct rtl_80211_hdr_3addr *delba = NULL;
In my opinion, a single example of the warnings is sufficient, i.e.,
the commit log could stop here. In fact, for whitespace patches, I
don't think you need to be too obsessive about all the gory details of
the checkpatch warnings. You could just say "Fix whitespace problems"
and do all the whitespace fixes in a single patch so you don't end up
with a dozen patches that only make whitespace changes. It's pretty
easy to review whitespace-only patches because "git diff" can be told
to ignore whitespace changes.
That file is also full of typos, too-long lines, poorly formatted
comments, etc., that are not whitespace-only changes. I'd probably do
something like a comment formatting patch, a line length patch, and a
typos patch so you just have one thing to think about when reviewing
each patch.
> WARNING: Statements should start on a tabstop
> + struct rtl_80211_hdr_3addr *rsp = NULL;
>
> WARNING: Statements should start on a tabstop
> + struct rtl_80211_hdr_3addr *req = NULL;
>
> WARNING: Statements should start on a tabstop
> + struct rtl_80211_hdr_3addr *Delba = NULL;
>
> WARNING: Statements should start on a tabstop
> + struct rtl_80211_hdr_3addr *BAReq = NULL;
>
> Signed-off-by: Puranjay Mohan <puranjay12 at gmail.com>
> ---
> drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c b/drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c
> index af396c53a929..37ec3eee8651 100644
> --- a/drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c
> +++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c
> @@ -108,7 +108,7 @@ void ResetBaEntry(struct ba_record *pBA)
> static struct sk_buff *ieee80211_ADDBA(struct ieee80211_device *ieee, u8 *Dst, struct ba_record *pBA, u16 StatusCode, u8 type)
> {
> struct sk_buff *skb = NULL;
> - struct rtl_80211_hdr_3addr *BAReq = NULL;
> + struct rtl_80211_hdr_3addr *BAReq = NULL;
> u8 *tag = NULL;
> u16 len = ieee->tx_headroom + 9;
> //category(1) + action field(1) + Dialog Token(1) + BA Parameter Set(2) + BA Timeout Value(2) + BA Start SeqCtrl(2)(or StatusCode(2))
> @@ -187,7 +187,7 @@ static struct sk_buff *ieee80211_DELBA(
> {
> union delba_param_set DelbaParamSet;
> struct sk_buff *skb = NULL;
> - struct rtl_80211_hdr_3addr *Delba = NULL;
> + struct rtl_80211_hdr_3addr *Delba = NULL;
> u8 *tag = NULL;
> //len = head len + DELBA Parameter Set(2) + Reason Code(2)
> u16 len = 6 + ieee->tx_headroom;
> @@ -314,7 +314,7 @@ static void ieee80211_send_DELBA(struct ieee80211_device *ieee, u8 *dst,
> ********************************************************************************************************************/
> int ieee80211_rx_ADDBAReq(struct ieee80211_device *ieee, struct sk_buff *skb)
> {
> - struct rtl_80211_hdr_3addr *req = NULL;
> + struct rtl_80211_hdr_3addr *req = NULL;
> u16 rc = 0;
> u8 *dst = NULL, *pDialogToken = NULL, *tag = NULL;
> struct ba_record *pBA = NULL;
> @@ -414,7 +414,7 @@ int ieee80211_rx_ADDBAReq(struct ieee80211_device *ieee, struct sk_buff *skb)
> ********************************************************************************************************************/
> int ieee80211_rx_ADDBARsp(struct ieee80211_device *ieee, struct sk_buff *skb)
> {
> - struct rtl_80211_hdr_3addr *rsp = NULL;
> + struct rtl_80211_hdr_3addr *rsp = NULL;
> struct ba_record *pPendingBA, *pAdmittedBA;
> struct tx_ts_record *pTS = NULL;
> u8 *dst = NULL, *pDialogToken = NULL, *tag = NULL;
> @@ -538,7 +538,7 @@ int ieee80211_rx_ADDBARsp(struct ieee80211_device *ieee, struct sk_buff *skb)
> ********************************************************************************************************************/
> int ieee80211_rx_DELBA(struct ieee80211_device *ieee, struct sk_buff *skb)
> {
> - struct rtl_80211_hdr_3addr *delba = NULL;
> + struct rtl_80211_hdr_3addr *delba = NULL;
> union delba_param_set *pDelBaParamSet = NULL;
> u8 *dst = NULL;
>
> --
> 2.21.0
>
> _______________________________________________
> Linux-kernel-mentees mailing list
> Linux-kernel-mentees at lists.linuxfoundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
^ permalink raw reply [flat|nested] 4+ messages in thread* [Linux-kernel-mentees] [PATCH] Staging: rtl8192u: ieee80211: Fix indentation errors by removing extra spaces
@ 2019-05-01 21:27 ` Bjorn Helgaas
0 siblings, 0 replies; 4+ messages in thread
From: Bjorn Helgaas @ 2019-05-01 21:27 UTC (permalink / raw)
On Wed, May 1, 2019 at 3:24 PM Puranjay Mohan <puranjay12 at gmail.com> wrote:
>
> Remove extra spaces before statements to fix
> following indentation warnings reported by checkpatch.pl.
>
> WARNING: Statements should start on a tabstop
> + struct rtl_80211_hdr_3addr *delba = NULL;
In my opinion, a single example of the warnings is sufficient, i.e.,
the commit log could stop here. In fact, for whitespace patches, I
don't think you need to be too obsessive about all the gory details of
the checkpatch warnings. You could just say "Fix whitespace problems"
and do all the whitespace fixes in a single patch so you don't end up
with a dozen patches that only make whitespace changes. It's pretty
easy to review whitespace-only patches because "git diff" can be told
to ignore whitespace changes.
That file is also full of typos, too-long lines, poorly formatted
comments, etc., that are not whitespace-only changes. I'd probably do
something like a comment formatting patch, a line length patch, and a
typos patch so you just have one thing to think about when reviewing
each patch.
> WARNING: Statements should start on a tabstop
> + struct rtl_80211_hdr_3addr *rsp = NULL;
>
> WARNING: Statements should start on a tabstop
> + struct rtl_80211_hdr_3addr *req = NULL;
>
> WARNING: Statements should start on a tabstop
> + struct rtl_80211_hdr_3addr *Delba = NULL;
>
> WARNING: Statements should start on a tabstop
> + struct rtl_80211_hdr_3addr *BAReq = NULL;
>
> Signed-off-by: Puranjay Mohan <puranjay12 at gmail.com>
> ---
> drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c b/drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c
> index af396c53a929..37ec3eee8651 100644
> --- a/drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c
> +++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c
> @@ -108,7 +108,7 @@ void ResetBaEntry(struct ba_record *pBA)
> static struct sk_buff *ieee80211_ADDBA(struct ieee80211_device *ieee, u8 *Dst, struct ba_record *pBA, u16 StatusCode, u8 type)
> {
> struct sk_buff *skb = NULL;
> - struct rtl_80211_hdr_3addr *BAReq = NULL;
> + struct rtl_80211_hdr_3addr *BAReq = NULL;
> u8 *tag = NULL;
> u16 len = ieee->tx_headroom + 9;
> //category(1) + action field(1) + Dialog Token(1) + BA Parameter Set(2) + BA Timeout Value(2) + BA Start SeqCtrl(2)(or StatusCode(2))
> @@ -187,7 +187,7 @@ static struct sk_buff *ieee80211_DELBA(
> {
> union delba_param_set DelbaParamSet;
> struct sk_buff *skb = NULL;
> - struct rtl_80211_hdr_3addr *Delba = NULL;
> + struct rtl_80211_hdr_3addr *Delba = NULL;
> u8 *tag = NULL;
> //len = head len + DELBA Parameter Set(2) + Reason Code(2)
> u16 len = 6 + ieee->tx_headroom;
> @@ -314,7 +314,7 @@ static void ieee80211_send_DELBA(struct ieee80211_device *ieee, u8 *dst,
> ********************************************************************************************************************/
> int ieee80211_rx_ADDBAReq(struct ieee80211_device *ieee, struct sk_buff *skb)
> {
> - struct rtl_80211_hdr_3addr *req = NULL;
> + struct rtl_80211_hdr_3addr *req = NULL;
> u16 rc = 0;
> u8 *dst = NULL, *pDialogToken = NULL, *tag = NULL;
> struct ba_record *pBA = NULL;
> @@ -414,7 +414,7 @@ int ieee80211_rx_ADDBAReq(struct ieee80211_device *ieee, struct sk_buff *skb)
> ********************************************************************************************************************/
> int ieee80211_rx_ADDBARsp(struct ieee80211_device *ieee, struct sk_buff *skb)
> {
> - struct rtl_80211_hdr_3addr *rsp = NULL;
> + struct rtl_80211_hdr_3addr *rsp = NULL;
> struct ba_record *pPendingBA, *pAdmittedBA;
> struct tx_ts_record *pTS = NULL;
> u8 *dst = NULL, *pDialogToken = NULL, *tag = NULL;
> @@ -538,7 +538,7 @@ int ieee80211_rx_ADDBARsp(struct ieee80211_device *ieee, struct sk_buff *skb)
> ********************************************************************************************************************/
> int ieee80211_rx_DELBA(struct ieee80211_device *ieee, struct sk_buff *skb)
> {
> - struct rtl_80211_hdr_3addr *delba = NULL;
> + struct rtl_80211_hdr_3addr *delba = NULL;
> union delba_param_set *pDelBaParamSet = NULL;
> u8 *dst = NULL;
>
> --
> 2.21.0
>
> _______________________________________________
> Linux-kernel-mentees mailing list
> Linux-kernel-mentees at lists.linuxfoundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-05-01 21:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-01 20:23 [Linux-kernel-mentees] [PATCH] Staging: rtl8192u: ieee80211: Fix indentation errors by removing extra spaces puranjay12
2019-05-01 20:23 ` Puranjay Mohan
2019-05-01 21:27 ` bjorn.helgaas
2019-05-01 21:27 ` Bjorn Helgaas
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.