From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Johan Hovold <johan@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
Kees Cook <keescook@chromium.org>
Subject: [v2] USB: serial: io_edgeport: mark expected switch fall-throughs
Date: Wed, 1 May 2019 16:33:29 -0500 [thread overview]
Message-ID: <20190501213329.GA26972@embeddedor> (raw)
In preparation to enabling -Wimplicit-fallthrough, mark switch
cases where we are expecting to fall through.
This patch fixes the following warnings:
drivers/usb/serial/io_edgeport.c: In function ‘process_rcvd_data’:
drivers/usb/serial/io_edgeport.c:1750:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
if (bufferLength == 0) {
^
drivers/usb/serial/io_edgeport.c:1755:3: note: here
case EXPECT_HDR2:
^~~~
drivers/usb/serial/io_edgeport.c:1810:8: warning: this statement may fall through [-Wimplicit-fallthrough=]
if (bufferLength == 0) {
^
drivers/usb/serial/io_edgeport.c:1816:3: note: here
case EXPECT_DATA: /* Expect data */
^~~~
Warning level 3 was used: -Wimplicit-fallthrough=3
Notice that, in this particular case, the code comments are modified
in accordance with what GCC is expecting to find.
This patch is part of the ongoing efforts to enable
-Wimplicit-fallthrough.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
Changes in v2:
- Warning level 3 is now used: -Wimplicit-fallthrough=3
instead of warning level 2.
- All warnings in the switch statement are addressed now.
Notice that these are the last remaining fall-through warnings
in the USB subsystem. :)
Thanks
--
Gustavo
drivers/usb/serial/io_edgeport.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/serial/io_edgeport.c b/drivers/usb/serial/io_edgeport.c
index 4ca31c0e4174..7ad10328f4e2 100644
--- a/drivers/usb/serial/io_edgeport.c
+++ b/drivers/usb/serial/io_edgeport.c
@@ -1751,7 +1751,7 @@ static void process_rcvd_data(struct edgeport_serial *edge_serial,
edge_serial->rxState = EXPECT_HDR2;
break;
}
- /* otherwise, drop on through */
+ /* Fall through - otherwise, drop on through */
case EXPECT_HDR2:
edge_serial->rxHeader2 = *buffer;
++buffer;
@@ -1813,6 +1813,7 @@ static void process_rcvd_data(struct edgeport_serial *edge_serial,
}
/* Else, drop through */
}
+ /* Fall through */
case EXPECT_DATA: /* Expect data */
if (bufferLength < edge_serial->rxBytesRemaining) {
rxLen = bufferLength;
WARNING: multiple messages have this Message-ID (diff)
From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Johan Hovold <johan@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
Kees Cook <keescook@chromium.org>
Subject: [PATCH v2] USB: serial: io_edgeport: mark expected switch fall-throughs
Date: Wed, 1 May 2019 16:33:29 -0500 [thread overview]
Message-ID: <20190501213329.GA26972@embeddedor> (raw)
Message-ID: <20190501213329.cEgM3-oh0HW9zgpNcmaB0O4FRseEw1DtzR-_Wni-4QY@z> (raw)
In preparation to enabling -Wimplicit-fallthrough, mark switch
cases where we are expecting to fall through.
This patch fixes the following warnings:
drivers/usb/serial/io_edgeport.c: In function ‘process_rcvd_data’:
drivers/usb/serial/io_edgeport.c:1750:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
if (bufferLength == 0) {
^
drivers/usb/serial/io_edgeport.c:1755:3: note: here
case EXPECT_HDR2:
^~~~
drivers/usb/serial/io_edgeport.c:1810:8: warning: this statement may fall through [-Wimplicit-fallthrough=]
if (bufferLength == 0) {
^
drivers/usb/serial/io_edgeport.c:1816:3: note: here
case EXPECT_DATA: /* Expect data */
^~~~
Warning level 3 was used: -Wimplicit-fallthrough=3
Notice that, in this particular case, the code comments are modified
in accordance with what GCC is expecting to find.
This patch is part of the ongoing efforts to enable
-Wimplicit-fallthrough.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
Changes in v2:
- Warning level 3 is now used: -Wimplicit-fallthrough=3
instead of warning level 2.
- All warnings in the switch statement are addressed now.
Notice that these are the last remaining fall-through warnings
in the USB subsystem. :)
Thanks
--
Gustavo
drivers/usb/serial/io_edgeport.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/serial/io_edgeport.c b/drivers/usb/serial/io_edgeport.c
index 4ca31c0e4174..7ad10328f4e2 100644
--- a/drivers/usb/serial/io_edgeport.c
+++ b/drivers/usb/serial/io_edgeport.c
@@ -1751,7 +1751,7 @@ static void process_rcvd_data(struct edgeport_serial *edge_serial,
edge_serial->rxState = EXPECT_HDR2;
break;
}
- /* otherwise, drop on through */
+ /* Fall through - otherwise, drop on through */
case EXPECT_HDR2:
edge_serial->rxHeader2 = *buffer;
++buffer;
@@ -1813,6 +1813,7 @@ static void process_rcvd_data(struct edgeport_serial *edge_serial,
}
/* Else, drop through */
}
+ /* Fall through */
case EXPECT_DATA: /* Expect data */
if (bufferLength < edge_serial->rxBytesRemaining) {
rxLen = bufferLength;
--
2.21.0
next reply other threads:[~2019-05-01 21:33 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-01 21:33 Gustavo A. R. Silva [this message]
2019-05-01 21:33 ` [PATCH v2] USB: serial: io_edgeport: mark expected switch fall-throughs Gustavo A. R. Silva
-- strict thread matches above, loose matches on Subject: below --
2019-05-02 10:26 [v2] " Johan Hovold
2019-05-02 10:26 ` [PATCH v2] " Johan Hovold
2019-05-02 13:22 [v2] " Gustavo A. R. Silva
2019-05-02 13:22 ` [PATCH v2] " Gustavo A. R. Silva
2019-05-02 13:56 [v2] " Johan Hovold
2019-05-02 13:56 ` [PATCH v2] " Johan Hovold
2019-05-02 14:28 [v2] " Gustavo A. R. Silva
2019-05-02 14:28 ` [PATCH v2] " Gustavo A. R. Silva
2019-05-02 14:40 [v2] " Greg Kroah-Hartman
2019-05-02 14:40 ` [PATCH v2] " Greg Kroah-Hartman
2019-05-02 14:47 [v2] " Greg Kroah-Hartman
2019-05-02 14:47 ` [PATCH v2] " Greg Kroah-Hartman
2019-05-02 14:48 [v2] " Johan Hovold
2019-05-02 14:48 ` [PATCH v2] " Johan Hovold
2019-05-02 14:57 [v2] " Gustavo A. R. Silva
2019-05-02 14:57 ` [PATCH v2] " Gustavo A. R. Silva
2019-05-02 15:04 [v2] " Greg Kroah-Hartman
2019-05-02 15:04 ` [PATCH v2] " Greg Kroah-Hartman
2019-05-02 15:14 [v2] " Johan Hovold
2019-05-02 15:14 ` [PATCH v2] " Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190501213329.GA26972@embeddedor \
--to=gustavo@embeddedor.com \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.