From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH] misc: aspeed-lpc-ctrl: Correct return values
Date: Thu, 2 May 2019 08:40:21 +0200 [thread overview]
Message-ID: <20190502064021.GA14911@kroah.com> (raw)
In-Reply-To: <20190501223836.1670096-1-vijaykhemka@fb.com>
On Wed, May 01, 2019 at 03:38:36PM -0700, Vijay Khemka wrote:
> Corrected some of return values with appropriate meanings.
>
> Signed-off-by: Vijay Khemka <vijaykhemka@fb.com>
> ---
> drivers/misc/aspeed-lpc-ctrl.c | 15 +++++++--------
> 1 file changed, 7 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/misc/aspeed-lpc-ctrl.c b/drivers/misc/aspeed-lpc-ctrl.c
> index 332210e06e98..97ae341109d5 100644
> --- a/drivers/misc/aspeed-lpc-ctrl.c
> +++ b/drivers/misc/aspeed-lpc-ctrl.c
> @@ -68,7 +68,6 @@ static long aspeed_lpc_ctrl_ioctl(struct file *file, unsigned int cmd,
> unsigned long param)
> {
> struct aspeed_lpc_ctrl *lpc_ctrl = file_aspeed_lpc_ctrl(file);
> - struct device *dev = file->private_data;
> void __user *p = (void __user *)param;
> struct aspeed_lpc_ctrl_mapping map;
> u32 addr;
This change is not reflected in your changelog text :(
Please fix up, or break this up into multiple patches.
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Vijay Khemka <vijaykhemka@fb.com>
Cc: sdasari@fb.com, Arnd Bergmann <arnd@arndb.de>,
linux-aspeed@lists.ozlabs.org, Andrew Jeffery <andrew@aj.id.au>,
linux-kernel@vger.kernel.org, Joel Stanley <joel@jms.id.au>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] misc: aspeed-lpc-ctrl: Correct return values
Date: Thu, 2 May 2019 08:40:21 +0200 [thread overview]
Message-ID: <20190502064021.GA14911@kroah.com> (raw)
In-Reply-To: <20190501223836.1670096-1-vijaykhemka@fb.com>
On Wed, May 01, 2019 at 03:38:36PM -0700, Vijay Khemka wrote:
> Corrected some of return values with appropriate meanings.
>
> Signed-off-by: Vijay Khemka <vijaykhemka@fb.com>
> ---
> drivers/misc/aspeed-lpc-ctrl.c | 15 +++++++--------
> 1 file changed, 7 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/misc/aspeed-lpc-ctrl.c b/drivers/misc/aspeed-lpc-ctrl.c
> index 332210e06e98..97ae341109d5 100644
> --- a/drivers/misc/aspeed-lpc-ctrl.c
> +++ b/drivers/misc/aspeed-lpc-ctrl.c
> @@ -68,7 +68,6 @@ static long aspeed_lpc_ctrl_ioctl(struct file *file, unsigned int cmd,
> unsigned long param)
> {
> struct aspeed_lpc_ctrl *lpc_ctrl = file_aspeed_lpc_ctrl(file);
> - struct device *dev = file->private_data;
> void __user *p = (void __user *)param;
> struct aspeed_lpc_ctrl_mapping map;
> u32 addr;
This change is not reflected in your changelog text :(
Please fix up, or break this up into multiple patches.
greg k-h
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Vijay Khemka <vijaykhemka@fb.com>
Cc: Arnd Bergmann <arnd@arndb.de>, Joel Stanley <joel@jms.id.au>,
Andrew Jeffery <andrew@aj.id.au>,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
sdasari@fb.com
Subject: Re: [PATCH] misc: aspeed-lpc-ctrl: Correct return values
Date: Thu, 2 May 2019 08:40:21 +0200 [thread overview]
Message-ID: <20190502064021.GA14911@kroah.com> (raw)
In-Reply-To: <20190501223836.1670096-1-vijaykhemka@fb.com>
On Wed, May 01, 2019 at 03:38:36PM -0700, Vijay Khemka wrote:
> Corrected some of return values with appropriate meanings.
>
> Signed-off-by: Vijay Khemka <vijaykhemka@fb.com>
> ---
> drivers/misc/aspeed-lpc-ctrl.c | 15 +++++++--------
> 1 file changed, 7 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/misc/aspeed-lpc-ctrl.c b/drivers/misc/aspeed-lpc-ctrl.c
> index 332210e06e98..97ae341109d5 100644
> --- a/drivers/misc/aspeed-lpc-ctrl.c
> +++ b/drivers/misc/aspeed-lpc-ctrl.c
> @@ -68,7 +68,6 @@ static long aspeed_lpc_ctrl_ioctl(struct file *file, unsigned int cmd,
> unsigned long param)
> {
> struct aspeed_lpc_ctrl *lpc_ctrl = file_aspeed_lpc_ctrl(file);
> - struct device *dev = file->private_data;
> void __user *p = (void __user *)param;
> struct aspeed_lpc_ctrl_mapping map;
> u32 addr;
This change is not reflected in your changelog text :(
Please fix up, or break this up into multiple patches.
greg k-h
next prev parent reply other threads:[~2019-05-02 6:40 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-01 22:38 [PATCH] misc: aspeed-lpc-ctrl: Correct return values Vijay Khemka
2019-05-01 22:38 ` Vijay Khemka
2019-05-01 22:38 ` Vijay Khemka
2019-05-02 6:40 ` Greg Kroah-Hartman [this message]
2019-05-02 6:40 ` Greg Kroah-Hartman
2019-05-02 6:40 ` Greg Kroah-Hartman
2019-05-02 6:49 ` Andrew Jeffery
2019-05-02 6:49 ` Andrew Jeffery
2019-05-02 6:49 ` Andrew Jeffery
2019-05-03 17:55 ` Vijay Khemka
2019-05-03 17:55 ` Vijay Khemka
2019-05-03 17:55 ` Vijay Khemka
-- strict thread matches above, loose matches on Subject: below --
2019-01-23 23:06 Vijay Khemka
2019-01-23 23:06 ` Vijay Khemka
2019-01-23 23:06 ` Vijay Khemka
2019-01-24 8:15 ` Greg Kroah-Hartman
2019-01-24 8:15 ` Greg Kroah-Hartman
2019-01-24 8:15 ` Greg Kroah-Hartman
2019-01-24 19:29 ` Vijay Khemka
2019-01-24 19:29 ` Vijay Khemka
2019-01-24 19:29 ` Vijay Khemka
2019-02-11 5:22 ` Andrew Jeffery
2019-02-11 5:22 ` Andrew Jeffery
2019-02-11 5:22 ` Andrew Jeffery
2019-02-11 20:13 ` Vijay Khemka
2019-02-11 20:13 ` Vijay Khemka
2019-02-11 20:13 ` Vijay Khemka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190502064021.GA14911@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-aspeed@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.