From: Vinod Koul <vkoul@kernel.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: alsa-devel@alsa-project.org, Shreyas NC <shreyas.nc@intel.com>,
Sanyog Kale <sanyog.r.kale@intel.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Subject: Re: [PATCH 01/14] soundwire: fix kconfig help format
Date: Thu, 2 May 2019 20:51:46 +0530 [thread overview]
Message-ID: <20190502152146.GS3845@vkoul-mobl.Dlink> (raw)
In-Reply-To: <20190502151558.GA2499@kroah.com>
On 02-05-19, 17:15, Greg KH wrote:
> On Thu, May 02, 2019 at 05:07:54PM +0200, Greg KH wrote:
> > On Thu, May 02, 2019 at 04:29:17PM +0530, Vinod Koul wrote:
> > > Move to help format instead of --help-- as that is not recommended and
> > > this makes file consistent with other instance
> > >
> > > Signed-off-by: Vinod Koul <vkoul@kernel.org>
> > > ---
> > > drivers/soundwire/Kconfig | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/soundwire/Kconfig b/drivers/soundwire/Kconfig
> > > index 84876a74874f..53b55b79c4af 100644
> > > --- a/drivers/soundwire/Kconfig
> > > +++ b/drivers/soundwire/Kconfig
> > > @@ -28,7 +28,7 @@ config SOUNDWIRE_INTEL
> > > select SOUNDWIRE_CADENCE
> > > select SOUNDWIRE_BUS
> > > depends on X86 && ACPI && SND_SOC
> > > - ---help---
> > > + help
> > > SoundWire Intel Master driver.
> > > If you have an Intel platform which has a SoundWire Master then
> > > enable this config option to get the SoundWire support for that
> > > --
> > > 2.20.1
> > >
> >
> > Huh?
> >
> > Pierre-Louis sent this patch before you did. Why did you just rewrite
> > the changelog text a bit and then ignore his authorship and
> > signed-off-by?
> >
> > That's a really really shitty thing to do, I'm going to go take his
> > version of these patches instead, let me see how they line up...
>
> Ok, my apologies, that was incorrect. Your patch was against a
> different file than his.
Yes and our emails crossed, apology accepted.
>
> Way to go and make this a total mess to try to figure out, let me see
> what I can do...
If you can hold off for a bit longer, I have patches in next (pierre's
full series and couple of then split and ofcourse authorship retain
(https://git.kernel.org/pub/scm/linux/kernel/git/vkoul/soundwire.git/log/?h=next)
and mine on top
(https://git.kernel.org/pub/scm/linux/kernel/git/vkoul/soundwire.git/log/?h=checkpatch_fixes)
I can send you a signed PR for both and you can merged them. otherwise
the style changes will conflict and defeat the whole purpose..
Let me know if that is okay, thanks
--
~Vinod
next prev parent reply other threads:[~2019-05-02 15:21 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-02 10:59 [PATCH 00/14] soundwire: more code cleanups Vinod Koul
2019-05-02 10:59 ` [PATCH 01/14] soundwire: fix kconfig help format Vinod Koul
2019-05-02 15:07 ` Greg KH
2019-05-02 15:15 ` Vinod Koul
2019-05-02 15:20 ` Greg KH
2019-05-02 15:15 ` Greg KH
2019-05-02 15:21 ` Vinod Koul [this message]
2019-05-02 16:35 ` Greg KH
2019-05-02 10:59 ` [PATCH 02/14] soundwire: fix SPDX license for header files Vinod Koul
2019-05-02 10:59 ` [PATCH 03/14] soundwire: intel: fix SPDX license for header file Vinod Koul
2019-05-02 10:59 ` [PATCH 04/14] soundwire: remove empty line before/after braces Vinod Koul
2019-05-02 10:59 ` [PATCH 05/14] soundwire: cadence: remove empty line after braces Vinod Koul
2019-05-02 10:59 ` [PATCH 06/14] soundwire: intel: " Vinod Koul
2019-05-02 10:59 ` [PATCH 07/14] soundwire: add argument to function definition Vinod Koul
2019-05-02 10:59 ` [PATCH 08/14] soundwire: more alignment fixes Vinod Koul
2019-05-02 10:59 ` [PATCH 09/14] soundwire: intel: " Vinod Koul
2019-05-02 10:59 ` [PATCH 10/14] soundwire: avoid multiple assignments Vinod Koul
2019-05-02 10:59 ` [PATCH 11/14] soundwire: fix more typos Vinod Koul
2019-05-02 10:59 ` [PATCH 12/14] soundwire: wrap macro argument in parenthesis Vinod Koul
2019-05-02 10:59 ` [PATCH 13/14] soundwire: add a blank line between functions Vinod Koul
2019-05-02 10:59 ` [PATCH 14/14] soundwire: remove multiple blank lines Vinod Koul
2019-05-02 15:10 ` [PATCH 00/14] soundwire: more code cleanups Greg KH
2019-05-02 15:19 ` Greg KH
2019-05-02 15:42 ` Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190502152146.GS3845@vkoul-mobl.Dlink \
--to=vkoul@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=gregkh@linuxfoundation.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=sanyog.r.kale@intel.com \
--cc=shreyas.nc@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.