From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Greg KH <gregkh@linuxfoundation.org>, Vinod Koul <vkoul@kernel.org>
Cc: alsa-devel@alsa-project.org,
Sanyog Kale <sanyog.r.kale@intel.com>,
Shreyas NC <shreyas.nc@intel.com>
Subject: Re: [PATCH 00/14] soundwire: more code cleanups
Date: Thu, 2 May 2019 10:42:30 -0500 [thread overview]
Message-ID: <7929c54b-2b00-cbc3-4aa7-6966b0bf2259@linux.intel.com> (raw)
In-Reply-To: <20190502151933.GA32285@kroah.com>
On 5/2/19 10:19 AM, Greg KH wrote:
> On Thu, May 02, 2019 at 04:29:16PM +0530, Vinod Koul wrote:
>> After applying cleanup from Pierre, I realized few more things can be
>> cleaned up as well, so fixing these instance in the subsystem.
>>
>> Looks like bool is no longer encouraged, but I have skipped those and few
>> alignment as they caused code to look worse.
>>
>> Greg,
>> if you are okay I would like to add this as well (i know it is late, but
>> they are cosmetic changes and no logic ones, let me know and I can
>> send a updated PR)
>
> This made no sense, as it was on top of Pierre's patches.
>
> I've applied both his, and your, patch series to the tree now, hopefully
> this type of mess doesn't happen again in the future.
>
> Please be a lot more specific as to what you expect me to do with a
> patch series, and what exactly it is for/against/after, as this was not
> obvious at all.
>
> ugh, someone owes me a drink...
>
> greg k-h
I'll be glad to buy a round at the next ELC.
I also boiled initially when I saw the Kconfig patch until I realized it
was a different patch. Same for the SPDX files. It wasn't obvious from a
quick review and I could have been the one sending a nasty email.
There are additional cleanups from Vinod that I saw but didn't fix as I
wasn't sure they made the code readable (e.g. dev_dbg logs exceeding 80
chars and newlines after loops), but I also missed others that are very
much needed, so please add my Rvb tag for this 'more code cleanups' series.
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Thank you Vinod for the additional work. I am almost done with the
sysfs/debugfs cleanups and should post that next week.
prev parent reply other threads:[~2019-05-02 15:42 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-02 10:59 [PATCH 00/14] soundwire: more code cleanups Vinod Koul
2019-05-02 10:59 ` [PATCH 01/14] soundwire: fix kconfig help format Vinod Koul
2019-05-02 15:07 ` Greg KH
2019-05-02 15:15 ` Vinod Koul
2019-05-02 15:20 ` Greg KH
2019-05-02 15:15 ` Greg KH
2019-05-02 15:21 ` Vinod Koul
2019-05-02 16:35 ` Greg KH
2019-05-02 10:59 ` [PATCH 02/14] soundwire: fix SPDX license for header files Vinod Koul
2019-05-02 10:59 ` [PATCH 03/14] soundwire: intel: fix SPDX license for header file Vinod Koul
2019-05-02 10:59 ` [PATCH 04/14] soundwire: remove empty line before/after braces Vinod Koul
2019-05-02 10:59 ` [PATCH 05/14] soundwire: cadence: remove empty line after braces Vinod Koul
2019-05-02 10:59 ` [PATCH 06/14] soundwire: intel: " Vinod Koul
2019-05-02 10:59 ` [PATCH 07/14] soundwire: add argument to function definition Vinod Koul
2019-05-02 10:59 ` [PATCH 08/14] soundwire: more alignment fixes Vinod Koul
2019-05-02 10:59 ` [PATCH 09/14] soundwire: intel: " Vinod Koul
2019-05-02 10:59 ` [PATCH 10/14] soundwire: avoid multiple assignments Vinod Koul
2019-05-02 10:59 ` [PATCH 11/14] soundwire: fix more typos Vinod Koul
2019-05-02 10:59 ` [PATCH 12/14] soundwire: wrap macro argument in parenthesis Vinod Koul
2019-05-02 10:59 ` [PATCH 13/14] soundwire: add a blank line between functions Vinod Koul
2019-05-02 10:59 ` [PATCH 14/14] soundwire: remove multiple blank lines Vinod Koul
2019-05-02 15:10 ` [PATCH 00/14] soundwire: more code cleanups Greg KH
2019-05-02 15:19 ` Greg KH
2019-05-02 15:42 ` Pierre-Louis Bossart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7929c54b-2b00-cbc3-4aa7-6966b0bf2259@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=gregkh@linuxfoundation.org \
--cc=sanyog.r.kale@intel.com \
--cc=shreyas.nc@intel.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.