All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Andrey Konovalov <andreyknvl@google.com>
Cc: linux-usb@vger.kernel.org, linux-media@vger.kernel.org,
	Alan Stern <stern@rowland.harvard.edu>,
	Mike Isely <isely@pobox.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	linux-kernel@vger.kernel.org,
	syzbot+af8f8d2ac0d39b0ed3a0@syzkaller.appspotmail.com,
	syzbot+170a86bf206dd2c6217e@syzkaller.appspotmail.com
Subject: media: pvrusb2: use a different format for warnings
Date: Thu, 2 May 2019 18:39:07 +0200	[thread overview]
Message-ID: <20190502163907.GA14995@kroah.com> (raw)

On Thu, May 02, 2019 at 06:09:26PM +0200, Andrey Konovalov wrote:
> When the pvrusb2 driver detects that there's something wrong with the
> device, it prints a warning message. Right now those message are
> printed in two different formats:
> 
> 1. ***WARNING*** message here
> 2. WARNING: message here
> 
> There's an issue with the second format. Syzkaller recognizes it as a
> message produced by a WARN_ON(), which is used to indicate a bug in the
> kernel. However pvrusb2 prints those warnings to indicate an issue with
> the device, not the bug in the kernel.
> 
> This patch changes the pvrusb2 driver to consistently use the first
> warning message format. This will unblock syzkaller testing of this
> driver.
> 
> Reported-by: syzbot+af8f8d2ac0d39b0ed3a0@syzkaller.appspotmail.com
> Reported-by: syzbot+170a86bf206dd2c6217e@syzkaller.appspotmail.com
> Signed-off-by: Andrey Konovalov <andreyknvl@google.com>

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Andrey Konovalov <andreyknvl@google.com>
Cc: linux-usb@vger.kernel.org, linux-media@vger.kernel.org,
	Alan Stern <stern@rowland.harvard.edu>,
	Mike Isely <isely@pobox.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	linux-kernel@vger.kernel.org,
	syzbot+af8f8d2ac0d39b0ed3a0@syzkaller.appspotmail.com,
	syzbot+170a86bf206dd2c6217e@syzkaller.appspotmail.com
Subject: Re: [PATCH] media: pvrusb2: use a different format for warnings
Date: Thu, 2 May 2019 18:39:07 +0200	[thread overview]
Message-ID: <20190502163907.GA14995@kroah.com> (raw)
Message-ID: <20190502163907.ICha7H-ZhP9C0X-ZjdvViu3XEZy7moLf0l6k0w6Y3Tg@z> (raw)
In-Reply-To: <b3761c6479a49b60316325ebc22da904e36d4538.1556813333.git.andreyknvl@google.com>

On Thu, May 02, 2019 at 06:09:26PM +0200, Andrey Konovalov wrote:
> When the pvrusb2 driver detects that there's something wrong with the
> device, it prints a warning message. Right now those message are
> printed in two different formats:
> 
> 1. ***WARNING*** message here
> 2. WARNING: message here
> 
> There's an issue with the second format. Syzkaller recognizes it as a
> message produced by a WARN_ON(), which is used to indicate a bug in the
> kernel. However pvrusb2 prints those warnings to indicate an issue with
> the device, not the bug in the kernel.
> 
> This patch changes the pvrusb2 driver to consistently use the first
> warning message format. This will unblock syzkaller testing of this
> driver.
> 
> Reported-by: syzbot+af8f8d2ac0d39b0ed3a0@syzkaller.appspotmail.com
> Reported-by: syzbot+170a86bf206dd2c6217e@syzkaller.appspotmail.com
> Signed-off-by: Andrey Konovalov <andreyknvl@google.com>

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

         reply	other threads:[~2019-05-02 16:39 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-02 16:09 media: pvrusb2: use a different format for warnings Andrey Konovalov
2019-05-02 16:09 ` [PATCH] " Andrey Konovalov
2019-05-02 16:39 ` Greg Kroah-Hartman [this message]
2019-05-02 16:39   ` Greg Kroah-Hartman
2019-06-19 14:30   ` Andrey Konovalov
2019-06-19 14:31     ` Andrey Konovalov
2019-06-19 14:44     ` Mauro Carvalho Chehab
2019-06-19 15:24       ` Andrey Konovalov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190502163907.GA14995@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=andreyknvl@google.com \
    --cc=isely@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=stern@rowland.harvard.edu \
    --cc=syzbot+170a86bf206dd2c6217e@syzkaller.appspotmail.com \
    --cc=syzbot+af8f8d2ac0d39b0ed3a0@syzkaller.appspotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.