From: greg at kroah.com (Greg KH)
Subject: [Linux-kernel-mentees] [PATCH] Staging: rtl8192u: ieee80211: Fix coding style warning
Date: Thu, 2 May 2019 19:43:13 +0200 [thread overview]
Message-ID: <20190502174313.GA14857@kroah.com> (raw)
In-Reply-To: <20190502055923.GA21115@arch>
On Thu, May 02, 2019 at 11:29:23AM +0530, Puranjay Mohan wrote:
> Remove braces around a single if statement to fix following
> checkpatch.pl warning.
> WARNING: braces {} are not necessary for single statement blocks
>
> Signed-off-by: Puranjay Mohan <puranjay12 at gmail.com>
> ---
> drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
> index 0e762e559675..c3433ade7144 100644
> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
> @@ -2577,9 +2577,9 @@ static inline void ieee80211_process_probe_response(
> spin_unlock_irqrestore(&ieee->lock, flags);
> if (is_beacon(beacon->header.frame_ctl)&&is_same_network(&ieee->current_network, network, ieee)&&\
> (ieee->state == IEEE80211_LINKED)) {
> - if (ieee->handle_beacon != NULL) {
> + if (ieee->handle_beacon != NULL)
> ieee->handle_beacon(ieee->dev,beacon,&ieee->current_network);
> - }
> +
Again you added trailing whitespace.
Git even complains when you try to apply this :(
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: greg@kroah.com (Greg KH)
Subject: [Linux-kernel-mentees] [PATCH] Staging: rtl8192u: ieee80211: Fix coding style warning
Date: Thu, 2 May 2019 19:43:13 +0200 [thread overview]
Message-ID: <20190502174313.GA14857@kroah.com> (raw)
Message-ID: <20190502174313.nxZnkLI2tp8CU5eZAjfFX5S_y-8CmTp7W4mualP3VVE@z> (raw)
In-Reply-To: <20190502055923.GA21115@arch>
On Thu, May 02, 2019 at 11:29:23AM +0530, Puranjay Mohan wrote:
> Remove braces around a single if statement to fix following
> checkpatch.pl warning.
> WARNING: braces {} are not necessary for single statement blocks
>
> Signed-off-by: Puranjay Mohan <puranjay12 at gmail.com>
> ---
> drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
> index 0e762e559675..c3433ade7144 100644
> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
> @@ -2577,9 +2577,9 @@ static inline void ieee80211_process_probe_response(
> spin_unlock_irqrestore(&ieee->lock, flags);
> if (is_beacon(beacon->header.frame_ctl)&&is_same_network(&ieee->current_network, network, ieee)&&\
> (ieee->state == IEEE80211_LINKED)) {
> - if (ieee->handle_beacon != NULL) {
> + if (ieee->handle_beacon != NULL)
> ieee->handle_beacon(ieee->dev,beacon,&ieee->current_network);
> - }
> +
Again you added trailing whitespace.
Git even complains when you try to apply this :(
greg k-h
next prev parent reply other threads:[~2019-05-02 17:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-02 5:59 [Linux-kernel-mentees] [PATCH] Staging: rtl8192u: ieee80211: Fix coding style warning puranjay12
2019-05-02 5:59 ` Puranjay Mohan
2019-05-02 17:43 ` greg [this message]
2019-05-02 17:43 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190502174313.GA14857@kroah.com \
--to=unknown@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.