From: Johan Hovold <johan@kernel.org>
To: Charles Yeh <charlesyeh522@gmail.com>
Cc: "Johan Hovold" <johan@kernel.org>,
"Greg KH" <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org,
"Yeh.Charles [葉榮鑫]" <charles-yeh@prolific.com.tw>
Subject: [v2] USB:serial:pl2303:Add new PID to support PL2303HXN (TYPE_HXN)
Date: Fri, 3 May 2019 09:41:13 +0200 [thread overview]
Message-ID: <20190503074113.GA17809@localhost> (raw)
On Fri, May 03, 2019 at 03:28:04PM +0800, Charles Yeh wrote:
> Johan Hovold <johan@kernel.org> 於 2019年5月3日 週五 下午3:11寫道：
> > What changed in v2? You forgot to add a changelog here.
> >
> > Looks like this one is not based on the current driver code (e.g. my
> > usb-next branch as we discussed), and also does not address some of the
> > issues raised so far (e.g. you're overwriting the entire flow control
> > register on updates).
> >
>
> I used the Kernel tree:
> git://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git
>
> but the pl2303.c inside does not have the "pl2303_update_reg" you mentioned.
Perhaps you did not use the usb-next branch? That branch has the following
commit:
https://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git/commit/?h=usb-next&id=f64c3ab230682e8395a7fbd01f3eb5140c837d4e
which adds the helper.
Johan
WARNING: multiple messages have this Message-ID (diff)
From: Johan Hovold <johan@kernel.org>
To: Charles Yeh <charlesyeh522@gmail.com>
Cc: "Johan Hovold" <johan@kernel.org>,
"Greg KH" <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org,
"Yeh.Charles [葉榮鑫]" <charles-yeh@prolific.com.tw>
Subject: Re: [PATCH] [PATCH v2] USB:serial:pl2303:Add new PID to support PL2303HXN (TYPE_HXN)
Date: Fri, 3 May 2019 09:41:13 +0200 [thread overview]
Message-ID: <20190503074113.GA17809@localhost> (raw)
Message-ID: <20190503074113.5vXufdJsiyQLtfzXx1xGvlqkjsm9-9BFJ3scP6RxGf4@z> (raw)
In-Reply-To: <CAAZvQQ6EmDu-Rh_LTGCpz7T=3BbCvP=tUDRo=HCCgqscwn8+zA@mail.gmail.com>
On Fri, May 03, 2019 at 03:28:04PM +0800, Charles Yeh wrote:
> Johan Hovold <johan@kernel.org> 於 2019年5月3日 週五 下午3:11寫道：
> > What changed in v2? You forgot to add a changelog here.
> >
> > Looks like this one is not based on the current driver code (e.g. my
> > usb-next branch as we discussed), and also does not address some of the
> > issues raised so far (e.g. you're overwriting the entire flow control
> > register on updates).
> >
>
> I used the Kernel tree:
> git://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git
>
> but the pl2303.c inside does not have the "pl2303_update_reg" you mentioned.
Perhaps you did not use the usb-next branch? That branch has the following
commit:
https://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git/commit/?h=usb-next&id=f64c3ab230682e8395a7fbd01f3eb5140c837d4e
which adds the helper.
Johan
next reply other threads:[~2019-05-03 7:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-03 7:41 Johan Hovold [this message]
2019-05-03 7:41 ` [PATCH] [PATCH v2] USB:serial:pl2303:Add new PID to support PL2303HXN (TYPE_HXN) Johan Hovold
-- strict thread matches above, loose matches on Subject: below --
2019-05-03 8:59 [v2] " Johan Hovold
2019-05-03 8:59 ` [PATCH] [PATCH v2] " Johan Hovold
2019-05-03 8:22 [v2] " Charles Yeh
2019-05-03 8:22 ` [PATCH] [PATCH v2] " Charles Yeh
2019-05-03 7:28 [v2] " Charles Yeh
2019-05-03 7:28 ` [PATCH] [PATCH v2] " Charles Yeh
2019-05-03 7:11 [v2] " Johan Hovold
2019-05-03 7:11 ` [PATCH] [PATCH v2] " Johan Hovold
2019-04-29 12:12 [v2] " Charles Yeh
2019-04-29 12:12 ` [PATCH] [PATCH v2] " Charles Yeh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190503074113.GA17809@localhost \
--to=johan@kernel.org \
--cc=charles-yeh@prolific.com.tw \
--cc=charlesyeh522@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.