From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Boris Brezillon <boris.brezillon@collabora.com>
Cc: Mason Yang <masonccyang@mxic.com.tw>, Vignesh R <vigneshr@ti.com>,
Tudor Ambarus <Tudor.Ambarus@microchip.com>,
Julien Su <juliensu@mxic.com.tw>,
Richard Weinberger <richard@nod.at>,
Boris Brezillon <bbrezillon@kernel.org>,
Schrempf Frieder <frieder.schrempf@kontron.de>,
Paul Cercueil <paul@crapouillou.net>,
Marek Vasut <marek.vasut@gmail.com>,
linux-mtd@lists.infradead.org,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 11/36] mtd: Fix typo in mtd_ooblayout_set_databytes() description
Date: Fri, 3 May 2019 10:18:10 +0200 [thread overview]
Message-ID: <20190503101810.2bea0f9f@xps13> (raw)
In-Reply-To: <20190331133246.61645c15@collabora.com>
Hi Boris,
Boris Brezillon <boris.brezillon@collabora.com> wrote on Sun, 31 Mar
2019 13:32:46 +0200:
> On Mon, 4 Mar 2019 23:28:16 +0100
> Miquel Raynal <miquel.raynal@bootlin.com> wrote:
>
> > Fix a probable copy/paste error: the function works like
> > mtd_ooblayout_set_bytes(), not the *_get_bytes() alternate.
> >
> > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> > ---
> > drivers/mtd/mtdcore.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c
> > index 21e3cdc04036..6ed48018163c 100644
> > --- a/drivers/mtd/mtdcore.c
> > +++ b/drivers/mtd/mtdcore.c
> > @@ -1592,7 +1592,7 @@ EXPORT_SYMBOL_GPL(mtd_ooblayout_get_databytes);
> > * @start: first ECC byte to set
> > * @nbytes: number of ECC bytes to set
>
> Looks like the parameter descriptions are wrong too.
Are you sure? I don't see where.
>
> > *
> > - * Works like mtd_ooblayout_get_bytes(), except it acts on free bytes.
> > + * Works like mtd_ooblayout_set_bytes(), except it acts on free bytes.
> > *
> > * Returns zero on success, a negative error code otherwise.
> > */
>
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Boris Brezillon <boris.brezillon@collabora.com>
Cc: Mason Yang <masonccyang@mxic.com.tw>, Vignesh R <vigneshr@ti.com>,
Tudor Ambarus <Tudor.Ambarus@microchip.com>,
Julien Su <juliensu@mxic.com.tw>,
Richard Weinberger <richard@nod.at>,
Boris Brezillon <bbrezillon@kernel.org>,
Schrempf Frieder <frieder.schrempf@kontron.de>,
Paul Cercueil <paul@crapouillou.net>,
Marek Vasut <marek.vasut@gmail.com>,
linux-mtd@lists.infradead.org,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 11/36] mtd: Fix typo in mtd_ooblayout_set_databytes() description
Date: Fri, 3 May 2019 10:18:10 +0200 [thread overview]
Message-ID: <20190503101810.2bea0f9f@xps13> (raw)
In-Reply-To: <20190331133246.61645c15@collabora.com>
Hi Boris,
Boris Brezillon <boris.brezillon@collabora.com> wrote on Sun, 31 Mar
2019 13:32:46 +0200:
> On Mon, 4 Mar 2019 23:28:16 +0100
> Miquel Raynal <miquel.raynal@bootlin.com> wrote:
>
> > Fix a probable copy/paste error: the function works like
> > mtd_ooblayout_set_bytes(), not the *_get_bytes() alternate.
> >
> > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> > ---
> > drivers/mtd/mtdcore.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c
> > index 21e3cdc04036..6ed48018163c 100644
> > --- a/drivers/mtd/mtdcore.c
> > +++ b/drivers/mtd/mtdcore.c
> > @@ -1592,7 +1592,7 @@ EXPORT_SYMBOL_GPL(mtd_ooblayout_get_databytes);
> > * @start: first ECC byte to set
> > * @nbytes: number of ECC bytes to set
>
> Looks like the parameter descriptions are wrong too.
Are you sure? I don't see where.
>
> > *
> > - * Works like mtd_ooblayout_get_bytes(), except it acts on free bytes.
> > + * Works like mtd_ooblayout_set_bytes(), except it acts on free bytes.
> > *
> > * Returns zero on success, a negative error code otherwise.
> > */
>
Thanks,
Miquèl
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-05-03 8:18 UTC|newest]
Thread overview: 110+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-04 22:28 [PATCH v2 00/36] Introduce the generic ECC engine abstraction Miquel Raynal
2019-03-04 22:28 ` Miquel Raynal
2019-03-04 22:28 ` [PATCH v2 01/36] mtd: nand: Move nand_device forward declaration to the top Miquel Raynal
2019-03-04 22:28 ` Miquel Raynal
2019-03-31 11:12 ` Boris Brezillon
2019-03-31 11:12 ` Boris Brezillon
2019-03-04 22:28 ` [PATCH v2 02/36] mtd: nand: Add an extra level in the Kconfig hierarchy Miquel Raynal
2019-03-04 22:28 ` Miquel Raynal
2019-03-31 11:13 ` Boris Brezillon
2019-03-31 11:13 ` Boris Brezillon
2019-03-04 22:28 ` [PATCH v2 03/36] mtd: nand: Drop useless 'depends on' in Kconfig Miquel Raynal
2019-03-04 22:28 ` Miquel Raynal
2019-03-31 11:15 ` Boris Brezillon
2019-03-31 11:15 ` Boris Brezillon
2019-03-04 22:28 ` [PATCH v2 04/36] mtd: rawnand: Use the NAND core Miquel Raynal
2019-03-04 22:28 ` Miquel Raynal
2019-03-31 11:21 ` Boris Brezillon
2019-03-31 11:21 ` Boris Brezillon
2019-03-04 22:28 ` [PATCH v2 05/36] mtd: nand: Add a NAND page I/O request type Miquel Raynal
2019-03-04 22:28 ` Miquel Raynal
2019-03-31 11:23 ` Boris Brezillon
2019-03-31 11:23 ` Boris Brezillon
2019-03-04 22:28 ` [PATCH v2 06/36] mtd: nand: Rename a core structure Miquel Raynal
2019-03-04 22:28 ` Miquel Raynal
2019-03-31 11:30 ` Boris Brezillon
2019-03-31 11:30 ` Boris Brezillon
2019-05-03 8:26 ` Miquel Raynal
2019-05-03 8:26 ` Miquel Raynal
2019-03-04 22:28 ` [PATCH v2 07/36] mtd: rawnand: Avoid a typedef Miquel Raynal
2019-03-04 22:28 ` Miquel Raynal
2019-03-31 11:55 ` Boris Brezillon
2019-03-31 11:55 ` Boris Brezillon
2019-05-03 12:40 ` Miquel Raynal
2019-05-03 12:40 ` Miquel Raynal
2019-05-03 12:50 ` Boris Brezillon
2019-05-03 12:50 ` Boris Brezillon
2019-05-06 15:13 ` Miquel Raynal
2019-05-06 15:13 ` Miquel Raynal
2019-03-04 22:28 ` [PATCH v2 08/36] mtd: rawnand: Add an invalid ECC mode to discriminate with valid ones Miquel Raynal
2019-03-04 22:28 ` Miquel Raynal
2019-03-04 22:28 ` [PATCH v2 09/36] mtd: rawnand: Clarify the values for invalid ECC mode/algo Miquel Raynal
2019-03-04 22:28 ` Miquel Raynal
2019-03-31 11:57 ` Boris Brezillon
2019-03-31 11:57 ` Boris Brezillon
2019-03-04 22:28 ` [PATCH v2 10/36] mtd: nand: Introduce the ECC engine abstraction Miquel Raynal
2019-03-04 22:28 ` Miquel Raynal
2019-03-31 12:10 ` Boris Brezillon
2019-03-31 12:10 ` Boris Brezillon
2019-05-03 14:34 ` Miquel Raynal
2019-05-03 14:34 ` Miquel Raynal
2019-05-03 15:54 ` Boris Brezillon
2019-05-03 15:54 ` Boris Brezillon
2019-05-06 15:49 ` Miquel Raynal
2019-05-06 15:49 ` Miquel Raynal
2019-03-04 22:28 ` [PATCH v2 11/36] mtd: Fix typo in mtd_ooblayout_set_databytes() description Miquel Raynal
2019-03-04 22:28 ` Miquel Raynal
2019-03-31 11:32 ` Boris Brezillon
2019-03-31 11:32 ` Boris Brezillon
2019-05-03 8:18 ` Miquel Raynal [this message]
2019-05-03 8:18 ` Miquel Raynal
2019-03-04 22:28 ` [PATCH v2 12/36] mtd: nand: Move standard OOB layouts to the generic ECC core Miquel Raynal
2019-03-04 22:28 ` Miquel Raynal
2019-03-04 22:28 ` [PATCH v2 13/36] mtd: nand: Move ECC specific functions to ecc/engine.c Miquel Raynal
2019-03-04 22:28 ` Miquel Raynal
2019-03-04 22:28 ` [PATCH v2 14/36] mtd: nand: ecc: Move BCH code into the ecc/ directory Miquel Raynal
2019-03-04 22:28 ` Miquel Raynal
2019-03-04 22:28 ` [PATCH v2 15/36] mtd: nand: ecc: Use SPDX license identifier for the software BCH code Miquel Raynal
2019-03-04 22:28 ` Miquel Raynal
2019-03-04 22:28 ` [PATCH v2 16/36] mtd: nand: ecc: Turn the software BCH implementation generic Miquel Raynal
2019-03-04 22:28 ` Miquel Raynal
2019-03-04 22:28 ` [PATCH v2 17/36] mtd: rawnand: Get rid of chip->ecc.priv Miquel Raynal
2019-03-04 22:28 ` Miquel Raynal
2019-03-04 22:28 ` [PATCH v2 18/36] mtd: nand: ecc: Move Hamming code into the ecc/ directory Miquel Raynal
2019-03-04 22:28 ` Miquel Raynal
2019-03-04 22:28 ` [PATCH v2 19/36] mtd: nand: ecc: Use SPDX license identifier for the software Hamming code Miquel Raynal
2019-03-04 22:28 ` Miquel Raynal
2019-03-04 22:28 ` [PATCH v2 20/36] mtd: nand: ecc: Clarify the software Hamming introductory line Miquel Raynal
2019-03-04 22:28 ` Miquel Raynal
2019-03-04 22:28 ` [PATCH v2 21/36] mtd: nand: ecc: Turn the software Hamming implementation generic Miquel Raynal
2019-03-04 22:28 ` Miquel Raynal
2019-03-04 22:28 ` [PATCH v2 22/36] mtd: nand: Remove useless include about software Hamming ECC Miquel Raynal
2019-03-04 22:28 ` Miquel Raynal
2019-03-04 22:28 ` [PATCH v2 23/36] mtd: nand: ecc: Let the software BCH ECC engine be a module Miquel Raynal
2019-03-04 22:28 ` Miquel Raynal
2019-03-04 22:28 ` [PATCH v2 24/36] mtd: nand: ecc: Let the software Hamming ECC engine be unselected Miquel Raynal
2019-03-04 22:28 ` Miquel Raynal
2019-03-04 22:28 ` [PATCH v2 25/36] mtd: nand: ecc: Create the software BCH engine instance Miquel Raynal
2019-03-04 22:28 ` Miquel Raynal
2019-03-04 22:28 ` [PATCH v2 26/36] mtd: nand: ecc: Create the software Hamming " Miquel Raynal
2019-03-04 22:28 ` Miquel Raynal
2019-03-04 22:28 ` [PATCH v2 27/36] mtd: nand: Let software ECC engines be retrieved from the NAND core Miquel Raynal
2019-03-04 22:28 ` Miquel Raynal
2019-03-04 22:28 ` [PATCH v2 28/36] mtd: spinand: Fix typo in comment Miquel Raynal
2019-03-04 22:28 ` Miquel Raynal
2019-03-04 22:28 ` [PATCH v2 29/36] mtd: spinand: Move ECC related definitions earlier in the driver Miquel Raynal
2019-03-04 22:28 ` Miquel Raynal
2019-03-04 22:28 ` [PATCH v2 30/36] mtd: spinand: Instantiate a SPI-NAND on-die ECC engine Miquel Raynal
2019-03-04 22:28 ` Miquel Raynal
2019-03-04 22:28 ` [PATCH v2 31/36] mtd: nand: Let on-die ECC engines be retrieved from the NAND core Miquel Raynal
2019-03-04 22:28 ` Miquel Raynal
2019-03-04 22:28 ` [PATCH v2 32/36] mtd: rawnand: Fill a default ECC provider/algorithm Miquel Raynal
2019-03-04 22:28 ` Miquel Raynal
2019-03-04 22:28 ` [PATCH v2 33/36] mtd: spinand: " Miquel Raynal
2019-03-04 22:28 ` Miquel Raynal
2019-03-04 22:28 ` [PATCH v2 34/36] mtd: nand: Add helpers to manage ECC engines and configurations Miquel Raynal
2019-03-04 22:28 ` Miquel Raynal
2019-03-04 22:28 ` [PATCH v2 35/36] mtd: spinand: Use the external ECC engine logic Miquel Raynal
2019-03-04 22:28 ` Miquel Raynal
2019-03-04 22:28 ` [PATCH v2 36/36] mtd: spinand: Propagate ECC information to the MTD structure Miquel Raynal
2019-03-04 22:28 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190503101810.2bea0f9f@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=Tudor.Ambarus@microchip.com \
--cc=bbrezillon@kernel.org \
--cc=boris.brezillon@collabora.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=frieder.schrempf@kontron.de \
--cc=juliensu@mxic.com.tw \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=masonccyang@mxic.com.tw \
--cc=paul@crapouillou.net \
--cc=richard@nod.at \
--cc=thomas.petazzoni@bootlin.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.