From: Oscar Salvador <osalvador@suse.de>
To: Pavel Tatashin <pasha.tatashin@soleen.com>
Cc: "Michal Hocko" <mhocko@suse.com>,
linux-nvdimm <linux-nvdimm@lists.01.org>,
"David Hildenbrand" <david@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>,
"Jérôme Glisse" <jglisse@redhat.com>,
"Robin Murphy" <robin.murphy@arm.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Vlastimil Babka" <vbabka@suse.cz>
Subject: Re: [PATCH v6 02/12] mm/sparsemem: Introduce common definitions for the size and mask of a section
Date: Fri, 3 May 2019 15:00:29 +0200 [thread overview]
Message-ID: <20190503130023.GA22564@linux> (raw)
In-Reply-To: <CA+CK2bBS5Csz0O9sDVwt_NjtrBtLaMfkycjhaOmR7mXoKJ5XEg@mail.gmail.com>
On Fri, May 03, 2019 at 08:57:09AM -0400, Pavel Tatashin wrote:
> On Fri, May 3, 2019 at 6:35 AM Robin Murphy <robin.murphy@arm.com> wrote:
> >
> > On 03/05/2019 01:41, Dan Williams wrote:
> > > On Thu, May 2, 2019 at 7:53 AM Pavel Tatashin <pasha.tatashin@soleen.com> wrote:
> > >>
> > >> On Wed, Apr 17, 2019 at 2:52 PM Dan Williams <dan.j.williams@intel.com> wrote:
> > >>>
> > >>> Up-level the local section size and mask from kernel/memremap.c to
> > >>> global definitions. These will be used by the new sub-section hotplug
> > >>> support.
> > >>>
> > >>> Cc: Michal Hocko <mhocko@suse.com>
> > >>> Cc: Vlastimil Babka <vbabka@suse.cz>
> > >>> Cc: Jérôme Glisse <jglisse@redhat.com>
> > >>> Cc: Logan Gunthorpe <logang@deltatee.com>
> > >>> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> > >>
> > >> Should be dropped from this series as it has been replaced by a very
> > >> similar patch in the mainline:
> > >>
> > >> 7c697d7fb5cb14ef60e2b687333ba3efb74f73da
> > >> mm/memremap: Rename and consolidate SECTION_SIZE
> > >
> > > I saw that patch fly by and acked it, but I have not seen it picked up
> > > anywhere. I grabbed latest -linus and -next, but don't see that
> > > commit.
> > >
> > > $ git show 7c697d7fb5cb14ef60e2b687333ba3efb74f73da
> > > fatal: bad object 7c697d7fb5cb14ef60e2b687333ba3efb74f73da
> >
> > Yeah, I don't recognise that ID either, nor have I had any notifications
> > that Andrew's picked up anything of mine yet :/
>
> Sorry for the confusion. I thought I checked in a master branch, but
> turns out I checked in a branch where I applied arm hotremove patches
> and Robin's patch as well. These two patches are essentially the same,
> so which one goes first the other should be dropped.
>
> Reviewed-by: Pavel Tatashin <pasha.tatashin@soleen.com>
Hey Pavel,
just a friendly note :-) :
you are reviewing v6, I think you might want to review v7 [1] instead ;-)?
[1] https://patchwork.kernel.org/cover/10926035/
--
Oscar Salvador
SUSE L3
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: Oscar Salvador <osalvador@suse.de>
To: Pavel Tatashin <pasha.tatashin@soleen.com>
Cc: "Robin Murphy" <robin.murphy@arm.com>,
"Dan Williams" <dan.j.williams@intel.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Michal Hocko" <mhocko@suse.com>,
"Vlastimil Babka" <vbabka@suse.cz>,
"Jérôme Glisse" <jglisse@redhat.com>,
"Logan Gunthorpe" <logang@deltatee.com>,
linux-mm <linux-mm@kvack.org>,
linux-nvdimm <linux-nvdimm@lists.01.org>,
LKML <linux-kernel@vger.kernel.org>,
"David Hildenbrand" <david@redhat.com>
Subject: Re: [PATCH v6 02/12] mm/sparsemem: Introduce common definitions for the size and mask of a section
Date: Fri, 3 May 2019 15:00:29 +0200 [thread overview]
Message-ID: <20190503130023.GA22564@linux> (raw)
In-Reply-To: <CA+CK2bBS5Csz0O9sDVwt_NjtrBtLaMfkycjhaOmR7mXoKJ5XEg@mail.gmail.com>
On Fri, May 03, 2019 at 08:57:09AM -0400, Pavel Tatashin wrote:
> On Fri, May 3, 2019 at 6:35 AM Robin Murphy <robin.murphy@arm.com> wrote:
> >
> > On 03/05/2019 01:41, Dan Williams wrote:
> > > On Thu, May 2, 2019 at 7:53 AM Pavel Tatashin <pasha.tatashin@soleen.com> wrote:
> > >>
> > >> On Wed, Apr 17, 2019 at 2:52 PM Dan Williams <dan.j.williams@intel.com> wrote:
> > >>>
> > >>> Up-level the local section size and mask from kernel/memremap.c to
> > >>> global definitions. These will be used by the new sub-section hotplug
> > >>> support.
> > >>>
> > >>> Cc: Michal Hocko <mhocko@suse.com>
> > >>> Cc: Vlastimil Babka <vbabka@suse.cz>
> > >>> Cc: Jérôme Glisse <jglisse@redhat.com>
> > >>> Cc: Logan Gunthorpe <logang@deltatee.com>
> > >>> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> > >>
> > >> Should be dropped from this series as it has been replaced by a very
> > >> similar patch in the mainline:
> > >>
> > >> 7c697d7fb5cb14ef60e2b687333ba3efb74f73da
> > >> mm/memremap: Rename and consolidate SECTION_SIZE
> > >
> > > I saw that patch fly by and acked it, but I have not seen it picked up
> > > anywhere. I grabbed latest -linus and -next, but don't see that
> > > commit.
> > >
> > > $ git show 7c697d7fb5cb14ef60e2b687333ba3efb74f73da
> > > fatal: bad object 7c697d7fb5cb14ef60e2b687333ba3efb74f73da
> >
> > Yeah, I don't recognise that ID either, nor have I had any notifications
> > that Andrew's picked up anything of mine yet :/
>
> Sorry for the confusion. I thought I checked in a master branch, but
> turns out I checked in a branch where I applied arm hotremove patches
> and Robin's patch as well. These two patches are essentially the same,
> so which one goes first the other should be dropped.
>
> Reviewed-by: Pavel Tatashin <pasha.tatashin@soleen.com>
Hey Pavel,
just a friendly note :-) :
you are reviewing v6, I think you might want to review v7 [1] instead ;-)?
[1] https://patchwork.kernel.org/cover/10926035/
--
Oscar Salvador
SUSE L3
next prev parent reply other threads:[~2019-05-03 13:00 UTC|newest]
Thread overview: 97+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-17 18:38 [PATCH v6 00/12] mm: Sub-section memory hotplug support Dan Williams
2019-04-17 18:38 ` Dan Williams
2019-04-17 18:39 ` [PATCH v6 01/12] mm/sparsemem: Introduce struct mem_section_usage Dan Williams
2019-04-17 18:39 ` Dan Williams
2019-05-01 23:25 ` Pavel Tatashin
2019-05-01 23:25 ` Pavel Tatashin
2019-05-02 6:07 ` Dan Williams
2019-05-02 14:16 ` Pavel Tatashin
2019-05-04 0:22 ` Dan Williams
2019-05-04 0:22 ` Dan Williams
2019-05-04 15:55 ` Pavel Tatashin
2019-05-04 15:55 ` Pavel Tatashin
2019-04-17 18:39 ` [PATCH v6 02/12] mm/sparsemem: Introduce common definitions for the size and mask of a section Dan Williams
2019-04-17 18:39 ` Dan Williams
2019-05-02 14:53 ` Pavel Tatashin
2019-05-03 0:41 ` Dan Williams
2019-05-03 0:41 ` Dan Williams
2019-05-03 10:35 ` Robin Murphy
2019-05-03 10:35 ` Robin Murphy
2019-05-03 12:57 ` Pavel Tatashin
2019-05-03 13:00 ` Oscar Salvador [this message]
2019-05-03 13:00 ` Oscar Salvador
2019-04-17 18:39 ` [PATCH v6 03/12] mm/sparsemem: Add helpers track active portions of a section at boot Dan Williams
2019-04-17 18:39 ` Dan Williams
2019-04-25 14:33 ` Oscar Salvador
2019-04-25 14:43 ` Oscar Salvador
2019-04-25 14:43 ` Oscar Salvador
2019-04-26 12:57 ` Oscar Salvador
2019-04-26 12:57 ` Oscar Salvador
2019-05-02 16:12 ` Pavel Tatashin
2019-05-02 16:12 ` Pavel Tatashin
2019-05-04 19:26 ` Dan Williams
2019-05-04 19:26 ` Dan Williams
2019-05-04 19:40 ` Pavel Tatashin
2019-05-04 19:40 ` Pavel Tatashin
2019-04-17 18:39 ` [PATCH v6 04/12] mm/hotplug: Prepare shrink_{zone, pgdat}_span for sub-section removal Dan Williams
2019-04-17 18:39 ` Dan Williams
2019-04-19 23:09 ` Ralph Campbell
2019-04-19 23:09 ` Ralph Campbell
2019-04-19 23:13 ` Dan Williams
2019-04-19 23:13 ` Dan Williams
2019-04-26 13:59 ` Oscar Salvador
2019-04-26 14:00 ` Oscar Salvador
2019-05-02 19:18 ` Pavel Tatashin
2019-05-02 19:18 ` Pavel Tatashin
2019-04-17 18:39 ` [PATCH v6 05/12] mm/sparsemem: Convert kmalloc_section_memmap() to populate_section_memmap() Dan Williams
2019-04-17 18:39 ` Dan Williams
2019-05-02 19:28 ` Pavel Tatashin
2019-04-17 18:39 ` [PATCH v6 06/12] mm/hotplug: Add mem-hotplug restrictions for remove_memory() Dan Williams
2019-04-17 18:39 ` Dan Williams
2019-04-23 21:21 ` David Hildenbrand
2019-04-23 21:21 ` David Hildenbrand
2019-04-24 18:07 ` Dan Williams
2019-04-17 18:39 ` [PATCH v6 07/12] mm: Kill is_dev_zone() helper Dan Williams
2019-04-17 18:39 ` Dan Williams
2019-04-17 20:17 ` David Hildenbrand
2019-04-17 20:17 ` David Hildenbrand
2019-04-26 14:04 ` Oscar Salvador
2019-04-26 14:04 ` Oscar Salvador
2019-05-02 20:37 ` Pavel Tatashin
2019-05-02 20:37 ` Pavel Tatashin
2019-04-17 18:39 ` [PATCH v6 08/12] mm/sparsemem: Prepare for sub-section ranges Dan Williams
2019-04-17 18:39 ` Dan Williams
2019-05-02 21:25 ` Pavel Tatashin
2019-05-02 21:25 ` Pavel Tatashin
2019-04-17 18:39 ` [PATCH v6 09/12] mm/sparsemem: Support sub-section hotplug Dan Williams
2019-04-17 18:39 ` Dan Williams
2019-04-17 18:39 ` [PATCH v6 10/12] mm/devm_memremap_pages: Enable sub-section remap Dan Williams
2019-04-17 18:39 ` Dan Williams
2019-04-17 18:39 ` [PATCH v6 11/12] libnvdimm/pfn: Fix fsdax-mode namespace info-block zero-fields Dan Williams
2019-04-17 18:39 ` Dan Williams
2019-04-17 22:02 ` Andrew Morton
2019-04-17 22:02 ` Andrew Morton
2019-04-17 22:09 ` Dan Williams
2019-04-17 18:39 ` [PATCH v6 12/12] libnvdimm/pfn: Stop padding pmem namespaces to section alignment Dan Williams
2019-04-17 18:39 ` Dan Williams
2019-04-17 22:03 ` [PATCH v6 00/12] mm: Sub-section memory hotplug support Andrew Morton
2019-04-17 22:03 ` Andrew Morton
2019-04-17 22:59 ` Dan Williams
2019-04-17 22:59 ` Dan Williams
2019-04-18 2:09 ` Dan Williams
2019-04-18 2:09 ` Dan Williams
2019-04-18 12:45 ` Jeff Moyer
2019-04-18 12:45 ` Jeff Moyer
2019-04-19 3:25 ` Dan Williams
2019-04-19 3:25 ` Dan Williams
2019-04-23 13:16 ` Oscar Salvador
2019-04-23 13:16 ` Oscar Salvador
2019-04-24 20:43 ` Pavel Tatashin
2019-04-24 20:43 ` Pavel Tatashin
2019-05-02 22:46 ` Pavel Tatashin
2019-05-02 23:20 ` Dan Williams
2019-05-02 23:20 ` Dan Williams
2019-05-02 23:21 ` Dan Williams
2019-05-02 23:21 ` Dan Williams
2019-05-03 10:48 ` Oscar Salvador
2019-05-03 10:48 ` Oscar Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190503130023.GA22564@linux \
--to=osalvador@suse.de \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=jglisse@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
--cc=mhocko@suse.com \
--cc=pasha.tatashin@soleen.com \
--cc=robin.murphy@arm.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.