* [PATCH nft] parser_json: default to unspecified l3proto for ct helper/timeout
@ 2019-05-02 16:20 Eric Garver
2019-05-03 15:07 ` Phil Sutter
2019-05-03 15:33 ` Pablo Neira Ayuso
0 siblings, 2 replies; 3+ messages in thread
From: Eric Garver @ 2019-05-02 16:20 UTC (permalink / raw)
To: netfilter-devel; +Cc: Phil Sutter
As per the man page, if the user does not specify the l3proto it should
be derived from the table family.
Fixes: 586ad210368b ("libnftables: Implement JSON parser")
Signed-off-by: Eric Garver <eric@garver.life>
---
src/parser_json.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/parser_json.c b/src/parser_json.c
index 3fbb4457ddac..3dc3a5c5f93c 100644
--- a/src/parser_json.c
+++ b/src/parser_json.c
@@ -2817,7 +2817,7 @@ static struct cmd *json_parse_cmd_add_object(struct json_ctx *ctx,
enum cmd_obj cmd_obj)
{
const char *family, *tmp, *rate_unit = "packets", *burst_unit = "bytes";
- uint32_t l3proto = NFPROTO_IPV4;
+ uint32_t l3proto = NFPROTO_UNSPEC;
struct handle h = { 0 };
struct obj *obj;
int inv = 0;
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH nft] parser_json: default to unspecified l3proto for ct helper/timeout
2019-05-02 16:20 [PATCH nft] parser_json: default to unspecified l3proto for ct helper/timeout Eric Garver
@ 2019-05-03 15:07 ` Phil Sutter
2019-05-03 15:33 ` Pablo Neira Ayuso
1 sibling, 0 replies; 3+ messages in thread
From: Phil Sutter @ 2019-05-03 15:07 UTC (permalink / raw)
To: Eric Garver; +Cc: netfilter-devel
On Thu, May 02, 2019 at 12:20:57PM -0400, Eric Garver wrote:
> As per the man page, if the user does not specify the l3proto it should
> be derived from the table family.
>
> Fixes: 586ad210368b ("libnftables: Implement JSON parser")
> Signed-off-by: Eric Garver <eric@garver.life>
Acked-by: Phil Sutter <phil@nwl.cc>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH nft] parser_json: default to unspecified l3proto for ct helper/timeout
2019-05-02 16:20 [PATCH nft] parser_json: default to unspecified l3proto for ct helper/timeout Eric Garver
2019-05-03 15:07 ` Phil Sutter
@ 2019-05-03 15:33 ` Pablo Neira Ayuso
1 sibling, 0 replies; 3+ messages in thread
From: Pablo Neira Ayuso @ 2019-05-03 15:33 UTC (permalink / raw)
To: Eric Garver; +Cc: netfilter-devel, Phil Sutter
On Thu, May 02, 2019 at 12:20:57PM -0400, Eric Garver wrote:
> As per the man page, if the user does not specify the l3proto it should
> be derived from the table family.
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-05-03 15:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-02 16:20 [PATCH nft] parser_json: default to unspecified l3proto for ct helper/timeout Eric Garver
2019-05-03 15:07 ` Phil Sutter
2019-05-03 15:33 ` Pablo Neira Ayuso
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.