From: Matthias Kaehlcke <mka@chromium.org>
To: Douglas Anderson <dianders@chromium.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Heiko Stuebner <heiko@sntech.de>,
briannorris@chromium.org, linux-kernel@vger.kernel.org,
linux-rockchip@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org, amstan@chromium.org
Subject: Re: [PATCH] ARM: dts: rockchip: Remove bogus 'i2s_clk_out' from rk3288-veyron-mickey
Date: Fri, 3 May 2019 16:58:09 -0700 [thread overview]
Message-ID: <20190503235809.GD40515@google.com> (raw)
In-Reply-To: <20190503234814.230901-1-dianders@chromium.org>
On Fri, May 03, 2019 at 04:48:14PM -0700, Douglas Anderson wrote:
> The rk3288-veyron-mickey device tree overrides the default "i2s" clock
> settings to add the clock for "i2s_clk_out".
>
> That clock is only present in the bindings downstream Chrome OS 3.14
> tree. Upstream the i2s port bindings doesn't specify that as a
> possible clock.
>
> Let's remove it.
>
> NOTE: for other rk3288-veyron devices this clock is consumed by
> 'maxim,max98090'. Presumably if this clock is needed for mickey it'll
> need to be consumed by something similar.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
>
> arch/arm/boot/dts/rk3288-veyron-mickey.dts | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/rk3288-veyron-mickey.dts b/arch/arm/boot/dts/rk3288-veyron-mickey.dts
> index e852594417b5..f9c4ece3c0d3 100644
> --- a/arch/arm/boot/dts/rk3288-veyron-mickey.dts
> +++ b/arch/arm/boot/dts/rk3288-veyron-mickey.dts
> @@ -142,8 +142,6 @@
>
> &i2s {
> status = "okay";
> - clock-names = "i2s_hclk", "i2s_clk", "i2s_clk_out";
> - clocks = <&cru HCLK_I2S0>, <&cru SCLK_I2S0>, <&cru SCLK_I2S0_OUT>;
> };
>
> &rk808 {
effectively, 'i2s_clk_out' is not use in the upstream kernel.
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
WARNING: multiple messages have this Message-ID (diff)
From: Matthias Kaehlcke <mka@chromium.org>
To: Douglas Anderson <dianders@chromium.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Heiko Stuebner <heiko@sntech.de>,
briannorris@chromium.org, linux-kernel@vger.kernel.org,
linux-rockchip@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org, amstan@chromium.org
Subject: Re: [PATCH] ARM: dts: rockchip: Remove bogus 'i2s_clk_out' from rk3288-veyron-mickey
Date: Fri, 3 May 2019 16:58:09 -0700 [thread overview]
Message-ID: <20190503235809.GD40515@google.com> (raw)
In-Reply-To: <20190503234814.230901-1-dianders@chromium.org>
On Fri, May 03, 2019 at 04:48:14PM -0700, Douglas Anderson wrote:
> The rk3288-veyron-mickey device tree overrides the default "i2s" clock
> settings to add the clock for "i2s_clk_out".
>
> That clock is only present in the bindings downstream Chrome OS 3.14
> tree. Upstream the i2s port bindings doesn't specify that as a
> possible clock.
>
> Let's remove it.
>
> NOTE: for other rk3288-veyron devices this clock is consumed by
> 'maxim,max98090'. Presumably if this clock is needed for mickey it'll
> need to be consumed by something similar.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
>
> arch/arm/boot/dts/rk3288-veyron-mickey.dts | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/rk3288-veyron-mickey.dts b/arch/arm/boot/dts/rk3288-veyron-mickey.dts
> index e852594417b5..f9c4ece3c0d3 100644
> --- a/arch/arm/boot/dts/rk3288-veyron-mickey.dts
> +++ b/arch/arm/boot/dts/rk3288-veyron-mickey.dts
> @@ -142,8 +142,6 @@
>
> &i2s {
> status = "okay";
> - clock-names = "i2s_hclk", "i2s_clk", "i2s_clk_out";
> - clocks = <&cru HCLK_I2S0>, <&cru SCLK_I2S0>, <&cru SCLK_I2S0_OUT>;
> };
>
> &rk808 {
effectively, 'i2s_clk_out' is not use in the upstream kernel.
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Matthias Kaehlcke <mka@chromium.org>
To: Douglas Anderson <dianders@chromium.org>
Cc: Heiko Stuebner <heiko@sntech.de>,
linux-rockchip@lists.infradead.org, briannorris@chromium.org,
amstan@chromium.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: dts: rockchip: Remove bogus 'i2s_clk_out' from rk3288-veyron-mickey
Date: Fri, 3 May 2019 16:58:09 -0700 [thread overview]
Message-ID: <20190503235809.GD40515@google.com> (raw)
In-Reply-To: <20190503234814.230901-1-dianders@chromium.org>
On Fri, May 03, 2019 at 04:48:14PM -0700, Douglas Anderson wrote:
> The rk3288-veyron-mickey device tree overrides the default "i2s" clock
> settings to add the clock for "i2s_clk_out".
>
> That clock is only present in the bindings downstream Chrome OS 3.14
> tree. Upstream the i2s port bindings doesn't specify that as a
> possible clock.
>
> Let's remove it.
>
> NOTE: for other rk3288-veyron devices this clock is consumed by
> 'maxim,max98090'. Presumably if this clock is needed for mickey it'll
> need to be consumed by something similar.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
>
> arch/arm/boot/dts/rk3288-veyron-mickey.dts | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/rk3288-veyron-mickey.dts b/arch/arm/boot/dts/rk3288-veyron-mickey.dts
> index e852594417b5..f9c4ece3c0d3 100644
> --- a/arch/arm/boot/dts/rk3288-veyron-mickey.dts
> +++ b/arch/arm/boot/dts/rk3288-veyron-mickey.dts
> @@ -142,8 +142,6 @@
>
> &i2s {
> status = "okay";
> - clock-names = "i2s_hclk", "i2s_clk", "i2s_clk_out";
> - clocks = <&cru HCLK_I2S0>, <&cru SCLK_I2S0>, <&cru SCLK_I2S0_OUT>;
> };
>
> &rk808 {
effectively, 'i2s_clk_out' is not use in the upstream kernel.
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
next prev parent reply other threads:[~2019-05-03 23:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-03 23:48 [PATCH] ARM: dts: rockchip: Remove bogus 'i2s_clk_out' from rk3288-veyron-mickey Douglas Anderson
2019-05-03 23:48 ` Douglas Anderson
2019-05-03 23:58 ` Matthias Kaehlcke [this message]
2019-05-03 23:58 ` Matthias Kaehlcke
2019-05-03 23:58 ` Matthias Kaehlcke
2019-05-07 12:01 ` Heiko Stuebner
2019-05-07 12:01 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190503235809.GD40515@google.com \
--to=mka@chromium.org \
--cc=amstan@chromium.org \
--cc=briannorris@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.