From: minwoo.im.dev@gmail.com (Minwoo Im)
Subject: [PATCH] nvme-trace: Add fabrics command opcode name
Date: Mon, 6 May 2019 00:22:01 +0900 [thread overview]
Message-ID: <20190505152201.23830-1-minwoo.im.dev@gmail.com> (raw)
Opcode 0x7F is for fabrics commands. We can also print it out
"nvme_fabrics_command" instead of 0x7f in raw.
Before this patch:
cmd=(0x7f cdw10=00 00 00 00 1f 00 00 00 98 3a 00 00 ......
After this patch:
cmd=(nvme_fabrics_command cdw10=00 00 00 00 1f 00 00 00 98 3a 00 00 ....
It would be nicer if trace can show which command in fabrics commands
are now being excuted, but not for this time.
Signed-off-by: Minwoo Im <minwoo.im.dev at gmail.com>
---
drivers/nvme/host/trace.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/nvme/host/trace.h b/drivers/nvme/host/trace.h
index 97d3c77365b8..f91580bf2e2f 100644
--- a/drivers/nvme/host/trace.h
+++ b/drivers/nvme/host/trace.h
@@ -37,6 +37,7 @@
nvme_admin_opcode_name(nvme_admin_directive_send), \
nvme_admin_opcode_name(nvme_admin_directive_recv), \
nvme_admin_opcode_name(nvme_admin_dbbuf), \
+ nvme_admin_opcode_name(nvme_fabrics_command), \
nvme_admin_opcode_name(nvme_admin_format_nvm), \
nvme_admin_opcode_name(nvme_admin_security_send), \
nvme_admin_opcode_name(nvme_admin_security_recv), \
--
2.17.1
next reply other threads:[~2019-05-05 15:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-05 15:22 Minwoo Im [this message]
2019-05-06 16:29 ` [PATCH] nvme-trace: Add fabrics command opcode name Chaitanya Kulkarni
2019-05-06 16:31 ` Christoph Hellwig
2019-05-06 16:35 ` Minwoo Im
2019-05-06 16:36 ` Minwoo Im
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190505152201.23830-1-minwoo.im.dev@gmail.com \
--to=minwoo.im.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.