[PATCH] nvme-trace: Add fabrics command opcode name

[PATCH] nvme-trace: Add fabrics command opcode name

[Minwoo Im]

Opcode 0x7F is for fabrics commands.  We can also print it out
"nvme_fabrics_command" instead of 0x7f in raw.

Before this patch:
  cmd=(0x7f cdw10=00 00 00 00 1f 00 00 00 98 3a 00 00 ......

After this patch:
  cmd=(nvme_fabrics_command cdw10=00 00 00 00 1f 00 00 00 98 3a 00 00 ....

It would be nicer if trace can show which command in fabrics commands
are now being excuted, but not for this time.

Signed-off-by: Minwoo Im <minwoo.im.dev at gmail.com>
---
 drivers/nvme/host/trace.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/nvme/host/trace.h b/drivers/nvme/host/trace.h
index 97d3c77365b8..f91580bf2e2f 100644
--- a/drivers/nvme/host/trace.h
+++ b/drivers/nvme/host/trace.h
@@ -37,6 +37,7 @@
 		nvme_admin_opcode_name(nvme_admin_directive_send),	\
 		nvme_admin_opcode_name(nvme_admin_directive_recv),	\
 		nvme_admin_opcode_name(nvme_admin_dbbuf),		\
+		nvme_admin_opcode_name(nvme_fabrics_command),		\
 		nvme_admin_opcode_name(nvme_admin_format_nvm),		\
 		nvme_admin_opcode_name(nvme_admin_security_send),	\
 		nvme_admin_opcode_name(nvme_admin_security_recv),	\
-- 
2.17.1

[PATCH] nvme-trace: Add fabrics command opcode name

[Chaitanya Kulkarni]

Please do not mix admin and fabric commands.
On 05/05/2019 08:22 AM, Minwoo Im wrote:
> Opcode 0x7F is for fabrics commands.  We can also print it out
> "nvme_fabrics_command" instead of 0x7f in raw.
>
> Before this patch:
>    cmd=(0x7f cdw10=00 00 00 00 1f 00 00 00 98 3a 00 00 ......
>
> After this patch:
>    cmd=(nvme_fabrics_command cdw10=00 00 00 00 1f 00 00 00 98 3a 00 00 ....
>
> It would be nicer if trace can show which command in fabrics commands
> are now being excuted, but not for this time.
>
> Signed-off-by: Minwoo Im <minwoo.im.dev at gmail.com>
> ---
>   drivers/nvme/host/trace.h | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/nvme/host/trace.h b/drivers/nvme/host/trace.h
> index 97d3c77365b8..f91580bf2e2f 100644
> --- a/drivers/nvme/host/trace.h
> +++ b/drivers/nvme/host/trace.h
> @@ -37,6 +37,7 @@
>   		nvme_admin_opcode_name(nvme_admin_directive_send),	\
>   		nvme_admin_opcode_name(nvme_admin_directive_recv),	\
>   		nvme_admin_opcode_name(nvme_admin_dbbuf),		\
> +		nvme_admin_opcode_name(nvme_fabrics_command),		\
>   		nvme_admin_opcode_name(nvme_admin_format_nvm),		\
>   		nvme_admin_opcode_name(nvme_admin_security_send),	\
>   		nvme_admin_opcode_name(nvme_admin_security_recv),	\
>

[PATCH] nvme-trace: Add fabrics command opcode name

[Christoph Hellwig]

On Mon, May 06, 2019@04:29:12PM +0000, Chaitanya Kulkarni wrote:
> Please do not mix admin and fabric commands.

Well, "the" fabrics command is an opcode that can show up on
admin or I/O queues.  "the" because it actually is a multiplexer,
and we probably want to decode it instead of just saying fabrics
command in the traces.

[PATCH] nvme-trace: Add fabrics command opcode name

[Minwoo Im]

On 5/7/19 1:31 AM, Christoph Hellwig wrote:
> On Mon, May 06, 2019@04:29:12PM +0000, Chaitanya Kulkarni wrote:
>> Please do not mix admin and fabric commands.
> 
> Well, "the" fabrics command is an opcode that can show up on
> admin or I/O queues.  "the" because it actually is a multiplexer,
> and we probably want to decode it instead of just saying fabrics
> command in the traces.
> 

I'll prepare V2 patch with decoding opcode to show which fabrics 
commands are going on in the trace.

Thanks,

[PATCH] nvme-trace: Add fabrics command opcode name

[Minwoo Im]

On 5/7/19 1:29 AM, Chaitanya Kulkarni wrote:
> Please do not mix admin and fabric commands.

Chaitanya,

Thanks for your review.  I'll prepare V2 for this.

Thanks,