From: Pavel Machek <pavel@ucw.cz>
To: Dan Murphy <dmurphy@ti.com>
Cc: Christian Mauderer <oss@c-mauderer.de>,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH v3 2/2] leds: spi-byte: add single byte SPI LED driver
Date: Mon, 6 May 2019 17:15:01 +0200 [thread overview]
Message-ID: <20190506151500.GA6221@amd> (raw)
In-Reply-To: <fb0bc2a0-1311-3a45-04db-5cddcba48392@ti.com>
[-- Attachment #1: Type: text/plain, Size: 756 bytes --]
Hi!
> > Of course it would have been possible to make it a lot more universal by
> > for example adding a prefix, a bit mask or other word lengths. But that
> > would have added a lot of complexity without any actual application.
> >
>
> I have to disagree here. If this is supposed to be a universal SPI byte driver that
> needs special handling then it is either needs to be created in a universal way or needs to be made
> target specific.
>
Let him be. The driver is good.
If some hardware needs more flexibility, we add it.
No need to have 1000 releases of everything.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2019-05-06 15:15 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-05 20:00 [PATCH v3 1/2] dt-bindings: leds: Add binding for spi-byte LED oss
2019-05-05 20:00 ` [PATCH v3 2/2] leds: spi-byte: add single byte SPI LED driver oss
2019-05-05 20:09 ` Jacek Anaszewski
2019-05-05 20:14 ` Christian Mauderer
2019-05-06 12:05 ` Dan Murphy
2019-05-06 12:59 ` Christian Mauderer
2019-05-06 14:58 ` Dan Murphy
2019-05-06 15:15 ` Pavel Machek [this message]
2019-05-06 15:29 ` Christian Mauderer
2019-05-06 17:40 ` Dan Murphy
2019-05-06 19:12 ` Christian Mauderer
2019-05-06 15:19 ` Christian Mauderer
2019-05-06 15:37 ` Dan Murphy
2019-05-06 15:42 ` Christian Mauderer
2019-05-06 16:21 ` [PATCH v3 1/2] dt-bindings: leds: Add binding for spi-byte LED Rob Herring
2019-05-06 16:28 ` Pavel Machek
2019-05-06 17:44 ` Rob Herring
2019-05-06 19:21 ` Christian Mauderer
2019-05-06 20:25 ` Pavel Machek
2019-05-07 9:52 ` Christian Mauderer
2019-05-10 19:50 ` Christian Mauderer
2019-05-10 20:42 ` Jacek Anaszewski
2019-05-11 6:56 ` Christian Mauderer
2019-05-11 9:11 ` Jacek Anaszewski
2019-05-06 17:03 ` Christian Mauderer
2019-05-06 17:59 ` Rob Herring
2019-05-06 19:28 ` Christian Mauderer
2019-05-06 19:06 ` Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190506151500.GA6221@amd \
--to=pavel@ucw.cz \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=oss@c-mauderer.de \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.