Re: [PATCH v3 1/2] dt-bindings: leds: Add binding for spi-byte LED.

[Pavel Machek <pavel@ucw.cz>]

[-- Attachment #1: Type: text/plain, Size: 1759 bytes --]

Hi!

> > +* Single Byte SPI LED Device Driver.
> > +
> > +The driver can be used for controllers with a very simple SPI protocol: Only one
> > +byte will be sent. The value of the byte can be any value between the off-value
> > +and max-value defined in the properties.
> > +
> > +One example where the driver can be used is the controller in Ubiquiti airCube
> > +ISP devices. That LED controller is based on a 8 bit microcontroller (SONiX
> > +8F26E611LA) that has been programmed to control the single LED of the device.
> 
> What about power control of the uC?
> 
> > +The controller supports four modes depending on the highest two bits in a byte:
> > +One setting for brightness, the other three provide different blink patterns.
> 
> This part seems in no way generic.
> 
> How does one support the blink patterns?
> 
> > +With the leds-spi-byte driver a basic support for the brightness mode of that
> > +controller can be easily achieved by setting the minimum and maximum to the
> > +brightness modes minimum and maximum byte value.
> > +
> > +Required properties:
> > +- compatible:          Should be "leds-spi-byte".
> 
> Generally, we don't do "generic" bindings like this. The exceptions
> are either we have confidence they really can be generic or they where
> created before we knew better. A sample size of 1 doesn't convince me
> the former is true.
> 
> This comment *only* applies to the binding, not the driver. Specific
> bindings can easily be bound to generic drivers.

Ok, I'm afraid I caused this. What should the compatible be, then?

									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]