From: Yury Norov <yury.norov@gmail.com>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: Yury Norov <ynorov@marvell.com>,
linux-kernel@vger.kernel.org, Nicholas Piggin <npiggin@gmail.com>,
Paul Mackerras <paulus@samba.org>,
Breno Leitao <leitao@debian.org>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc: restore current_thread_info()
Date: Tue, 7 May 2019 16:07:46 -0700 [thread overview]
Message-ID: <20190507230746.GA19259@yury-thinkpad> (raw)
In-Reply-To: <20190507225856.GP23075@ZenIV.linux.org.uk>
On Tue, May 07, 2019 at 11:58:56PM +0100, Al Viro wrote:
> On Tue, May 07, 2019 at 03:51:21PM -0700, Yury Norov wrote:
> > Commit ed1cd6deb013 ("powerpc: Activate CONFIG_THREAD_INFO_IN_TASK")
> > removes the function current_thread_info(). It's wrong because the
> > function is used in non-arch code and is part of API.
>
> In include/linux/thread_info.h:
>
> #ifdef CONFIG_THREAD_INFO_IN_TASK
> /*
> * For CONFIG_THREAD_INFO_IN_TASK kernels we need <asm/current.h> for the
> * definition of current, but for !CONFIG_THREAD_INFO_IN_TASK kernels,
> * including <asm/current.h> can cause a circular dependency on some platforms.
> */
> #include <asm/current.h>
> #define current_thread_info() ((struct thread_info *)current)
> #endif
Ah, sorry. Then it might be my rebase issue. I was confused because Christophe
didn't remove the comment to current_thread_info(), so I decided he
removed it erroneously.
WARNING: multiple messages have this Message-ID (diff)
From: Yury Norov <yury.norov@gmail.com>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
Christophe Leroy <christophe.leroy@c-s.fr>,
Breno Leitao <leitao@debian.org>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
Yury Norov <ynorov@marvell.com>
Subject: Re: [PATCH] powerpc: restore current_thread_info()
Date: Tue, 7 May 2019 16:07:46 -0700 [thread overview]
Message-ID: <20190507230746.GA19259@yury-thinkpad> (raw)
In-Reply-To: <20190507225856.GP23075@ZenIV.linux.org.uk>
On Tue, May 07, 2019 at 11:58:56PM +0100, Al Viro wrote:
> On Tue, May 07, 2019 at 03:51:21PM -0700, Yury Norov wrote:
> > Commit ed1cd6deb013 ("powerpc: Activate CONFIG_THREAD_INFO_IN_TASK")
> > removes the function current_thread_info(). It's wrong because the
> > function is used in non-arch code and is part of API.
>
> In include/linux/thread_info.h:
>
> #ifdef CONFIG_THREAD_INFO_IN_TASK
> /*
> * For CONFIG_THREAD_INFO_IN_TASK kernels we need <asm/current.h> for the
> * definition of current, but for !CONFIG_THREAD_INFO_IN_TASK kernels,
> * including <asm/current.h> can cause a circular dependency on some platforms.
> */
> #include <asm/current.h>
> #define current_thread_info() ((struct thread_info *)current)
> #endif
Ah, sorry. Then it might be my rebase issue. I was confused because Christophe
didn't remove the comment to current_thread_info(), so I decided he
removed it erroneously.
next prev parent reply other threads:[~2019-05-07 23:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-07 22:51 [PATCH] powerpc: restore current_thread_info() Yury Norov
2019-05-07 22:58 ` Al Viro
2019-05-07 22:58 ` Al Viro
2019-05-07 23:07 ` Yury Norov [this message]
2019-05-07 23:07 ` Yury Norov
2019-05-08 0:42 ` Michael Ellerman
2019-05-08 0:42 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190507230746.GA19259@yury-thinkpad \
--to=yury.norov@gmail.com \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=npiggin@gmail.com \
--cc=paulus@samba.org \
--cc=viro@zeniv.linux.org.uk \
--cc=ynorov@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.