From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 1/2] nvme: Introduce nvme_is_fabrics to check fabrics cmd
Date: Wed, 8 May 2019 09:23:01 +0200 [thread overview]
Message-ID: <20190508072301.GC21823@lst.de> (raw)
In-Reply-To: <20190506225938epcms2p357314dad168e5822fa4145e7873f5709@epcms2p3>
On Tue, May 07, 2019@07:59:38AM +0900, Minwoo Im wrote:
> Chaitanya,
>
> Thanks for your kindly review on this.
>
> > I'm not sure if we need change right now, reason :-
> >
> > Existing code is pretty straight forward and we are not having
>
> Yeah, the code looks readable. But I thought it would be nicer if
> it can be removed to reduce duplications in code.
>
> > any complicated logic in the helper function. I'll let the
>
> In fact, this is why I have introduced an inline function here. If it
> has complicated logic inside, I would not introduce it. :)
I think I'm ok with this check. We keep growing a few more of those,
so a little helper like this might be useful.
next prev parent reply other threads:[~2019-05-08 7:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-06 19:46 [PATCH V2 0/2] nvme-trace: Add support for fabrics command Minwoo Im
2019-05-06 19:46 ` [PATCH 1/2] nvme: Introduce nvme_is_fabrics to check fabrics cmd Minwoo Im
2019-05-06 22:41 ` Chaitanya Kulkarni
2019-05-06 22:59 ` Minwoo Im
2019-05-08 7:23 ` Christoph Hellwig [this message]
2019-05-06 19:46 ` [PATCH V2 2/2] nvme-trace: Add support to trace fabrics command Minwoo Im
2019-05-06 22:38 ` Chaitanya Kulkarni
2019-05-06 22:56 ` Minwoo Im
2019-05-07 1:37 ` Chaitanya Kulkarni
2019-05-07 10:43 ` Minwoo Im
2019-05-08 7:25 ` Christoph Hellwig
2019-05-08 8:26 ` Minwoo Im
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190508072301.GC21823@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.