All of lore.kernel.org
 help / color / mirror / Atom feed
From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH V2 2/2] nvme-trace: Add support to trace fabrics command
Date: Wed, 8 May 2019 09:25:31 +0200	[thread overview]
Message-ID: <20190508072531.GD21823@lst.de> (raw)
In-Reply-To: <20190506194644.11109-3-minwoo.im.dev@gmail.com>

> +	if (likely(!nvme_is_fabrics(cmd)))
> +		trace_nvme_setup_cmd(req, cmd);
> +	else
> +		trace_nvme_setup_fabrics_cmd(req, cmd);
> +

I wonder if we really need this.  My idea would have been to just
branch out to the fabrics command parser from parse_nvme_cmd().  Or did
I miss something why that might not work?

The benefit is that we don't have an additional branch in the
non-tracing fast path (and also make it look a little nicer).

> +#define show_fabric_type_name(type)					\
> +	show_nvm_fabrics_type_name(type)

Why do we need this #define to the same name/signature?

  parent reply	other threads:[~2019-05-08  7:25 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-06 19:46 [PATCH V2 0/2] nvme-trace: Add support for fabrics command Minwoo Im
2019-05-06 19:46 ` [PATCH 1/2] nvme: Introduce nvme_is_fabrics to check fabrics cmd Minwoo Im
2019-05-06 22:41   ` Chaitanya Kulkarni
2019-05-06 22:59     ` Minwoo Im
2019-05-08  7:23       ` Christoph Hellwig
2019-05-06 19:46 ` [PATCH V2 2/2] nvme-trace: Add support to trace fabrics command Minwoo Im
2019-05-06 22:38   ` Chaitanya Kulkarni
2019-05-06 22:56     ` Minwoo Im
2019-05-07  1:37       ` Chaitanya Kulkarni
2019-05-07 10:43         ` Minwoo Im
2019-05-08  7:25   ` Christoph Hellwig [this message]
2019-05-08  8:26     ` Minwoo Im

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190508072531.GD21823@lst.de \
    --to=hch@lst.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.