From: Lee Jones <lee.jones@linaro.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Maxime Ripard <maxime.ripard@bootlin.com>,
Chen-Yu Tsai <wens@csie.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] mfd: sun6i-prcm: fix build warning for non-OF configurations
Date: Wed, 8 May 2019 09:40:32 +0100 [thread overview]
Message-ID: <20190508084032.GF3995@dell> (raw)
In-Reply-To: <20190416122506.3180853-1-arnd@arndb.de>
On Tue, 16 Apr 2019, Arnd Bergmann wrote:
> When CONFIG_OF is disabled, we get a harmless warning about an
> unused variable:
>
> drivers/mfd/sun6i-prcm.c: In function 'sun6i_prcm_probe':
> drivers/mfd/sun6i-prcm.c:151:22: error: unused variable 'np' [-Werror=unused-variable]
>
> Remove the variable and open-code the value in the only place
> it is used, so it can get left out as well without CONFIG_OF.
>
> Fixes: a05a2e7998ab ("mfd: sun6i-prcm: Allow to compile with COMPILE_TEST")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/mfd/sun6i-prcm.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Maxime Ripard <maxime.ripard@bootlin.com>,
Chen-Yu Tsai <wens@csie.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: sun6i-prcm: fix build warning for non-OF configurations
Date: Wed, 8 May 2019 09:40:32 +0100 [thread overview]
Message-ID: <20190508084032.GF3995@dell> (raw)
In-Reply-To: <20190416122506.3180853-1-arnd@arndb.de>
On Tue, 16 Apr 2019, Arnd Bergmann wrote:
> When CONFIG_OF is disabled, we get a harmless warning about an
> unused variable:
>
> drivers/mfd/sun6i-prcm.c: In function 'sun6i_prcm_probe':
> drivers/mfd/sun6i-prcm.c:151:22: error: unused variable 'np' [-Werror=unused-variable]
>
> Remove the variable and open-code the value in the only place
> it is used, so it can get left out as well without CONFIG_OF.
>
> Fixes: a05a2e7998ab ("mfd: sun6i-prcm: Allow to compile with COMPILE_TEST")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/mfd/sun6i-prcm.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2019-05-08 8:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-16 12:24 [PATCH] mfd: sun6i-prcm: fix build warning for non-OF configurations Arnd Bergmann
2019-04-16 12:24 ` Arnd Bergmann
2019-04-16 12:41 ` Maxime Ripard
2019-04-16 12:41 ` Maxime Ripard
2019-05-08 8:40 ` Lee Jones [this message]
2019-05-08 8:40 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190508084032.GF3995@dell \
--to=lee.jones@linaro.org \
--cc=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@bootlin.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.