From: Lee Jones <lee.jones@linaro.org>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: linux-kbuild@vger.kernel.org,
Stephen Rothwell <sfr@canb.auug.org.au>,
Alexey Gladkov <gladkov.alexey@gmail.com>,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Tony Lindgren <tony@atomide.com>,
Aaro Koskinen <aaro.koskinen@iki.fi>,
linux-omap@vger.kernel.org, Russell King <linux@armlinux.org.uk>,
linux-arm-kernel@lists.infradead.org,
Daniel Lezcano <daniel.lezcano@linaro.org>
Subject: Re: [PATCH] Remove MODULE_ALIAS() calls that take undefined macro
Date: Wed, 8 May 2019 12:37:52 +0100 [thread overview]
Message-ID: <20190508113752.GE31645@dell> (raw)
In-Reply-To: <1557163697-17882-1-git-send-email-yamada.masahiro@socionext.com>
On Tue, 07 May 2019, Masahiro Yamada wrote:
> These files do not define (USBHS_)DRIVER_NAME. Yet, they can be
> successfully compiled because they are never built as a module by
> anyone, i.e, the MODULE_ALIAS() calls are always no-op.
>
> A problem showed up when a patch "moduleparam: Save information about
> built-in modules in separate file" is applied. With this new feature,
> MODULE_*() are populated even if the callers are built-in.
>
> To avoid the build errors, the lines referencing to the undefined
> macro must be removed.
>
> The complete fix is to remove all MODULE_* and #include <linux/module.h>
> like many "make ... explicitly non-modular" commits did.
>
> For now, I am touching the offending lines.
>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> I will insert this commit before
> "moduleparam: Save information about built-in modules in separate file"
>
>
> arch/arm/plat-omap/dma.c | 1 -
> drivers/clocksource/timer-ti-dm.c | 1 -
> drivers/mfd/omap-usb-tll.c | 1 -
For my own reference:
Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
linux-kbuild@vger.kernel.org, Tony Lindgren <tony@atomide.com>,
Alexey Gladkov <gladkov.alexey@gmail.com>,
Aaro Koskinen <aaro.koskinen@iki.fi>,
linux-kernel@vger.kernel.org,
Russell King <linux@armlinux.org.uk>,
Thomas Gleixner <tglx@linutronix.de>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] Remove MODULE_ALIAS() calls that take undefined macro
Date: Wed, 8 May 2019 12:37:52 +0100 [thread overview]
Message-ID: <20190508113752.GE31645@dell> (raw)
In-Reply-To: <1557163697-17882-1-git-send-email-yamada.masahiro@socionext.com>
On Tue, 07 May 2019, Masahiro Yamada wrote:
> These files do not define (USBHS_)DRIVER_NAME. Yet, they can be
> successfully compiled because they are never built as a module by
> anyone, i.e, the MODULE_ALIAS() calls are always no-op.
>
> A problem showed up when a patch "moduleparam: Save information about
> built-in modules in separate file" is applied. With this new feature,
> MODULE_*() are populated even if the callers are built-in.
>
> To avoid the build errors, the lines referencing to the undefined
> macro must be removed.
>
> The complete fix is to remove all MODULE_* and #include <linux/module.h>
> like many "make ... explicitly non-modular" commits did.
>
> For now, I am touching the offending lines.
>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> I will insert this commit before
> "moduleparam: Save information about built-in modules in separate file"
>
>
> arch/arm/plat-omap/dma.c | 1 -
> drivers/clocksource/timer-ti-dm.c | 1 -
> drivers/mfd/omap-usb-tll.c | 1 -
For my own reference:
Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-05-08 11:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-06 17:28 [PATCH] Remove MODULE_ALIAS() calls that take undefined macro Masahiro Yamada
2019-05-06 17:28 ` Masahiro Yamada
2019-05-06 17:28 ` Masahiro Yamada
2019-05-06 17:39 ` Daniel Lezcano
2019-05-06 17:39 ` Daniel Lezcano
2019-05-06 21:11 ` Tony Lindgren
2019-05-06 21:11 ` Tony Lindgren
2019-05-08 11:37 ` Lee Jones [this message]
2019-05-08 11:37 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190508113752.GE31645@dell \
--to=lee.jones@linaro.org \
--cc=aaro.koskinen@iki.fi \
--cc=daniel.lezcano@linaro.org \
--cc=gladkov.alexey@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
--cc=tony@atomide.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.