All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Brian Foster <bfoster@redhat.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 3/6] xfs: use locality optimized cntbt lookups for near mode allocations
Date: Fri, 10 May 2019 10:31:10 -0700	[thread overview]
Message-ID: <20190510173110.GC18992@infradead.org> (raw)
In-Reply-To: <20190509165839.44329-4-bfoster@redhat.com>

Still digesting the algorithmic changes, but a few nitpicks below:

>  /*
> + * BLock allocation algorithm and data structures.

I think the upper case L is a typo.

> +struct xfs_alloc_btree_cur {
> +	struct xfs_btree_cur	*cur;		/* cursor */
> +	bool			active;		/* cursor active flag */
> +};

Can't we move the active flag inside the btree_cur, more specically
into enum xfs_btree_cur_private?

Or maybe we should byte the bullet and make xfs_btree_cur a structure
embedded into the type specific structures and use container_of.
But I certainly don't want to burden that on you and this series..

  reply	other threads:[~2019-05-10 17:31 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-09 16:58 [PATCH 0/6] xfs: rework extent allocation Brian Foster
2019-05-09 16:58 ` [PATCH 1/6] xfs: refactor small allocation helper to skip cntbt attempt Brian Foster
2019-05-10 17:24   ` Christoph Hellwig
2019-05-13 15:44     ` Brian Foster
2019-05-15  7:52       ` Christoph Hellwig
2019-05-15 14:41         ` Brian Foster
2019-05-09 16:58 ` [PATCH 2/6] xfs: always update params on small allocation Brian Foster
2019-05-10 17:26   ` Christoph Hellwig
2019-05-09 16:58 ` [PATCH 3/6] xfs: use locality optimized cntbt lookups for near mode allocations Brian Foster
2019-05-10 17:31   ` Christoph Hellwig [this message]
2019-05-13 15:45     ` Brian Foster
2019-05-15  7:54       ` Christoph Hellwig
2019-05-09 16:58 ` [PATCH 4/6] xfs: refactor exact extent allocation mode Brian Foster
2019-05-09 16:58 ` [PATCH 5/6] xfs: refactor by-size " Brian Foster
2019-05-10 17:34   ` Christoph Hellwig
2019-05-13 15:46     ` Brian Foster
2019-05-15  8:10       ` Christoph Hellwig
2019-05-15 14:42         ` Brian Foster
2019-05-09 16:58 ` [PATCH 6/6] xfs: replace small allocation logic with agfl only logic Brian Foster
2019-05-15  7:53   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190510173110.GC18992@infradead.org \
    --to=hch@infradead.org \
    --cc=bfoster@redhat.com \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.