All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Brian Foster <bfoster@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/6] xfs: refactor small allocation helper to skip cntbt attempt
Date: Wed, 15 May 2019 00:52:53 -0700	[thread overview]
Message-ID: <20190515075253.GG29211@infradead.org> (raw)
In-Reply-To: <20190513154433.GD61135@bfoster>

On Mon, May 13, 2019 at 11:44:34AM -0400, Brian Foster wrote:
> The only functional change was basically to check for ccur before using
> it and initializing i to zero. It just seemed to make sense to clean up
> the surrounding code while there, but I can either split out the
> aesthetic cleanup or defer that stuff to the broader rework at the end
> of the series (where the cursor stuff just gets ripped out anyways) if
> either of those is cleaner..

Yeah, I noticed how trivial the actual change was.  That is why just
doing the cleanup in pass 1 and applying the change in pass 2 might
make it more readbale.  It might also be worth to throw in the use
a goto label instead of long conditionals from your last patch into
that cleanup prep patch.

  reply	other threads:[~2019-05-15  7:52 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-09 16:58 [PATCH 0/6] xfs: rework extent allocation Brian Foster
2019-05-09 16:58 ` [PATCH 1/6] xfs: refactor small allocation helper to skip cntbt attempt Brian Foster
2019-05-10 17:24   ` Christoph Hellwig
2019-05-13 15:44     ` Brian Foster
2019-05-15  7:52       ` Christoph Hellwig [this message]
2019-05-15 14:41         ` Brian Foster
2019-05-09 16:58 ` [PATCH 2/6] xfs: always update params on small allocation Brian Foster
2019-05-10 17:26   ` Christoph Hellwig
2019-05-09 16:58 ` [PATCH 3/6] xfs: use locality optimized cntbt lookups for near mode allocations Brian Foster
2019-05-10 17:31   ` Christoph Hellwig
2019-05-13 15:45     ` Brian Foster
2019-05-15  7:54       ` Christoph Hellwig
2019-05-09 16:58 ` [PATCH 4/6] xfs: refactor exact extent allocation mode Brian Foster
2019-05-09 16:58 ` [PATCH 5/6] xfs: refactor by-size " Brian Foster
2019-05-10 17:34   ` Christoph Hellwig
2019-05-13 15:46     ` Brian Foster
2019-05-15  8:10       ` Christoph Hellwig
2019-05-15 14:42         ` Brian Foster
2019-05-09 16:58 ` [PATCH 6/6] xfs: replace small allocation logic with agfl only logic Brian Foster
2019-05-15  7:53   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190515075253.GG29211@infradead.org \
    --to=hch@infradead.org \
    --cc=bfoster@redhat.com \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.